rename: slopsmith → feedBack, byron → got-feedBack (#537)

* Update GitHub repo references from feedback* to feedBack*

* rename: slopsmith -> feedBack, byron -> got-feedBack

Renames across the entire codebase:
- slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack
- byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack
- /home/byron/ -> /opt/got-feedBack/
- byron@ougsoft.com -> hi@got-feedBack.org
- github.com/byrongamatos/ -> github.com/got-feedback/
- com.byron. -> com.got-feedback.
- SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback
- Protocol/storage strings migrated with read-old/write-new pattern
- window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias

Refs: #rename-slopsmith

* rename: complete regen against current main + fix backward-compat alias

Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of
current main (3 commits had landed since the branch: #572/#554/#574),
resolving the four content conflicts in favour of main's newer content
(autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge).

Completion fixes on top of the mechanical rename:
- Re-apply rename to post-branch content the original rename never saw:
  window.slopsmith(.Tour) consumers in lessons.js / notifications.js /
  onboarding-tour.js, and the matching JS + python tests (autoplay_exit,
  progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env
  vars now match server.py (which reads FEEDBACK_SYNC_STARTUP /
  FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real
  path again.
- Restore the window.slopsmith backward-compat alias dropped during conflict
  resolution, and move the bus aliases to AFTER the _feedBackExisting merge
  block so they reference the fully-assembled object (also fixes the
  loop_api.test.js API-surface regex, which the original PR latently broke).
- Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR)
  and gitignore it.
- Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped
  source labels.

Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669
passed / 1683 collected with 0 import errors; zero residual slopsmith/byron
except the two intentional window.slopsmith aliases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* rename: implement advertised backward-compat + prune dead community plugins

Address gaps where PR #537's "Backward compatibility" section was advertised
but not implemented, and clean up the community plugin list.

Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured):
- New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py
  (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and
  tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI /
  SLOPSMITH_PLUGINS_DIR / etc. deployments keep working.
- Fix the rename collapsing plugins/__init__.py and minigames/routes.py from
  `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant
  `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost).

Storage (app.js update-channel):
- Read feedBack-update-channel, fall back to legacy slopsmith-update-channel,
  and clear the legacy key on write — so a user's update-channel preference
  survives the rename instead of resetting to "stable".

Community plugin list (README): the rename rewrote third-party repo URLs we
don't own. Probed every one; their owners never renamed, so:
- Restore the 13 live community plugins to their real slopsmith-* names.
- Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex
  tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle).
- Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory).

Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors,
rename-sensitive + startup suites green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

tests/browser/README.md

@@ -1,10 +1,10 @@
 # Browser Tests
 
-This directory contains Playwright browser tests for Slopsmith keyboard shortcuts.
+This directory contains Playwright browser tests for FeedBack keyboard shortcuts.
 
 ## Prerequisites
 
-1. **Slopsmith web server**: Tests need the server reachable at `http://localhost:8000`.
+1. **FeedBack web server**: Tests need the server reachable at `http://localhost:8000`.
    Playwright auto-starts it via `webServer.command` in `playwright.config.ts`, so manual
    startup is optional. Start it manually if you want to debug the server, run tests
    outside Playwright, or skip the per-run boot delay:
@@ -92,7 +92,7 @@ Increase timeout in `playwright.config.ts` if needed.
 ### LIBRARY_PATH not set
 Make sure to set the LIBRARY_PATH environment variable:
 ```bash
-LIBRARY_PATH=~/slopsmith-library docker compose up -d
+LIBRARY_PATH=~/feedBack-library docker compose up -d
 ```
 
 ## CI/CD

tests/browser/audio-session-compat.spec.ts

@@ -7,7 +7,7 @@ test('legacy audio fader and analyser bridges stay visible in browser diagnostic
   const result = await page.evaluate(() => {
     const appWindow = window as any;
     let faderValue = 1;
-    appWindow.slopsmith.audio.registerFader({
+    appWindow.feedBack.audio.registerFader({
       id: 'browser-smoke',
       label: 'Browser Smoke',
       min: 0,
@@ -17,14 +17,14 @@ test('legacy audio fader and analyser bridges stay visible in browser diagnostic
       getValue: () => faderValue,
       setValue: (value: number) => { faderValue = value; },
     });
-    appWindow.slopsmith.audioSession.recordBridgeHit({
+    appWindow.feedBack.audioSession.recordBridgeHit({
       domain: 'audio-mix',
       bridgeId: 'audio-mix.analyser',
       legacySurface: 'browser smoke analyser',
       participantId: 'highway_3d',
     });
-    const snapshot = appWindow.slopsmith.audioSession.snapshot();
-    const diagnostics = appWindow.slopsmith.capabilities.snapshotDiagnostics();
+    const snapshot = appWindow.feedBack.audioSession.snapshot();
+    const diagnostics = appWindow.feedBack.capabilities.snapshotDiagnostics();
     return {
       hasFader: snapshot.domains['audio-mix'].participants.some((entry: any) => entry.participantId === 'fader.browser-smoke'),
       hasAnalyserBridge: snapshot.domains['audio-mix'].bridges.some((entry: any) => entry.bridgeId === 'audio-mix.analyser'),

tests/browser/audio-session.spec.ts

@@ -6,13 +6,13 @@ test('audio session runtime is available on page load', async ({ page }) => {
 
   const snapshot = await page.evaluate(() => {
     const appWindow = window as any;
-    if (!appWindow.slopsmith?.audioSession?.snapshot) {
+    if (!appWindow.feedBack?.audioSession?.snapshot) {
       throw new Error('audioSession host not available');
     }
-    return appWindow.slopsmith.audioSession.snapshot();
+    return appWindow.feedBack.audioSession.snapshot();
   });
 
-  expect(snapshot.schema).toBe('slopsmith.audio_session.diagnostics.v1');
+  expect(snapshot.schema).toBe('feedBack.audio_session.diagnostics.v1');
   expect(snapshot.domains['audio-mix']).toBeTruthy();
   expect(snapshot.domains['audio-input']).toBeTruthy();
   expect(snapshot.domains['audio-monitoring']).toBeTruthy();

tests/browser/basic-load.spec.ts

@@ -6,7 +6,7 @@ test('app loads', async ({ page }) => {
   
   // Check if the page loaded
   const title = await page.title();
-  expect(title).toBe('Slopsmith');
+  expect(title).toBe('FeedBack');
 });
 
 test('check if window has any shortcuts', async ({ page }) => {

tests/browser/check-errors.spec.ts

@@ -37,11 +37,11 @@ test('audio mixer opens with audio-mix command-backed controls', async ({ page }
   await page.goto('/');
   await page.waitForSelector('#btn-mixer', { state: 'attached', timeout: 10000 });
 
-  await page.evaluate(() => window.slopsmith?.audio?.openMixer?.());
+  await page.evaluate(() => window.feedBack?.audio?.openMixer?.());
   await expect(page.locator('#mixer-popover')).not.toHaveClass(/hidden/);
 
   const faderState = await page.evaluate(async () => {
-    const api = window.slopsmith?.capabilities;
+    const api = window.feedBack?.capabilities;
     if (!api?.command) return { outcome: 'no-owner' };
     const result = await api.command('audio-mix', 'list-faders', { requester: 'browser-smoke' });
     return { outcome: result.outcome, count: result.payload?.faders?.length || 0 };

tests/browser/default-arrangement-pin.spec.ts

@@ -69,14 +69,14 @@ test('player arrangement pin saves the selected arrangement name', async ({ page
       .join('');
     select.value = '2';
     // @ts-ignore - browser app namespace
-    window.slopsmith.currentSong = {
+    window.feedBack.currentSong = {
       filename: 'demo.archive',
       arrangement: 'Rhythm',
       arrangementIndex: 2,
       arrangements,
     };
     // @ts-ignore - browser app namespace
-    window.slopsmith.emit('song:loaded', window.slopsmith.currentSong);
+    window.feedBack.emit('song:loaded', window.feedBack.currentSong);
   });
 
   const pin = page.locator('#arr-default-pin');
@@ -137,14 +137,14 @@ test('player arrangement pin preserves non-built-in arrangement names', async ({
       .join('');
     select.value = '2';
     // @ts-ignore - browser app namespace
-    window.slopsmith.currentSong = {
+    window.feedBack.currentSong = {
       filename: 'demo.archive',
       arrangement: 'Rhythm',
       arrangementIndex: 2,
       arrangements,
     };
     // @ts-ignore - browser app namespace
-    window.slopsmith.emit('song:loaded', window.slopsmith.currentSong);
+    window.feedBack.emit('song:loaded', window.feedBack.currentSong);
   });
 
   await page.locator('#arr-default-pin').click();
@@ -191,14 +191,14 @@ test('failed settings save does not mark arrangement default as persisted', asyn
       .join('');
     select.value = '2';
     // @ts-ignore - browser app namespace
-    window.slopsmith.currentSong = {
+    window.feedBack.currentSong = {
       filename: 'demo.archive',
       arrangement: 'Rhythm',
       arrangementIndex: 2,
       arrangements,
     };
     // @ts-ignore - browser app namespace
-    window.slopsmith.emit('song:loaded', window.slopsmith.currentSong);
+    window.feedBack.emit('song:loaded', window.feedBack.currentSong);
   });
 
   const pin = page.locator('#arr-default-pin');

tests/browser/highway-3d-lefty.spec.ts

@@ -92,7 +92,7 @@ test('left-handed setting reaches the 3D Highway renderer with a mocked song str
   await expect(page.locator('#viz-picker')).toHaveValue('highway_3d');
   await page.evaluate(() => {
     (window as any).__h3dReadySeen = false;
-    (window as any).slopsmith.on('viz:renderer:ready', () => {
+    (window as any).feedBack.on('viz:renderer:ready', () => {
       (window as any).__h3dReadySeen = true;
     }, { once: true });
   });

tests/browser/progress-shop.spec.ts

@@ -39,17 +39,17 @@ test('progression capability domain is owned by core', async ({ page }) => {
 
   const result = await page.evaluate(async () => {
     const appWindow = window as any;
-    const inspectCmd = await appWindow.slopsmith.capabilities.command('progression', 'inspect', {
+    const inspectCmd = await appWindow.feedBack.capabilities.command('progression', 'inspect', {
       requester: 'browser-smoke',
     });
-    const pipeline = appWindow.slopsmith.capabilities.inspect('progression');
+    const pipeline = appWindow.feedBack.capabilities.inspect('progression');
     const owner = (pipeline.participants || []).find((p: any) => p.pluginId === 'core.progression');
     return {
       outcome: inspectCmd.outcome,
       masteryRank: inspectCmd.payload ? inspectCmd.payload.mastery_rank : null,
       ownerRoles: owner ? owner.roles : [],
       // buy-item without user-action authorization must be denied.
-      deniedBuy: (await appWindow.slopsmith.capabilities.command('progression', 'buy-item', {
+      deniedBuy: (await appWindow.feedBack.capabilities.command('progression', 'buy-item', {
         requester: 'browser-smoke',
         payload: { item_id: 'theme.sunset-strat' },
       })).outcome,

tests/browser/wake-lock.spec.ts

@@ -51,7 +51,7 @@ test.beforeEach(async ({ page }) => {
   await page.addInitScript(installWakeLockSpy);
   await page.goto('/');
   await page.waitForSelector('.screen.active', { timeout: 10000 });
-  await page.waitForFunction(() => typeof (window as any).slopsmith?.emit === 'function');
+  await page.waitForFunction(() => typeof (window as any).feedBack?.emit === 'function');
 });
 
 test('acquires a single screen wake lock on play and releases on pause', async ({ page }) => {
@@ -59,26 +59,26 @@ test('acquires a single screen wake lock on play and releases on pause', async (
   // only one 'screen' lock should be requested (the in-flight guard must hold
   // before the first request resolves).
   await page.evaluate(() => {
-    (window as any).slopsmith.emit('song:play');
-    (window as any).slopsmith.emit('song:resume');
+    (window as any).feedBack.emit('song:play');
+    (window as any).feedBack.emit('song:resume');
   });
   await page.waitForFunction(() => (window as any).__wakeLockSpy.held === true);
   expect(await page.evaluate(() => (window as any).__wakeLockSpy.requestCount)).toBe(1);
   expect(await page.evaluate(() => (window as any).__wakeLockSpy.lastType)).toBe('screen');
 
-  await page.evaluate(() => (window as any).slopsmith.emit('song:pause'));
+  await page.evaluate(() => (window as any).feedBack.emit('song:pause'));
   await page.waitForFunction(() => (window as any).__wakeLockSpy.held === false);
 });
 
 test('song:ended and song:stop release the wake lock', async ({ page }) => {
-  await page.evaluate(() => (window as any).slopsmith.emit('song:play'));
+  await page.evaluate(() => (window as any).feedBack.emit('song:play'));
   await page.waitForFunction(() => (window as any).__wakeLockSpy.held === true);
-  await page.evaluate(() => (window as any).slopsmith.emit('song:ended'));
+  await page.evaluate(() => (window as any).feedBack.emit('song:ended'));
   await page.waitForFunction(() => (window as any).__wakeLockSpy.held === false);
 
-  await page.evaluate(() => (window as any).slopsmith.emit('song:play'));
+  await page.evaluate(() => (window as any).feedBack.emit('song:play'));
   await page.waitForFunction(() => (window as any).__wakeLockSpy.held === true);
-  await page.evaluate(() => (window as any).slopsmith.emit('song:stop'));
+  await page.evaluate(() => (window as any).feedBack.emit('song:stop'));
   await page.waitForFunction(() => (window as any).__wakeLockSpy.held === false);
 });
 
@@ -87,8 +87,8 @@ test('fast play→pause before the request resolves leaves no stale lock', async
   // Pause arrives while navigator.wakeLock.request is still in flight — the
   // resolved sentinel must release itself instead of being held stale.
   await page.evaluate(() => {
-    (window as any).slopsmith.emit('song:play');
-    (window as any).slopsmith.emit('song:pause');
+    (window as any).feedBack.emit('song:play');
+    (window as any).feedBack.emit('song:pause');
   });
   await page.waitForTimeout(150);
   expect(await page.evaluate(() => (window as any).__wakeLockSpy.held)).toBe(false);
@@ -97,53 +97,53 @@ test('fast play→pause before the request resolves leaves no stale lock', async
 });
 
 test('re-acquires the wake lock when the UA releases it while still playing', async ({ page }) => {
-  await page.evaluate(() => (window as any).slopsmith.emit('song:play'));
+  await page.evaluate(() => (window as any).feedBack.emit('song:play'));
   await page.waitForFunction(() => (window as any).__wakeLockSpy.held === true);
   const before = await page.evaluate(() => (window as any).__wakeLockSpy.requestCount);
 
   // Simulate the UA releasing the lock (power policy / page hide) while
   // playback continues; the release handler re-acquires when still visible.
   await page.evaluate(() => {
-    (window as any).slopsmith.isPlaying = true;
+    (window as any).feedBack.isPlaying = true;
     (window as any).__wakeLockSpy.lastSentinel.release();
   });
   await page.waitForFunction((n) => (window as any).__wakeLockSpy.requestCount === n + 1 && (window as any).__wakeLockSpy.held === true, before);
 
   // After a real pause there must be no further re-acquire churn.
-  await page.evaluate(() => (window as any).slopsmith.emit('song:pause'));
+  await page.evaluate(() => (window as any).feedBack.emit('song:pause'));
   await page.waitForFunction(() => (window as any).__wakeLockSpy.held === false);
   const settled = await page.evaluate(() => (window as any).__wakeLockSpy.requestCount);
   await page.waitForTimeout(150);
   expect(await page.evaluate(() => (window as any).__wakeLockSpy.requestCount)).toBe(settled);
 });
 
-test('drives the slopsmith-desktop native power bridge, deduped and visibility-gated', async ({ page }) => {
+test('drives the feedBack-desktop native power bridge, deduped and visibility-gated', async ({ page }) => {
   // In the packaged Electron app navigator.wakeLock is unreliable, so the
-  // helper also drives window.slopsmithDesktop.power.setScreenAwake — to
+  // helper also drives window.feedBackDesktop.power.setScreenAwake — to
   // exactly (wanted && visible), emitting only on change. Inject a spy bridge
   // before app.js runs and assert it tracks playback without duplicate starts.
   await page.addInitScript(() => {
     (window as any).__bridgeCalls = [];
-    (window as any).slopsmithDesktop = {
+    (window as any).feedBackDesktop = {
       power: { setScreenAwake: (keep: boolean) => (window as any).__bridgeCalls.push(keep) },
     };
   });
   await page.reload();
   await page.waitForSelector('.screen.active', { timeout: 10000 });
-  await page.waitForFunction(() => typeof (window as any).slopsmith?.emit === 'function');
+  await page.waitForFunction(() => typeof (window as any).feedBack?.emit === 'function');
 
   // song:play + song:resume fire together but must produce a single `true`.
   await page.evaluate(() => {
-    (window as any).slopsmith.emit('song:play');
-    (window as any).slopsmith.emit('song:resume');
+    (window as any).feedBack.emit('song:play');
+    (window as any).feedBack.emit('song:resume');
   });
   await page.waitForFunction(() => (window as any).__bridgeCalls.filter((x: boolean) => x === true).length === 1);
-  await page.evaluate(() => (window as any).slopsmith.emit('song:pause'));
+  await page.evaluate(() => (window as any).feedBack.emit('song:pause'));
   await page.waitForFunction(() => (window as any).__bridgeCalls.filter((x: boolean) => x === false).length === 1);
 
   // Hidden while playing → bridge OFF (a minimized window mustn't keep the
   // whole display awake); restoring visibility while playing turns it back ON.
-  await page.evaluate(() => (window as any).slopsmith.emit('song:play'));
+  await page.evaluate(() => (window as any).feedBack.emit('song:play'));
   await page.waitForFunction(() => (window as any).__bridgeCalls[(window as any).__bridgeCalls.length - 1] === true);
   await page.evaluate(() => {
     Object.defineProperty(document, 'visibilityState', { configurable: true, get: () => 'hidden' });