mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 03:09:57 +00:00
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
co-authored by
Claude Opus 4.8
byrongamatos
Claude Opus 4.8
byrongamatos
parent
a8ad02739a
commit
af2949677a
+18
-18
@@ -1,4 +1,4 @@
|
||||
// Slopsmith capability registry and dispatcher.
|
||||
// FeedBack capability registry and dispatcher.
|
||||
(function () {
|
||||
'use strict';
|
||||
|
||||
@@ -30,8 +30,8 @@
|
||||
};
|
||||
}
|
||||
|
||||
function _ensureSlopsmithEventBus() {
|
||||
const existing = window.slopsmith && typeof window.slopsmith === 'object' ? window.slopsmith : null;
|
||||
function _ensureFeedBackEventBus() {
|
||||
const existing = window.feedBack && typeof window.feedBack === 'object' ? window.feedBack : null;
|
||||
const hasEventTarget = existing
|
||||
&& typeof existing.addEventListener === 'function'
|
||||
&& typeof existing.removeEventListener === 'function'
|
||||
@@ -53,12 +53,12 @@
|
||||
bus.off = function (event, fn, options) {
|
||||
this.removeEventListener(event, fn, options);
|
||||
};
|
||||
window.slopsmith = bus;
|
||||
window.feedBack = bus;
|
||||
return bus;
|
||||
}
|
||||
|
||||
_ensureSlopsmithEventBus();
|
||||
if (window.slopsmith.capabilities && window.slopsmith.capabilities.version === 1) return;
|
||||
_ensureFeedBackEventBus();
|
||||
if (window.feedBack.capabilities && window.feedBack.capabilities.version === 1) return;
|
||||
|
||||
const VALID_ROLES = new Set([
|
||||
'owner', 'coordinator', 'provider', 'executor', 'observer', 'requester', 'transformer', 'handler',
|
||||
@@ -209,7 +209,7 @@
|
||||
|
||||
const VALID_SETTING_TYPES = new Set(['toggle', 'range', 'select']);
|
||||
|
||||
// Normalize per-instance control descriptors (slopsmith#849) declared on a
|
||||
// Normalize per-instance control descriptors (feedBack#849) declared on a
|
||||
// capability. Lenient (drops malformed entries rather than failing the whole
|
||||
// declaration): the server-side validator in plugins/__init__.py already
|
||||
// strict-checks the /api/plugins manifest path; this keeps runtime
|
||||
@@ -661,7 +661,7 @@
|
||||
lifecycle: 'plugin-defined',
|
||||
label: 'Plugin-defined',
|
||||
tone: 'info',
|
||||
summary: 'Declared by a plugin or test fixture rather than registered as a core Slopsmith domain.',
|
||||
summary: 'Declared by a plugin or test fixture rather than registered as a core FeedBack domain.',
|
||||
};
|
||||
}
|
||||
|
||||
@@ -863,12 +863,12 @@
|
||||
_notifySubscribers(event, detail);
|
||||
_notifySubscribers(`${capabilityName}:${event}`, detail);
|
||||
try {
|
||||
if (window.slopsmith && typeof window.slopsmith.emit === 'function') {
|
||||
window.slopsmith.emit(`${capabilityName}:${event}`, detail);
|
||||
window.slopsmith.emit('capability:event', detail);
|
||||
if (window.feedBack && typeof window.feedBack.emit === 'function') {
|
||||
window.feedBack.emit(`${capabilityName}:${event}`, detail);
|
||||
window.feedBack.emit('capability:event', detail);
|
||||
} else {
|
||||
window.dispatchEvent(new CustomEvent(`${capabilityName}:${event}`, { detail }));
|
||||
window.dispatchEvent(new CustomEvent('slopsmith:capability:event', { detail }));
|
||||
window.dispatchEvent(new CustomEvent('feedBack:capability:event', { detail }));
|
||||
}
|
||||
} catch (err) {
|
||||
console.warn('[capabilities] event dispatch failed:', err);
|
||||
@@ -1238,7 +1238,7 @@
|
||||
if (!source || typeof source !== 'object') return 'legacy-runtime';
|
||||
const candidate = source.source || source.pluginId || source.owner || source.requester || source.providerId || source.id;
|
||||
if (candidate) return String(candidate);
|
||||
const activePluginId = window.slopsmith && (window.slopsmith._loadingPluginId || window.slopsmith._activePluginId);
|
||||
const activePluginId = window.feedBack && (window.feedBack._loadingPluginId || window.feedBack._activePluginId);
|
||||
return activePluginId ? String(activePluginId) : 'legacy-runtime';
|
||||
}
|
||||
|
||||
@@ -1413,7 +1413,7 @@
|
||||
function snapshotDiagnostics() {
|
||||
const pipelineSummaries = inspect();
|
||||
const snapshot = {
|
||||
schema: 'slopsmith.capabilities.diagnostics.v1',
|
||||
schema: 'feedBack.capabilities.diagnostics.v1',
|
||||
pipelines: pipelineSummaries,
|
||||
participants: pipelineSummaries.flatMap(pipeline => Array.isArray(pipeline.participants) ? pipeline.participants : []),
|
||||
recentDecisions: recentDecisions.slice(),
|
||||
@@ -1447,14 +1447,14 @@
|
||||
capabilitiesChangeScheduled = false;
|
||||
const detail = { timestamp: _now() };
|
||||
try {
|
||||
window.dispatchEvent(new CustomEvent('slopsmith:capabilities:changed', { detail }));
|
||||
window.dispatchEvent(new CustomEvent('feedBack:capabilities:changed', { detail }));
|
||||
} catch (_err) { /* capability diagnostics must not break runtime behavior */ }
|
||||
});
|
||||
}
|
||||
|
||||
function _contributeDiagnostics() {
|
||||
if (contributing) return;
|
||||
const diagnostics = window.slopsmith && window.slopsmith.diagnostics;
|
||||
const diagnostics = window.feedBack && window.feedBack.diagnostics;
|
||||
if (diagnostics && typeof diagnostics.contribute === 'function') {
|
||||
contributing = true;
|
||||
try { diagnostics.contribute('capabilities', snapshotDiagnostics()); }
|
||||
@@ -1494,7 +1494,7 @@
|
||||
recordUserOverride,
|
||||
};
|
||||
|
||||
window.slopsmith.capabilities = api;
|
||||
window.feedBack.capabilities = api;
|
||||
|
||||
registerParticipant('core', {
|
||||
diagnostics: {
|
||||
@@ -1533,7 +1533,7 @@
|
||||
},
|
||||
});
|
||||
try {
|
||||
window.dispatchEvent(new CustomEvent('slopsmith:capabilities:ready', { detail: api }));
|
||||
window.dispatchEvent(new CustomEvent('feedBack:capabilities:ready', { detail: api }));
|
||||
_notifySubscribers('registered', { capability: '*', pluginId: 'core', timestamp: _now() });
|
||||
} catch (_) {}
|
||||
})();
|
||||
Reference in New Issue
Block a user