mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-15 13:17:25 +00:00
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
co-authored by
Claude Opus 4.8
byrongamatos
Claude Opus 4.8
byrongamatos
parent
a8ad02739a
commit
af2949677a
+19
-19
@@ -1,6 +1,6 @@
|
||||
// Audio mixer — registry + popover for per-channel volume control (slopsmith#87).
|
||||
// Audio mixer — registry + popover for per-channel volume control (feedBack#87).
|
||||
//
|
||||
// Plugins (or core) register a fader spec via window.slopsmith.audio.registerFader(spec).
|
||||
// Plugins (or core) register a fader spec via window.feedBack.audio.registerFader(spec).
|
||||
// Each spec is the source of truth for its own value: the popover only calls
|
||||
// getValue() to render and setValue() to commit. Persistence is the plugin's
|
||||
// responsibility — the registry doesn't store values.
|
||||
@@ -10,8 +10,8 @@
|
||||
(function () {
|
||||
'use strict';
|
||||
|
||||
if (!window.slopsmith) {
|
||||
console.warn('[mixer] window.slopsmith missing — audio-mixer.js loaded too early');
|
||||
if (!window.feedBack) {
|
||||
console.warn('[mixer] window.feedBack missing — audio-mixer.js loaded too early');
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -24,11 +24,11 @@ let _openTimer = null;
|
||||
function _audioEl() { return document.getElementById('audio'); }
|
||||
|
||||
function _audioSession() {
|
||||
return window.slopsmith && window.slopsmith.audioSession;
|
||||
return window.feedBack && window.feedBack.audioSession;
|
||||
}
|
||||
|
||||
function _capabilities() {
|
||||
return window.slopsmith && window.slopsmith.capabilities;
|
||||
return window.feedBack && window.feedBack.capabilities;
|
||||
}
|
||||
|
||||
async function _mixCommand(command, payload) {
|
||||
@@ -143,7 +143,7 @@ function _applySongVolume(v) {
|
||||
// routes every stem through its own master GainNode, so a.volume above is
|
||||
// dead. Drive that master instead when the stems plugin has published its
|
||||
// hook (it clears the hook on teardown for stem-less songs).
|
||||
const stemsSetMaster = window.slopsmith?.stems?.setMasterVolume;
|
||||
const stemsSetMaster = window.feedBack?.stems?.setMasterVolume;
|
||||
if (typeof stemsSetMaster === 'function') {
|
||||
// A synchronous throw or a rejected Promise from the stems plugin hook
|
||||
// must not abort _applySongVolume before it returns / persists. The
|
||||
@@ -155,13 +155,13 @@ function _applySongVolume(v) {
|
||||
// consistent with the other ignored async calls in this module.
|
||||
void Promise.resolve(stemsSetMaster(linear))
|
||||
.then(function () {
|
||||
_recordAudioBridge('stems.master-volume', 'window.slopsmith.stems.setMasterVolume', 'core.song', 'handled');
|
||||
_recordAudioBridge('stems.master-volume', 'window.feedBack.stems.setMasterVolume', 'core.song', 'handled');
|
||||
})
|
||||
.catch(function () {
|
||||
_recordAudioBridge('stems.master-volume', 'window.slopsmith.stems.setMasterVolume', 'core.song', 'failed', 'Stems master volume hook rejected');
|
||||
_recordAudioBridge('stems.master-volume', 'window.feedBack.stems.setMasterVolume', 'core.song', 'failed', 'Stems master volume hook rejected');
|
||||
});
|
||||
} catch (_) {
|
||||
_recordAudioBridge('stems.master-volume', 'window.slopsmith.stems.setMasterVolume', 'core.song', 'failed', 'Stems master volume hook threw');
|
||||
_recordAudioBridge('stems.master-volume', 'window.feedBack.stems.setMasterVolume', 'core.song', 'failed', 'Stems master volume hook threw');
|
||||
}
|
||||
}
|
||||
_registerAudioSessionFader({
|
||||
@@ -183,7 +183,7 @@ function _applySongVolume(v) {
|
||||
_recordAudioBridge('audio-mix.song-volume', 'applySongVolume', 'core.song', 'handled');
|
||||
// Desktop + JUCE: song audio is mixed in the native engine; HTML5 volume is ignored.
|
||||
if (window._juceMode) {
|
||||
const setGain = window.slopsmithDesktop?.audio?.setGain;
|
||||
const setGain = window.feedBackDesktop?.audio?.setGain;
|
||||
if (typeof setGain === 'function') {
|
||||
// Same dual guard as the stems hook above: the try/catch covers a
|
||||
// synchronous throw from setGain, the .catch() covers a rejected IPC.
|
||||
@@ -502,17 +502,17 @@ function _init() {
|
||||
_btnEl = document.getElementById('btn-mixer');
|
||||
_popoverEl = document.getElementById('mixer-popover');
|
||||
_registerSongFader();
|
||||
if (window.slopsmith && window.slopsmith.on) {
|
||||
window.slopsmith.on('screen:changed', _onScreenChanged);
|
||||
window.slopsmith.on('audio-mix:fader-value-changed', () => { if (_open) _renderPopover(); });
|
||||
window.slopsmith.on('audio-mix:fader-unavailable', () => { if (_open) _renderPopover(); });
|
||||
window.slopsmith.on('audio-mix:participant-registered', () => { if (_open) _renderPopover(); });
|
||||
window.slopsmith.on('audio-mix:participant-removed', () => { if (_open) _renderPopover(); });
|
||||
if (window.feedBack && window.feedBack.on) {
|
||||
window.feedBack.on('screen:changed', _onScreenChanged);
|
||||
window.feedBack.on('audio-mix:fader-value-changed', () => { if (_open) _renderPopover(); });
|
||||
window.feedBack.on('audio-mix:fader-unavailable', () => { if (_open) _renderPopover(); });
|
||||
window.feedBack.on('audio-mix:participant-registered', () => { if (_open) _renderPopover(); });
|
||||
window.feedBack.on('audio-mix:participant-removed', () => { if (_open) _renderPopover(); });
|
||||
}
|
||||
window.dispatchEvent(new Event('slopsmith:audio:ready'));
|
||||
window.dispatchEvent(new Event('feedBack:audio:ready'));
|
||||
}
|
||||
|
||||
window.slopsmith.audio = Object.assign(window.slopsmith.audio || {}, {
|
||||
window.feedBack.audio = Object.assign(window.feedBack.audio || {}, {
|
||||
registerFader, unregisterFader, getFaders,
|
||||
openMixer, closeMixer, toggleMixer,
|
||||
applySongVolume: _applySongVolume,
|
||||
|
||||
Reference in New Issue
Block a user