mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-10 18:59:56 +00:00
rename: slopsmith → feedBack, byron → got-feedBack (#537)
* Update GitHub repo references from feedback* to feedBack* * rename: slopsmith -> feedBack, byron -> got-feedBack Renames across the entire codebase: - slopsmith/Slopsmith/SLOPSMITH/SlopSmith -> feedBack/FeedBack/FEEDBACK/FeedBack - byron/Byron/Byrongamatos -> got-feedBack/got-feedBack/got-feedBack - /home/byron/ -> /opt/got-feedBack/ - byron@ougsoft.com -> hi@got-feedBack.org - github.com/byrongamatos/ -> github.com/got-feedback/ - com.byron. -> com.got-feedback. - SLOPSMITH_ env vars -> FEEDBACK_ with backward-compat fallback - Protocol/storage strings migrated with read-old/write-new pattern - window.slopsmith JS API -> window.feedBack (canonical) + backward-compat alias Refs: #rename-slopsmith * rename: complete regen against current main + fix backward-compat alias Regenerated the slopsmith->feedBack / byron->got-feedBack rename on top of current main (3 commits had landed since the branch: #572/#554/#574), resolving the four content conflicts in favour of main's newer content (autoplay/auto-exit, accuracy-badge, Virtuoso re-home, feedpak badge). Completion fixes on top of the mechanical rename: - Re-apply rename to post-branch content the original rename never saw: window.slopsmith(.Tour) consumers in lessons.js / notifications.js / onboarding-tour.js, and the matching JS + python tests (autoplay_exit, progression_*, test_feedpak_extension FEEDBACK_* env vars). The test env vars now match server.py (which reads FEEDBACK_SYNC_STARTUP / FEEDBACK_SKIP_STARTUP_TASKS), so the sync-startup test exercises the real path again. - Restore the window.slopsmith backward-compat alias dropped during conflict resolution, and move the bus aliases to AFTER the _feedBackExisting merge block so they reference the fully-assembled object (also fixes the loop_api.test.js API-surface regex, which the original PR latently broke). - Drop the stray empty data/web_library.db (runtime DB lives in CONFIG_DIR) and gitignore it. - Fix stale tone-source test: feed[dB]ack -> fee[dB]ack to match shipped source labels. Verified locally (org CI billing-blocked): JS 819/819 pass; pytest 1669 passed / 1683 collected with 0 import errors; zero residual slopsmith/byron except the two intentional window.slopsmith aliases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * rename: implement advertised backward-compat + prune dead community plugins Address gaps where PR #537's "Backward compatibility" section was advertised but not implemented, and clean up the community plugin list. Env vars (FEEDBACK_* canonical, legacy SLOPSMITH_* honoured): - New lib/env_compat.py (getenv_compat / env_flag_compat) + tests. server.py (_env_flag + all FEEDBACK_* reads), diagnostics_hardware, gp2midi and tailwind_rebuild now resolve the legacy alias, so existing SLOPSMITH_UI / SLOPSMITH_PLUGINS_DIR / etc. deployments keep working. - Fix the rename collapsing plugins/__init__.py and minigames/routes.py from `FEEDBACK_PLUGINS_DIR or SLOPSMITH_PLUGINS_DIR` into a redundant `FEEDBACK_ or FEEDBACK_` (the fallback was silently lost). Storage (app.js update-channel): - Read feedBack-update-channel, fall back to legacy slopsmith-update-channel, and clear the legacy key on write — so a user's update-channel preference survives the rename instead of resetting to "stable". Community plugin list (README): the rename rewrote third-party repo URLs we don't own. Probed every one; their owners never renamed, so: - Restore the 13 live community plugins to their real slopsmith-* names. - Prune 6 that are 404 to the public (topkoa splitscreen/stems, OmikronApex tuner, Jafz2001 nam-rig-builder, DeathlySin song-preview, Erikcb91 shuffle). - Fix a pre-existing Guitar Theory clone-command typo (nam-tone -> guitar-theory). Verified: env_compat 7/7, JS 819/819, pytest 1690 collected / 0 import errors, rename-sensitive + startup suites green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: byrongamatos <xasiklas@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bret Mogilefsky
co-authored by
Claude Opus 4.8
byrongamatos
Claude Opus 4.8
byrongamatos
parent
a8ad02739a
commit
af2949677a
+24
-24
@@ -130,7 +130,7 @@ ENV_ALLOWLIST = (
|
||||
"LOG_LEVEL",
|
||||
"LOG_FORMAT",
|
||||
"LOG_FILE",
|
||||
"SLOPSMITH_RUNTIME",
|
||||
"FEEDBACK_RUNTIME",
|
||||
"PORT",
|
||||
"HOST",
|
||||
"TZ",
|
||||
@@ -154,13 +154,13 @@ def _safe_json_dumps(obj) -> str:
|
||||
return json.dumps({"error": "unserializable payload"}, indent=2)
|
||||
|
||||
|
||||
def _system_version(slopsmith_version: str, redactor=None) -> dict:
|
||||
def _system_version(feedBack_version: str, redactor=None) -> dict:
|
||||
executable = sys.executable
|
||||
if redactor is not None:
|
||||
executable = redactor.redact_text(executable)
|
||||
return {
|
||||
"schema": "system.version.v1",
|
||||
"slopsmith_version": slopsmith_version,
|
||||
"feedBack_version": feedBack_version,
|
||||
"python": {
|
||||
"version": platform.python_version(),
|
||||
"implementation": platform.python_implementation(),
|
||||
@@ -233,7 +233,7 @@ def _summarize_payload(path: str, parsed) -> dict | None:
|
||||
py = parsed.get("python") or {}
|
||||
os_ = parsed.get("os") or {}
|
||||
return {
|
||||
"slopsmith": parsed.get("slopsmith_version"),
|
||||
"feedBack": parsed.get("feedBack_version"),
|
||||
"python": py.get("version"),
|
||||
"os": os_.get("system"),
|
||||
}
|
||||
@@ -338,7 +338,7 @@ def _git_info(plugin_dir: Path) -> dict | None:
|
||||
"""Return git short SHA + remote URL for a plugin checkout.
|
||||
|
||||
Pure-Python — reads `.git/HEAD` and `.git/config` directly so this
|
||||
works in containers without the `git` binary installed (slopsmith's
|
||||
works in containers without the `git` binary installed (feedBack's
|
||||
runtime image is minimal). Plugins are gitlinks (see CLAUDE.md);
|
||||
the SHA is the most reliable "what build is this" identifier.
|
||||
|
||||
@@ -393,7 +393,7 @@ def _system_plugins(loaded_plugins: list[dict], plugins_root: "Path | list[Path]
|
||||
show up in the bundle.
|
||||
|
||||
*plugins_root* accepts a single Path, a list of Paths (to cover both
|
||||
the built-in ``plugins/`` directory and ``SLOPSMITH_PLUGINS_DIR``), or
|
||||
the built-in ``plugins/`` directory and ``FEEDBACK_PLUGINS_DIR``), or
|
||||
None to skip orphan detection entirely.
|
||||
|
||||
Plugin directories not in ``LOADED_PLUGINS`` appear in ``orphans``.
|
||||
@@ -484,7 +484,7 @@ def _system_plugins(loaded_plugins: list[dict], plugins_root: "Path | list[Path]
|
||||
# plugin failed to load — common when requirements.txt installs
|
||||
# fail in a read-only container). Accepts a single Path, a list of
|
||||
# Paths (to cover both the built-in plugins/ dir and
|
||||
# SLOPSMITH_PLUGINS_DIR), or None.
|
||||
# FEEDBACK_PLUGINS_DIR), or None.
|
||||
orphans: list[dict] = []
|
||||
if plugins_root is not None:
|
||||
roots: list[Path] = plugins_root if isinstance(plugins_root, list) else [plugins_root]
|
||||
@@ -840,11 +840,11 @@ def _redact_value(value: object, redactor: "Redactor") -> object:
|
||||
|
||||
|
||||
README_TEMPLATE = """\
|
||||
Slopsmith Diagnostics Bundle
|
||||
FeedBack Diagnostics Bundle
|
||||
============================
|
||||
|
||||
Generated: {exported_at}
|
||||
Slopsmith: {slopsmith_version}
|
||||
FeedBack: {feedBack_version}
|
||||
Runtime: {runtime_kind}
|
||||
Redacted: {redacted}
|
||||
|
||||
@@ -1005,7 +1005,7 @@ def _build_files_meta(files: dict[str, bytes]) -> list[dict]:
|
||||
|
||||
def _assemble_files_and_notes(
|
||||
*,
|
||||
slopsmith_version: str,
|
||||
feedBack_version: str,
|
||||
config_dir: Path,
|
||||
dlc_dir: Path | None,
|
||||
log_file: Path | None,
|
||||
@@ -1038,7 +1038,7 @@ def _assemble_files_and_notes(
|
||||
if include.get("system", True):
|
||||
# Pass the redactor so python.executable is redacted when paths
|
||||
# should be hidden (it often lives under $HOME or a per-user venv).
|
||||
ver_payload = _safe_json_dumps(_system_version(slopsmith_version, redactor=redactor)).encode("utf-8")
|
||||
ver_payload = _safe_json_dumps(_system_version(feedBack_version, redactor=redactor)).encode("utf-8")
|
||||
files["system/version.json"] = ver_payload
|
||||
env_payload = _safe_json_dumps(_system_env(redactor=redactor)).encode("utf-8")
|
||||
files["system/env.json"] = env_payload
|
||||
@@ -1125,7 +1125,7 @@ def _assemble_files_and_notes(
|
||||
files.update(plugin_files)
|
||||
|
||||
# Per-plugin client-side contributions from
|
||||
# window.slopsmith.diagnostics.contribute(plugin_id, payload).
|
||||
# window.feedBack.diagnostics.contribute(plugin_id, payload).
|
||||
# Gated on the same "plugins" toggle as backend plugin diagnostics.
|
||||
if include.get("plugins", True) and client_contributions and isinstance(client_contributions, dict):
|
||||
# Build the set of actually-loaded plugin IDs so we only accept
|
||||
@@ -1160,7 +1160,7 @@ def _assemble_files_and_notes(
|
||||
|
||||
def _make_manifest(
|
||||
*,
|
||||
slopsmith_version: str,
|
||||
feedBack_version: str,
|
||||
runtime_kind: str,
|
||||
redact: bool,
|
||||
files: dict[str, bytes],
|
||||
@@ -1170,7 +1170,7 @@ def _make_manifest(
|
||||
return {
|
||||
"schema": BUNDLE_SCHEMA,
|
||||
"exported_at": _now_iso(),
|
||||
"slopsmith_version": slopsmith_version,
|
||||
"feedBack_version": feedBack_version,
|
||||
"runtime": runtime_kind,
|
||||
"redacted": redact,
|
||||
"files": _build_files_meta(files),
|
||||
@@ -1181,7 +1181,7 @@ def _make_manifest(
|
||||
|
||||
def build_bundle(
|
||||
*,
|
||||
slopsmith_version: str,
|
||||
feedBack_version: str,
|
||||
config_dir: Path,
|
||||
dlc_dir: Path | None,
|
||||
log_file: Path | None,
|
||||
@@ -1198,7 +1198,7 @@ def build_bundle(
|
||||
) -> tuple[bytes, str, dict]:
|
||||
"""Returns (zip_bytes, filename, manifest_dict)."""
|
||||
files, notes, runtime_kind, redactor = _assemble_files_and_notes(
|
||||
slopsmith_version=slopsmith_version,
|
||||
feedBack_version=feedBack_version,
|
||||
config_dir=config_dir,
|
||||
dlc_dir=dlc_dir,
|
||||
log_file=log_file,
|
||||
@@ -1215,7 +1215,7 @@ def build_bundle(
|
||||
)
|
||||
|
||||
manifest = _make_manifest(
|
||||
slopsmith_version=slopsmith_version,
|
||||
feedBack_version=feedBack_version,
|
||||
runtime_kind=runtime_kind,
|
||||
redact=redact,
|
||||
files=files,
|
||||
@@ -1225,7 +1225,7 @@ def build_bundle(
|
||||
|
||||
readme = README_TEMPLATE.format(
|
||||
exported_at=manifest["exported_at"],
|
||||
slopsmith_version=slopsmith_version,
|
||||
feedBack_version=feedBack_version,
|
||||
runtime_kind=runtime_kind,
|
||||
redacted=redact,
|
||||
)
|
||||
@@ -1259,13 +1259,13 @@ def build_bundle(
|
||||
for path, payload in sorted(files.items()):
|
||||
zf.writestr(path, payload)
|
||||
|
||||
filename = f"slopsmith-diag-{slopsmith_version}-{_now_filename_slug()}.zip"
|
||||
filename = f"feedBack-diag-{feedBack_version}-{_now_filename_slug()}.zip"
|
||||
return buf.getvalue(), filename, manifest
|
||||
|
||||
|
||||
def preview_bundle(
|
||||
*,
|
||||
slopsmith_version: str,
|
||||
feedBack_version: str,
|
||||
config_dir: Path,
|
||||
dlc_dir: Path | None,
|
||||
log_file: Path | None,
|
||||
@@ -1303,7 +1303,7 @@ def preview_bundle(
|
||||
for p in loaded_plugins
|
||||
]
|
||||
files, notes, runtime_kind, redactor = _assemble_files_and_notes(
|
||||
slopsmith_version=slopsmith_version,
|
||||
feedBack_version=feedBack_version,
|
||||
config_dir=config_dir,
|
||||
dlc_dir=dlc_dir,
|
||||
log_file=log_file,
|
||||
@@ -1336,7 +1336,7 @@ def preview_bundle(
|
||||
if key not in files:
|
||||
files[key] = _CALLABLE_PREVIEW_PLACEHOLDER
|
||||
# Frontend plugins (those with a screen or script) may call
|
||||
# window.slopsmith.diagnostics.contribute() and produce a
|
||||
# window.feedBack.diagnostics.contribute() and produce a
|
||||
# plugins/<id>/client.json in the real export. Advertise a
|
||||
# placeholder so the preview file tree is accurate.
|
||||
if p.get("has_screen") or p.get("has_script"):
|
||||
@@ -1377,14 +1377,14 @@ def preview_bundle(
|
||||
}).encode("utf-8")
|
||||
|
||||
manifest = _make_manifest(
|
||||
slopsmith_version=slopsmith_version,
|
||||
feedBack_version=feedBack_version,
|
||||
runtime_kind=runtime_kind,
|
||||
redact=redact,
|
||||
files=files,
|
||||
notes=notes,
|
||||
redactor=redactor,
|
||||
)
|
||||
filename = f"slopsmith-diag-{slopsmith_version}-{_now_filename_slug()}.zip"
|
||||
filename = f"feedBack-diag-{feedBack_version}-{_now_filename_slug()}.zip"
|
||||
return {
|
||||
"filename": filename,
|
||||
"manifest": manifest,
|
||||
|
||||
Reference in New Issue
Block a user