got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-08-13 20:21:40 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(v3): replace broken window.prompt() in Playlists with in-app uiPrompt modal (#614)

Browse Source 
window.prompt() is a silent no-op in the Electron desktop shell, so the
Playlists "New Playlist" and "Rename" buttons and the library's bulk
"add selected songs to a playlist" action did nothing. Route all three
through the existing window.uiPrompt() modal (resolves to the string, or
null on cancel; the handlers were already async). window.confirm() works
in Electron and is left as-is.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Byron Gamatos
2026-06-27 20:35:30 +02:00
committed by GitHub
co-authored by Claude Opus 4.8
parent 4480ac2732
commit a57d0e3f85
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
static/v3/songs.js
+7 -2
View File
@@ -595,8 +595,13 @@
async function batchAddToPlaylist() {
const lists = (await jget('/api/playlists')) || [];
const choices = lists.filter((p) => !p.system_key);
const labels = choices.map((p, i) => (i + 1) + '. ' + p.name).join('\n');
const ans = (window.prompt('Add ' + state.selected.size + ' song(s) to which playlist?\n' + labels + '\n\nEnter a number, or a new playlist name:', '') || '').trim();
const labels = choices.map((p, i) => (i + 1) + '. ' + p.name).join(' ');
const ans = ((await window.uiPrompt({
title: 'Add ' + state.selected.size + ' song(s) to a playlist',
label: (labels ? labels + ' ' : '') + 'Type a number above, or a new playlist name:',
okLabel: 'Add',
placeholder: 'Number or new playlist name',
})) || '').trim();
if (!ans) return;
let pid = null;
const num = parseInt(ans, 10);