got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-08-10 18:59:56 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(profile): wire "Your best scores" panel to real song stats (#549) (#550)

Browse Source 
The profile card's "Your best scores" panel was a hardcoded placeholder
(`#v3-profile-bests` was never filled), so it always read "Play a song to
start tracking..." regardless of how many songs had been scored. The
backend already records best_score/best_accuracy per song; only this
panel was left unwired.

- server.py: add MetadataDB.top_stats(limit) (per-song aggregate, best
  score first, scored songs only, dead songs skipped) + /api/stats/top
  route that enriches rows with title/artist/art, mirroring
  /api/stats/recent. Declared before the /api/stats/{filename} catch-all.
- static/v3/profile.js: renderBests() fetches /api/stats/top and fills the
  panel (rank, title/artist, best accuracy %, score; click to play),
  keeping the placeholder only when nothing's been scored.
- tests: cover ordering, per-song aggregation, limit, and
  resume-only/dead-song exclusion.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Byron Gamatos
2026-06-21 20:55:02 +02:00
committed by GitHub
co-authored by Claude Opus 4.8
parent 9f35fedeef
commit a0867f8bfd
3 changed files with 116 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_song_stats_api.py
+34
View File
@@ -104,6 +104,40 @@ def test_recent_orders_by_last_played(client, server):
assert "art_url" in recent[0] and "title" in recent[0]
def test_top_orders_by_best_score_and_enriches(client, server):
# The profile "Your best scores" panel: top songs by best score, descending,
# joined to metadata. A worse-scored and a resume-only song must rank below /
# be excluded respectively.
server.meta_db.put("low.archive", 0, 0, {"title": "Low", "artist": "A"})
server.meta_db.put("high.archive", 0, 0, {"title": "High", "artist": "B"})
server.meta_db.put("resume.archive", 0, 0, {"title": "Resume"})
client.post("/api/stats", json={"filename": "low.archive", "score": 100, "accuracy": 0.5})
client.post("/api/stats", json={"filename": "high.archive", "score": 900, "accuracy": 0.95})
client.post("/api/stats", json={"filename": "resume.archive", "lastPlayPosition": 12.0}) # plays==0
top = client.get("/api/stats/top").json()
names = [r["filename"] for r in top]
assert names[:2] == ["high.archive", "low.archive"] # best score first
assert "resume.archive" not in names # unscored excluded
assert top[0]["title"] == "High" and "art_url" in top[0]
assert top[0]["best_score"] == 900 and top[0]["best_accuracy"] == pytest.approx(0.95)
def test_top_aggregates_arrangements_and_respects_limit(client, server):
# Per-song aggregation (best across arrangements) + the limit param.
server.meta_db.put("multi.archive", 0, 0, {"title": "Multi",
"arrangements": [{"name": "Lead"}, {"name": "Bass"}]})
server.meta_db.put("solo.archive", 0, 0, {"title": "Solo"})
client.post("/api/stats", json={"filename": "multi.archive", "arrangement": 0, "score": 200, "accuracy": 0.6})
client.post("/api/stats", json={"filename": "multi.archive", "arrangement": 1, "score": 800, "accuracy": 0.9})
client.post("/api/stats", json={"filename": "solo.archive", "score": 500, "accuracy": 0.7})
top = client.get("/api/stats/top").json()
multi = next(r for r in top if r["filename"] == "multi.archive")
assert multi["best_score"] == 800 # best arrangement, not summed/duplicated
assert [r["filename"] for r in top].count("multi.archive") == 1
# limit caps the list.
assert len(client.get("/api/stats/top?limit=1").json()) == 1
# ── Codex-preflight regressions (bad-input hardening + resume touch) ──────────
def test_stats_rejects_non_finite_score_accuracy(client):