refactor(ui)!: remove the classic v2 shell — v3 is the only UI (R3a) (#871)

* refactor(ui)!: remove the classic v2 shell — v3 is the only UI (R3a) Deletes `static/index.html`, the `/v2` route, and the `FEEDBACK_UI` v2/legacy opt-out. `/` and `/v3` both serve `static/v3/index.html`, which has been the default since 0.3.0. This is step 0 of the core-frontend ES-module migration (R3a). Both shells load the same `static/app.js`, so every later step of that migration — exposing the window contract, the `defer` ordering fix, the `type="module"` flips — would otherwise have to be made and verified twice. Removing the fallback now halves that surface before any of it is touched. Incidentally fixes a latent bug in `index()`: its guard read `if getenv_compat("FEEDBACK_UI") or getenv_compat("FEEDBACK_UI") in ("v2", "legacy")`, whose left operand is truthy for *any* non-empty value — so `FEEDBACK_UI=v3` actually served the **v2** shell. - `static/tailwind.min.css` regenerated: the content globs scanned the deleted file, so v2-only utility classes are now purged (CI's tailwind-fresh job rebuilds and diffs it). - Constitution amended to 1.3.0 — Principle II's frontend file list now names `static/v3/index.html`. - Tests: 4 suites read the v2 shell (3 via a constructed `path.join` that a literal grep misses). Their v2 halves are paired duplicates of v3 tests that stay, so they are dropped; `alpha_warning_banner` and the capability-registry script-order test retarget to `static/v3/index.html`. BREAKING CHANGE: `FEEDBACK_UI=v2` / `=legacy` and the `/v2` route are gone. Unset the variable and use `/`. No chart, settings, or plugin data changes, and no plugin API changes — v3 reuses the same engine. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs: drop the stale '/ is v2' plugin-verification guidance (CodeRabbit) The v3-only rewrite updated the intro paragraphs but left three lines that still instructed plugin authors to verify in 'both / (v2) and /v3' — now the same shell. Historical 'in v2 it was X' contrasts are kept: they still orient authors whose plugins also ship to users on older cores. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-08-11 03:09:57 +00:00 · 2026-07-11 16:33:03 +02:00
parent 5e30138c87
commit 9d0bf95716
18 changed files with 74 additions and 704 deletions
@@ -1,14 +1,15 @@
 <!DOCTYPE html>
 <!--
-  fee[dB]ack v0.3.0 shell (FEEDBACK_UI=v3 / GET /v3).
+  fee[dB]ack v0.3.0 shell — the app's only UI, served at `/` (and `/v3`, a
+  back-compat alias). The classic v2 shell it was forked from is deleted.

-  This is a re-chromed copy of the legacy static/index.html: the v0.3.0
-  sidebar + topbar replace the (hidden) legacy navbar, new #v3-* screens are
-  added, and all the legacy screens (#home library, #favorites, #settings,
-  #player, #audio, plugin nav containers) are kept verbatim so static/app.js
-  boots UNMODIFIED and the whole engine — player/highway, plugin loader,
-  capabilities, audio, library, settings — is reused as-is. Navigation is the
-  shared window.showScreen across both #v3-* and legacy/#plugin-* screens.
+  Originally a re-chromed copy of that shell: the v0.3.0 sidebar + topbar
+  replace the (hidden) legacy navbar, new #v3-* screens are added, and all the
+  legacy screens (#home library, #favorites, #settings, #player, #audio, plugin
+  nav containers) are kept verbatim so static/app.js boots UNMODIFIED and the
+  whole engine — player/highway, plugin loader, capabilities, audio, library,
+  settings — is reused as-is. Navigation is the shared window.showScreen across
+  both #v3-* and legacy/#plugin-* screens.
  See ~/Repositories/feedBack-feedback-v030/prompts/12-app-shell.md.
 -->
 <html lang="en" class="dark scroll-smooth">