got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-08-11 03:09:57 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

chore(hotkeys): remove sloppak-convert library hotkey (#594)

Browse Source 
* chore(hotkeys): remove sloppak-convert library hotkey

Removes the 'c' keyboard shortcut for converting library entries to
.sloppak. The shortcut was defined in two places:

- The no-op registerShortcut() entry that only existed to show in the
  ? help panel (the Sloppak Converter plugin handles conversion and
  can register its own shortcut via window.registerShortcut).
- The c dispatch in the library-entry keydown handler
  ({ c: 'button.sloppak-convert-btn', ... }) that triggered the
  plugin button.

* test+docs: update tests & CHANGELOG for removed `c` convert hotkey

The previous commit removed the `c` library hotkey but left three
assertions in tests/browser/keyboard-shortcuts.spec.ts that require it,
which fail deterministically (the two registry tests read window._panels
directly, independent of environment):
- should list all registered shortcuts (required {key:'c',scope:'library'})
- should have correct shortcut scopes (expected library::c)
- should show library shortcuts in help modal (Convert library entry / c)

Drop those assertions and record the removal under CHANGELOG
[Unreleased] -> Removed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: byrongamatos <xasiklas@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
OmikronApex
2026-06-24 21:24:31 +02:00
committed by GitHub
co-authored by Claude Opus 4.8 byrongamatos
parent 64801d5735
commit 82db8e56b1
3 changed files with 6 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/browser/keyboard-shortcuts.spec.ts
+1 -5
View File
@@ -90,7 +90,6 @@ test.describe('Keyboard Shortcuts', () => {
const required = [
{ key: '?', scope: 'global' },
{ key: '/', scope: 'library' },
{ key: 'c', scope: 'library' },
{ key: 'f', scope: 'library' },
{ key: 'e', scope: 'library' },
{ key: 'Space', scope: 'player' },
@@ -125,9 +124,7 @@ test.describe('Keyboard Shortcuts', () => {
// Library shortcuts should be visible on library screen
await expect(modal).toContainText('Focus search');
await expect(modal).toContainText('/');
await expect(modal).toContainText('Convert library entry');
await expect(modal).toContainText('c');
// Player shortcuts should NOT be visible on library screen
await expect(modal).not.toContainText('Play/Pause');
});
@@ -149,7 +146,6 @@ test.describe('Keyboard Shortcuts', () => {
const expectedShortcuts = [
{ key: '?', scope: 'global' },
{ key: '/', scope: 'library' },
{ key: 'c', scope: 'library' },
{ key: 'f', scope: 'library' },
{ key: 'e', scope: 'library' },
{ key: 'Space', scope: 'player' },