mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-09-12 12:08:30 +00:00
feat(h3d-carve-15): extract U-section (per-frame renderer) into src/renderer.js
- createRenderer factory DI: 241 params (consts, fn-refs, 33 pool getters, material/settings/camera/ND getters, 35 setters) - screen.js: tombstone + createRenderer wiring after createNoteRenderer + createCamera wirings (§1 ruling: createNoteRenderer called from screen.js) - Restore createArp wiring + _resetStringDependentCaches to screen.js (accidentally dropped during carve; both needed in IIFE scope) - smoothNow: correction 3 — setter form setFrameNow(v); return v (no bare return (_frameNow = raw)) - _applyNoteCamTargets callers: 2 sites (7940/9923); correction 2 verified - lookaheadSmoothCamStep callers: 3 sites (9963/9974/9978); correction 2 verified - plugin.json: bump 3.50.0 → 3.51.0 Tests (16 files updated to scan renderer.js): - highway_3d_renderer.test.js: new, 15 tests — export contract, DI count (241), tombstone, caller-list corrections, smoothNow semantics, ordering - highway_3d_arp_deferral.test.js: add renderer.js scan (deferChordGems / noteStreamCoversArpShape moved to renderer.js) - highway_3d_lean_sustain.test.js: add renderer.js scan; update to setLeanSus/getLeanSus() getter form - highway_3d_smooth_clock_pause.test.js: fix literal-newline syntax error; update to setClkAudioT/setClkPerf/setFrameNow setter form; update new-sample regex to match getClkAudioT() - highway_3d_slide_target.test.js: add renderer.js to src scan - highway_3d_sustain_rail.test.js: assert against rendererSrc (pattern moved from U-section) - highway_chart_transform.test.js: add utils.js scan (_openStringPitchLabels- ForTuning moved to src/utils.js by h3d-carve-3) - highway_note_state.test.js: add renderer.js scan (_ndGetNoteState / _ndHasProvider captures in renderer.js update()) - highway_3d_camera_bootstrap.test.js: setter form for camSnapped/curX/ measureStarts; renderer.js added to scan - highway_3d_camera_framing.test.js: renderer.js added; setMeasureStarts/ setCamSnapped setter form in assertions Suite: 1395/1396 (test 46 pre-existing failure unrelated to carve-15) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uZ169yfoFYArXz962g7KW
This commit is contained in:
co-authored by
Claude Sonnet 4.6
parent
b02c760aec
commit
7623ad85e3
@@ -22,7 +22,9 @@ const SCREEN_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'scr
|
||||
// h3d-carve-14: sustain trail code moved to note-renderer.js; trail tests
|
||||
// must now search both files.
|
||||
const NOTE_RENDERER_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'src', 'note-renderer.js');
|
||||
const RENDERER_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'src', 'renderer.js');
|
||||
const _noteRendererSrc = fs.readFileSync(NOTE_RENDERER_JS, 'utf8');
|
||||
const _rendererSrc = fs.readFileSync(RENDERER_JS, 'utf8');
|
||||
|
||||
test('lean sustain rendering is the default (_leanSus starts true)', () => {
|
||||
const src = fs.readFileSync(SCREEN_JS, 'utf8');
|
||||
@@ -34,28 +36,30 @@ test('lean sustain rendering is the default (_leanSus starts true)', () => {
|
||||
});
|
||||
|
||||
test('the full-quality look is an opt-out via localStorage h3d_full_sus', () => {
|
||||
const src = fs.readFileSync(SCREEN_JS, 'utf8');
|
||||
// h3d-carve-15: lean poll + setLeanSus call now in renderer.js update()
|
||||
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
||||
assert.match(
|
||||
src,
|
||||
/_leanSus\s*=\s*localStorage\.getItem\(\s*['"]h3d_full_sus['"]\s*\)\s*!==\s*['"]1['"]/,
|
||||
/setLeanSus\s*\(\s*localStorage\.getItem\(\s*['"]h3d_full_sus['"]\s*\)\s*!==\s*['"]1['"]\s*\)/,
|
||||
"lean must stay on unless localStorage.h3d_full_sus === '1' opts back into the full look",
|
||||
);
|
||||
});
|
||||
|
||||
test('exactly one element is gated behind the lean flag, and it is the rail bloom', () => {
|
||||
const src = fs.readFileSync(SCREEN_JS, 'utf8');
|
||||
// h3d-carve-15: lean gate moved to renderer.js; getter form getLeanSus()
|
||||
const src = fs.readFileSync(SCREEN_JS, 'utf8') + '\n' + fs.readFileSync(RENDERER_JS, 'utf8');
|
||||
// Only the additive rail bloom may hide behind the lean flag. If a future
|
||||
// edit re-gates the trail or ribbon outline behind !_leanSus, this count
|
||||
// edit re-gates the trail or ribbon outline behind !getLeanSus(), this count
|
||||
// climbs above 1 and the test fails — that's the regression guard.
|
||||
const gates = src.match(/if\s*\(\s*!_leanSus\s*\)/g) || [];
|
||||
const gates = src.match(/if\s*\(\s*!getLeanSus\s*\(\s*\)\s*\)/g) || [];
|
||||
assert.equal(
|
||||
gates.length,
|
||||
1,
|
||||
'expected exactly one `if (!_leanSus)` gate (the rail bloom); the outline must stay ungated',
|
||||
'expected exactly one `if (!getLeanSus())` gate (the rail bloom); the outline must stay ungated',
|
||||
);
|
||||
assert.match(
|
||||
src,
|
||||
/if\s*\(\s*!_leanSus\s*\)\s*\{[\s\S]{0,200}?pSusRailBloom\.get\(\)/,
|
||||
/if\s*\(\s*!getLeanSus\s*\(\s*\)\s*\)\s*\{[\s\S]{0,200}?pSusRailBloom\.get\(\)/,
|
||||
'the single lean gate must be the one that wraps pSusRailBloom.get()',
|
||||
);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user