got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-09-12 15:58:31 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(career): gig backfill offsets by qualifying taken, not picks length

Browse Source 
CodeRabbit on #954: after the stakes loop appends near-bar songs,
qualifying[len(picks):] overshoots and skips eligible qualifying songs
— a stocked passport could still get a short set.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
byrongamatos
2026-07-14 01:26:04 +02:00
co-authored by Claude Fable 5
parent c59883aac9
commit 72212e7bfd
2 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/career/routes.py
+7 -5
View File
@@ -722,18 +722,20 @@ def setup(app, context):
# first gig is how stubs start. random per call = free re-roll.
random.shuffle(qualifying)
rest.sort(key=lambda s: -s["best_accuracy"])
picks = qualifying[:max(1, size - cfg["stakes_songs"])]
qtaken = max(1, size - cfg["stakes_songs"])
picks = qualifying[:qtaken]
for s in rest:
if len(picks) >= size:
break
picks.append(s)
# Surplus qualifying songs backfill a short set — a mature passport
# with no near-bar songs left must still fill the bill.
for s in qualifying[len(picks):] if len(picks) < size else []:
# with no near-bar songs left must still fill the bill. Offset by how
# many QUALIFYING songs were taken, not len(picks): rest's stakes
# additions would otherwise skip eligible qualifying songs entirely.
for s in qualifying[qtaken:]:
if len(picks) >= size:
break
if s not in picks:
picks.append(s)
picks.append(s)
if len(picks) < size:
exclude = {s["filename"] for s in picks}
picks.extend(_unplayed_genre_songs(gkey, exclude, size - len(picks)))