got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-08-12 11:49:28 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Persist per-pane framing across songs via durable slot keys

Browse Source 
Per-pane overrides were keyed by an ephemeral per-instance id, so leaving a
song and opening another rebuilt the renderer with a new id and the pane's
framing was lost.

Key overrides by the durable split slot again ('main' | 'panel<idx>', via
_bgPanelKey) so the same slot means the same pane across songs, and persist
__panels to localStorage. Keep the anti-flicker fixes that were the actual
cause of the earlier dropdown churn (prune stale panes, rebuild only on a
pane-set change, never rebuild while the select is focused). The slot key is
latched to the last real slot so a transient null from panelIndexFor during
a song/layout transition can't flip it to 'main' and drop the override for a
frame; it resets in destroy() for instance reuse in another slot.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: topkoa <topkoa@gmail.com>
This commit is contained in:
topkoa
2026-07-01 02:08:27 -04:00
co-authored by Claude Opus 4.8
parent 6c42d83c31
commit 64b95d6f34
2 changed files with 41 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/js/highway_3d_wide_fov.test.js
+16 -7
View File
@@ -174,13 +174,22 @@ test('a Target select and pane registry drive the per-pane picker', () => {
'camUpdate must register its pane each frame');
});
test('panes are keyed by a stable per-instance id, not the split panel index', () => {
// Keying by a stable instance uid keeps the Target picker steady; the split
// plugin's panel index can ping-pong with focus and cause flicker/dupes.
assert.match(src, /_paneUid\s*=\s*\+\+\s*_aspectPaneCounter/,
'each renderer instance must take a stable pane uid in init()');
assert.match(src, /const\s+_paneKey\s*=\s*'pane'\s*\+\s*_paneUid\s*;/,
'camUpdate must key the pane by its stable instance uid');
test('panes are keyed by the durable split slot and the key is latched', () => {
// Slot keys ('main' | 'panel<idx>') persist across songs, so a pane's
// overrides carry over. The key is latched to the last real slot so a
// transient null from panelIndexFor doesn't flip it to 'main' for a frame.
assert.match(src, /const\s+_pk0\s*=\s*_bgPanelKey\(\s*highwayCanvas\s*\)\s*;/,
'camUpdate must derive the slot key from _bgPanelKey(highwayCanvas)');
assert.match(src, /if\s*\(\s*_pk0\s*!==\s*'main'\s*\)\s*_paneKeyCached\s*=\s*_pk0\s*;[\s\S]*?const\s+_paneKey\s*=\s*_paneKeyCached\s*\|\|\s*_pk0\s*;/,
'camUpdate must latch the last real slot key');
});
test('per-pane overrides persist to localStorage (carry across songs)', () => {
assert.match(
src,
/function\s+_aspectPersist\s*\(\)[\s\S]*?if\s*\(\s*t\.__panels\s*\)\s*out\.__panels\s*=\s*t\.__panels/,
'_aspectPersist must include __panels so per-slot overrides survive a reload / song change',
);
});
test('the target dropdown prunes dead panes and does not rebuild while focused', () => {