mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-12 11:49:28 +00:00
feat(progression): fancy notifications for quest/path progress + completion (#552)
* feat(progression): fancy notifications for quest/path progress + completion (#551) Surface achievement feedback as in-app toasts when the player advances or finishes a daily/weekly quest, and when they progress or level up an instrument path. - progression-core.js: _diff() now emits two partial-advance events — quest-progressed (a still-incomplete quest whose count rose) and path-progressed (a challenge toward the next level completed without a level-up). Both are guarded so the increment that COMPLETES a quest / the level-up itself stays a single quest-completed / path-level-up event (no double toast). Period rollovers and brand-new quest ids emit nothing. New events added to the capability owner's declared events list. - notifications.js (new): reusable window.fbNotify toast surface (stacked, animated, auto-dismiss; animation + accent via inline styles so no new Tailwind utilities) + progression wiring — subtle toasts for advances, celebratory toasts for quest completion, path level-up, and rank-up. - index.html: load notifications.js after progression-core. - tests: progression_progress_events (diff emission + guards) and progression_notifications (toast rendering + wiring) — 11 cases. No backend change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(progression): unwrap CustomEvent .detail in notification handlers Codex P2: window.slopsmith.on delivers a CustomEvent (bus.on → addEventListener), so the progression payload is e.detail — not the raw argument. All five notifications.js handlers read the arg directly, so in the browser every field was undefined (e.g. rank-changed never toasted). Unwrap e.detail in each handler, matching every other sm.on consumer. The test harness masked this by invoking handlers with raw payloads; it now wraps them as {detail: payload} like the real bus, so the unwrap is actually exercised (the tests fail without the fix). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Byron Gamatos
co-authored by
Claude Opus 4.8
Claude Opus 4.8
parent
a0867f8bfd
commit
63eb7a4ffc
@@ -859,6 +859,7 @@
|
||||
registers the `progression` capability owner + window.v3Progression. -->
|
||||
<script src="/static/v3/theme-core.js"></script>
|
||||
<script src="/static/v3/progression-core.js"></script>
|
||||
<script src="/static/v3/notifications.js"></script>
|
||||
<script src="/static/v3/profile.js"></script>
|
||||
<script src="/static/v3/progress.js"></script>
|
||||
<script src="/static/v3/shop.js"></script>
|
||||
|
||||
@@ -0,0 +1,160 @@
|
||||
/*
|
||||
* fee[dB]ack v0.3.0 — achievement notifications (toasts).
|
||||
*
|
||||
* A small, reusable toast surface (window.fbNotify) plus the progression wiring
|
||||
* that turns progression:* lifecycle events into fancy in-app notifications:
|
||||
*
|
||||
* quest-progressed → subtle "Quest advanced — N/M"
|
||||
* quest-completed → celebratory "Quest Complete! +N dB"
|
||||
* path-progressed → subtle "{Path}: challenge done — N/M to Level X"
|
||||
* path-level-up → celebratory "{Path} reached Level X!"
|
||||
* rank-changed (up) → celebratory "Mastery Rank X!"
|
||||
*
|
||||
* Vanilla JS, no framework (constitution P-II). Animation + accent colors are
|
||||
* inline styles so the prebuilt Tailwind stylesheet needs no new utilities.
|
||||
* Self-contained: it subscribes through window.slopsmith.on, degrading to a
|
||||
* no-op when the bus or DOM isn't present (SSR/headless safety, P15).
|
||||
*/
|
||||
(function () {
|
||||
'use strict';
|
||||
|
||||
const esc = (s) => String(s == null ? '' : s).replace(/[&<>"']/g, (c) => (
|
||||
{ '&': '&', '<': '<', '>': '>', '"': '"', "'": ''' }[c]));
|
||||
|
||||
function container() {
|
||||
let host = document.getElementById('fb-notify-stack');
|
||||
if (!host) {
|
||||
host = document.createElement('div');
|
||||
host.id = 'fb-notify-stack';
|
||||
// Bottom-right stack, newest on top; clicks pass through the gaps.
|
||||
host.className = 'fixed bottom-4 right-4 z-[120] flex flex-col gap-2 items-end pointer-events-none';
|
||||
host.style.maxWidth = 'min(24rem, calc(100vw - 2rem))';
|
||||
document.body.appendChild(host);
|
||||
}
|
||||
return host;
|
||||
}
|
||||
|
||||
// opts: { title, message, icon, accent, reward, big, durationMs }
|
||||
function show(opts) {
|
||||
opts = opts || {};
|
||||
if (typeof document === 'undefined' || !document.body) return null;
|
||||
const host = container();
|
||||
const accent = opts.accent || '#3B82F6';
|
||||
const big = !!opts.big;
|
||||
|
||||
const card = document.createElement('div');
|
||||
card.className = 'pointer-events-auto bg-fb-card border border-fb-border/60 rounded-xl shadow-xl ' +
|
||||
'flex items-center gap-3 ' + (big ? 'px-4 py-3' : 'px-3 py-2');
|
||||
card.style.borderLeft = '4px solid ' + accent;
|
||||
card.style.opacity = '0';
|
||||
card.style.transform = 'translateY(12px)';
|
||||
card.style.transition = 'transform .35s cubic-bezier(.2,.8,.2,1), opacity .35s';
|
||||
|
||||
const iconSize = big ? 'w-10 h-10 text-xl' : 'w-8 h-8 text-base';
|
||||
const icon = '<span class="' + iconSize + ' shrink-0 rounded-lg inline-flex items-center justify-center" ' +
|
||||
'style="background-color:' + accent + '22">' + esc(opts.icon || '⭐') + '</span>';
|
||||
|
||||
const reward = (opts.reward != null && Number(opts.reward) > 0)
|
||||
? '<span class="block text-xs font-semibold text-fb-gold mt-0.5">+' +
|
||||
Number(opts.reward).toLocaleString() + ' dB</span>'
|
||||
: '';
|
||||
const body = '<span class="min-w-0 flex-1">' +
|
||||
'<span class="block ' + (big ? 'text-sm font-bold' : 'text-xs font-semibold') +
|
||||
' text-fb-text truncate">' + esc(opts.title || '') + '</span>' +
|
||||
(opts.message ? '<span class="block text-xs text-fb-textDim truncate">' + esc(opts.message) + '</span>' : '') +
|
||||
reward + '</span>';
|
||||
|
||||
card.innerHTML = icon + body;
|
||||
host.insertBefore(card, host.firstChild); // newest on top of the stack
|
||||
|
||||
// Animate in on the next frame (double rAF so the initial style applies).
|
||||
requestAnimationFrame(() => requestAnimationFrame(() => {
|
||||
card.style.opacity = '1';
|
||||
card.style.transform = 'translateY(0)';
|
||||
}));
|
||||
|
||||
const dur = opts.durationMs || (big ? 5200 : 3200);
|
||||
const dismiss = () => {
|
||||
if (card._done) return;
|
||||
card._done = true;
|
||||
clearTimeout(card._t);
|
||||
card.style.opacity = '0';
|
||||
card.style.transform = 'translateY(8px)';
|
||||
setTimeout(() => { try { card.remove(); } catch (e) { /* already gone */ } }, 360);
|
||||
};
|
||||
card.addEventListener('click', dismiss);
|
||||
card._t = setTimeout(dismiss, dur);
|
||||
return card;
|
||||
}
|
||||
|
||||
function clear() {
|
||||
const host = document.getElementById('fb-notify-stack');
|
||||
if (host) host.innerHTML = '';
|
||||
}
|
||||
|
||||
window.fbNotify = { show: show, clear: clear };
|
||||
|
||||
// ── Progression wiring ────────────────────────────────────────────────────
|
||||
const sm = window.slopsmith;
|
||||
if (!sm || typeof sm.on !== 'function') return; // no bus → toasts API still usable
|
||||
|
||||
const periodLabel = (p) => (p === 'weekly' ? 'Weekly Quest' : p === 'daily' ? 'Daily Quest' : 'Quest');
|
||||
const pathName = (id, fallback) => {
|
||||
const prog = (window.v3Progression && window.v3Progression.get()) || null;
|
||||
const hit = ((prog && prog.paths) || []).find((p) => p && p.id === id);
|
||||
return (hit && hit.name) || fallback || 'Path';
|
||||
};
|
||||
|
||||
// The bus delivers a CustomEvent; the progression payload is e.detail
|
||||
// (matches every other window.slopsmith.on consumer, e.g. progress.js).
|
||||
sm.on('progression:quest-progressed', (e) => {
|
||||
const q = e && e.detail;
|
||||
if (!q) return;
|
||||
fbNotify.show({
|
||||
icon: '🎯', accent: '#3B82F6',
|
||||
title: periodLabel(q.period_type) + ' advanced',
|
||||
message: (q.title ? q.title + ' — ' : '') + q.count + '/' + q.target,
|
||||
});
|
||||
});
|
||||
|
||||
sm.on('progression:quest-completed', (e) => {
|
||||
const q = e && e.detail;
|
||||
if (!q) return;
|
||||
fbNotify.show({
|
||||
big: true, icon: '🏆', accent: '#FACC15',
|
||||
title: periodLabel(q.period_type) + ' complete!',
|
||||
message: q.title || '', reward: q.reward_db,
|
||||
});
|
||||
});
|
||||
|
||||
sm.on('progression:path-progressed', (e) => {
|
||||
const p = e && e.detail;
|
||||
if (!p) return;
|
||||
fbNotify.show({
|
||||
icon: '🎸', accent: '#22C55E',
|
||||
title: (p.name || 'Path') + ' progress',
|
||||
message: 'Challenge done — ' + p.completed + '/' + p.required + ' to Level ' + p.next_level,
|
||||
});
|
||||
});
|
||||
|
||||
sm.on('progression:path-level-up', (e) => {
|
||||
const l = e && e.detail;
|
||||
if (!l) return;
|
||||
fbNotify.show({
|
||||
big: true, icon: '⭐', accent: '#F97316',
|
||||
title: pathName(l.path_id) + ' — Level ' + l.new_level + '!',
|
||||
message: 'Instrument path leveled up',
|
||||
});
|
||||
});
|
||||
|
||||
sm.on('progression:rank-changed', (e) => {
|
||||
const r = e && e.detail;
|
||||
// Celebrate rank-UPs only (a per-source reset can lower it).
|
||||
if (!r || !(Number(r.to) > Number(r.from))) return;
|
||||
fbNotify.show({
|
||||
big: true, icon: '🏅', accent: '#A855F7',
|
||||
title: 'Mastery Rank ' + r.to + '!',
|
||||
message: 'Your overall rank went up',
|
||||
});
|
||||
});
|
||||
})();
|
||||
@@ -14,9 +14,11 @@
|
||||
*
|
||||
* Lifecycle events are emitted on the capability surface and mirrored on
|
||||
* window.slopsmith as `progression:*` for non-capability consumers:
|
||||
* challenge-completed, quest-completed, path-level-up, rank-changed,
|
||||
* db-changed, calibration-completed, cosmetic-equipped (+ progression:updated
|
||||
* whenever fresh state lands).
|
||||
* challenge-completed, quest-completed, quest-progressed, path-level-up,
|
||||
* path-progressed, rank-changed, db-changed, calibration-completed,
|
||||
* cosmetic-equipped (+ progression:updated whenever fresh state lands).
|
||||
* quest-progressed / path-progressed are the partial-advance counterparts to
|
||||
* the *-completed / *-level-up events (the achievement-toast feed).
|
||||
*
|
||||
* Vanilla JS, no framework (constitution P-II).
|
||||
*/
|
||||
@@ -37,6 +39,19 @@
|
||||
}
|
||||
}
|
||||
|
||||
// Index quests by "period:id" so a refresh can be diffed against the last
|
||||
// state (period_type isn't on the per-quest payload, so carry it here).
|
||||
function _questIndex(state) {
|
||||
const out = {};
|
||||
const quests = (state && state.quests) || {};
|
||||
['daily', 'weekly'].forEach((period) => {
|
||||
(((quests[period] || {}).quests) || []).forEach((item) => {
|
||||
if (item && item.id != null) out[period + ':' + item.id] = { period, item };
|
||||
});
|
||||
});
|
||||
return out;
|
||||
}
|
||||
|
||||
function _diff(prev, next) {
|
||||
if (!prev || !next) return;
|
||||
if (prev.mastery_rank !== next.mastery_rank) {
|
||||
@@ -45,6 +60,38 @@
|
||||
const before = (prev.wallet || {}).balance;
|
||||
const after = (next.wallet || {}).balance;
|
||||
if (before !== after) _emit('db-changed', { from: before, to: after, wallet: next.wallet });
|
||||
|
||||
// Quest "advance" — a still-incomplete quest whose count rose since the
|
||||
// last state. The increment that COMPLETES a quest is intentionally left
|
||||
// to quest-completed (emitted from notify()'s summary) so a finished
|
||||
// quest surfaces once, not twice. A period rollover (count resets to 0,
|
||||
// or a brand-new quest id) produces no event.
|
||||
const prevQuests = _questIndex(prev);
|
||||
const nextQuests = _questIndex(next);
|
||||
Object.keys(nextQuests).forEach((key) => {
|
||||
const pq = prevQuests[key];
|
||||
const nq = nextQuests[key];
|
||||
if (pq && !nq.item.completed && Number(nq.item.count) > Number(pq.item.count)) {
|
||||
_emit('quest-progressed', Object.assign({ period_type: nq.period }, nq.item));
|
||||
}
|
||||
});
|
||||
|
||||
// Path "progress" — a challenge toward the next level completed
|
||||
// (next.completed rose) WITHOUT a level-up. The level-up itself is
|
||||
// emitted as path-level-up from notify()'s summary, so it surfaces once.
|
||||
const prevPaths = {};
|
||||
(prev.paths || []).forEach((p) => { if (p && p.id != null) prevPaths[p.id] = p; });
|
||||
(next.paths || []).forEach((np) => {
|
||||
const pp = prevPaths[np && np.id];
|
||||
if (!pp || !np.next || !pp.next) return;
|
||||
if (np.level === pp.level && Number(np.next.completed) > Number(pp.next.completed)) {
|
||||
_emit('path-progressed', {
|
||||
id: np.id, name: np.name, level: np.level,
|
||||
next_level: np.next.level,
|
||||
completed: np.next.completed, required: np.next.required,
|
||||
});
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
async function refresh() {
|
||||
@@ -135,7 +182,8 @@
|
||||
ownership: 'exclusive-owner',
|
||||
safety: 'safe',
|
||||
commands: ['inspect', 'record-event', 'list-shop', 'buy-item', 'equip-item'],
|
||||
events: ['challenge-completed', 'quest-completed', 'path-level-up', 'rank-changed',
|
||||
events: ['challenge-completed', 'quest-completed', 'quest-progressed',
|
||||
'path-level-up', 'path-progressed', 'rank-changed',
|
||||
'db-changed', 'calibration-completed', 'cosmetic-equipped'],
|
||||
description: 'Owns player progression: mastery rank, instrument-path challenges, daily/weekly quests, the Decibels wallet, and the cosmetics shop.',
|
||||
handlers: {
|
||||
|
||||
Reference in New Issue
Block a user