mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-11 03:09:57 +00:00
Purge external-format terminology from code, tests and docs
Reword comments/docstrings/strings and rename identifiers that referenced the external game and its file formats: - format-id "psarc" -> "archive"; local vars psarc_path -> song_path, psarc_base -> tone_base - lyrics provenance value "sng" -> "notechart" (legacy "sng" still accepted) - highway_3d fret-ghost scope value "rocksmith" -> "chords" (invalid/legacy values fall back to the default, preserving behaviour) - neutralise references in prose, test names/data, .gitattributes and docs No functional change beyond the renamed identifiers; all Python compiles.
This commit is contained in:
Sin
@@ -1099,7 +1099,7 @@
|
||||
return _bgBandsCache;
|
||||
}
|
||||
|
||||
const BG_DEFAULTS = { style: 'particles', intensity: 0.5, reactive: true, palette: 'default', showFretOnNote: true, fretNumberGhostScope: 'rocksmith', cameraSmoothing: 0.5, zoomSmoothing: 0.5, tiltSmoothing: 0.5, cameraLockLow: false, cameraLockZoom: 0.5, cameraMode: 'lookahead', nutHeadstockVisible: true, tuningLabelsVisible: true, nutColor: '#f5f3f0', headstockColor: '#d4b48a', textSize: 0.5, vibrancy: 0.85, glow: 0.25, customImageDataUrl: '', customImageName: '', customVideoName: '', chordDiagramVisible: true, chordDiagramSize: 0.5, chordDiagramPosition: 'tl', fretColumnMarkerCadence: 1, projectionVisible: true, inlayLabelsVisible: false, sectionLabelsOnHighway: false, sectionHudVisible: false, sectionHudPosition: 'tr', sectionHudSize: 0.5, toneHudVisible: false, toneHudPosition: 'tl', toneHudSize: 0.5, fpsVisible: false, fretDividersVisible: true, slideArrowApproachVisible: true, slideArrowNeckVisible: true, slideArrowChainPreviewVisible: true };
|
||||
const BG_DEFAULTS = { style: 'particles', intensity: 0.5, reactive: true, palette: 'default', showFretOnNote: true, fretNumberGhostScope: 'chords', cameraSmoothing: 0.5, zoomSmoothing: 0.5, tiltSmoothing: 0.5, cameraLockLow: false, cameraLockZoom: 0.5, cameraMode: 'lookahead', nutHeadstockVisible: true, tuningLabelsVisible: true, nutColor: '#f5f3f0', headstockColor: '#d4b48a', textSize: 0.5, vibrancy: 0.85, glow: 0.25, customImageDataUrl: '', customImageName: '', customVideoName: '', chordDiagramVisible: true, chordDiagramSize: 0.5, chordDiagramPosition: 'tl', fretColumnMarkerCadence: 1, projectionVisible: true, inlayLabelsVisible: false, sectionLabelsOnHighway: false, sectionHudVisible: false, sectionHudPosition: 'tr', sectionHudSize: 0.5, toneHudVisible: false, toneHudPosition: 'tl', toneHudSize: 0.5, fpsVisible: false, fretDividersVisible: true, slideArrowApproachVisible: true, slideArrowNeckVisible: true, slideArrowChainPreviewVisible: true };
|
||||
// User-selectable, persistable bg styles — must mirror settings.html's
|
||||
// VALID_STYLES. 'venue' is deliberately NOT here: it is an internal effective
|
||||
// style reached only via _venueSceneOverride (the viz-picker Venue flow), so
|
||||
@@ -1325,7 +1325,7 @@
|
||||
},
|
||||
);
|
||||
}
|
||||
const FRET_NUMBER_GHOST_SCOPE_IDS = ['rocksmith', 'all'];
|
||||
const FRET_NUMBER_GHOST_SCOPE_IDS = ['chords', 'all'];
|
||||
|
||||
function _bgPanelKey(canvas) {
|
||||
const ss = window.slopsmithSplitscreen;
|
||||
@@ -2717,7 +2717,7 @@
|
||||
// Fret digits on the board ghost (hollow preview at Z=0), not on
|
||||
// flying note bodies — see fretNumberGhostScope for chord-hand vs all.
|
||||
let showFretOnNote = false;
|
||||
let fretNumberGhostScope = 'rocksmith';
|
||||
let fretNumberGhostScope = 'chords';
|
||||
// Camera-X smoothing dial (issue #34). 0 = twitchy (track every
|
||||
// upcoming fret), 1 = calm (ignore small intra-cluster shifts).
|
||||
// Cached here and refreshed via the bg listener to avoid a
|
||||
@@ -7546,7 +7546,7 @@
|
||||
const tol = 0.028;
|
||||
/**
|
||||
* Suppress a synth chord box when a real chord with the **same trimmed
|
||||
* display name** played within this window — RS CDLC commonly authors
|
||||
* display name** played within this window — Custom songs commonly authors
|
||||
* several ``<chordTemplate>`` rows that share a display name (with
|
||||
* trailing-whitespace IDs) for fingering variants. The follow-up
|
||||
* hand-shape with no chord row is a fingering hint, not a new strum
|
||||
@@ -7558,7 +7558,7 @@
|
||||
const trimmedTemplateName = (cid) => {
|
||||
if (cid == null || !chordTemplates) return '';
|
||||
const tmpl = chordTemplates[cid] ?? chordTemplates[Number(cid)];
|
||||
// CDLC commonly authors several <chordTemplate> rows that share
|
||||
// custom songs commonly authors several <chordTemplate> rows that share
|
||||
// a displayName for fingering variants; the suppression
|
||||
// heuristic in the surrounding code dedupes on the *label*,
|
||||
// not the underlying name, so go through chordTemplateLabel.
|
||||
@@ -12363,13 +12363,13 @@
|
||||
const ghostFretOk = showFretOnNote && (
|
||||
arpGhostActive ||
|
||||
fretNumberGhostScope === 'all' ||
|
||||
(fretNumberGhostScope === 'rocksmith' && fromChord)
|
||||
(fretNumberGhostScope === 'chords' && fromChord)
|
||||
);
|
||||
if (ghostFretOk && pGhostFretLbl) {
|
||||
// chord-hand style → show finger number (1–4) from the chord
|
||||
// template; fall back to fret number when no finger data exists
|
||||
// (GP imports, open strings, non-chord notes).
|
||||
const ghostFretDisplay = fromChord && fretNumberGhostScope === 'rocksmith'
|
||||
const ghostFretDisplay = fromChord && fretNumberGhostScope === 'chords'
|
||||
? (_templateFingerForChordGhost(chordId, n.s) ?? _templateFretForChordGhost(chordId, n.s, n.f))
|
||||
: fromChord
|
||||
? _templateFretForChordGhost(chordId, n.s, n.f)
|
||||
@@ -12389,7 +12389,7 @@
|
||||
// frame (projFactor), instead of popping in at full alpha.
|
||||
ghostFretLblAlpha = projFactor;
|
||||
}
|
||||
const _ghostFretForScale = fromChord && fretNumberGhostScope === 'rocksmith'
|
||||
const _ghostFretForScale = fromChord && fretNumberGhostScope === 'chords'
|
||||
? n.f
|
||||
: ghostFretDisplay;
|
||||
drawGhostFretLabel(x, y, projRim, ghostFretDisplay, ghostFretLblAlpha, projGrowScale, _ghostFretForScale);
|
||||
|
||||
@@ -430,7 +430,7 @@
|
||||
<div id="h3d-fret-ghost-scope-wrap" class="ml-6 mt-2 space-y-2 border-l border-gray-700 pl-3">
|
||||
<p class="text-xs font-medium text-gray-400">Where to show</p>
|
||||
<label class="flex items-center gap-2 text-sm text-gray-300 cursor-pointer">
|
||||
<input type="radio" name="h3d-fret-ghost-scope" id="h3d-fret-ghost-scope-rocksmith" value="rocksmith"
|
||||
<input type="radio" name="h3d-fret-ghost-scope" id="h3d-fret-ghost-scope-chords" value="chords"
|
||||
class="accent-accent">
|
||||
In chords & arpeggios (chord-hand events only)
|
||||
</label>
|
||||
@@ -712,14 +712,14 @@
|
||||
no-selection / NaN state. -->
|
||||
<script>
|
||||
(function () {
|
||||
const DEFAULTS = { style: 'particles', intensity: 0.5, reactive: true, palette: 'default', showFretOnNote: true, fretNumberGhostScope: 'rocksmith', cameraSmoothing: 0.5, zoomSmoothing: 0.5, tiltSmoothing: 0.5, cameraLockLow: false, cameraLockZoom: 0.5, cameraMode: 'lookahead', nutHeadstockVisible: true, tuningLabelsVisible: true, nutColor: '#f5f3f0', headstockColor: '#d4b48a', textSize: 0.5, vibrancy: 0.85, glow: 0.25, customImageDataUrl: '', customImageName: '', customVideoName: '', chordDiagramVisible: true, chordDiagramSize: 0.5, chordDiagramPosition: 'tl', fretColumnMarkerCadence: 1, projectionVisible: true, inlayLabelsVisible: false, sectionLabelsOnHighway: false, sectionHudVisible: false, sectionHudPosition: 'tr', sectionHudSize: 0.5, toneHudVisible: false, toneHudPosition: 'tl', toneHudSize: 0.5, fpsVisible: false, fretDividersVisible: true, slideArrowApproachVisible: true, slideArrowNeckVisible: true, slideArrowChainPreviewVisible: true };
|
||||
const DEFAULTS = { style: 'particles', intensity: 0.5, reactive: true, palette: 'default', showFretOnNote: true, fretNumberGhostScope: 'chords', cameraSmoothing: 0.5, zoomSmoothing: 0.5, tiltSmoothing: 0.5, cameraLockLow: false, cameraLockZoom: 0.5, cameraMode: 'lookahead', nutHeadstockVisible: true, tuningLabelsVisible: true, nutColor: '#f5f3f0', headstockColor: '#d4b48a', textSize: 0.5, vibrancy: 0.85, glow: 0.25, customImageDataUrl: '', customImageName: '', customVideoName: '', chordDiagramVisible: true, chordDiagramSize: 0.5, chordDiagramPosition: 'tl', fretColumnMarkerCadence: 1, projectionVisible: true, inlayLabelsVisible: false, sectionLabelsOnHighway: false, sectionHudVisible: false, sectionHudPosition: 'tr', sectionHudSize: 0.5, toneHudVisible: false, toneHudPosition: 'tl', toneHudSize: 0.5, fpsVisible: false, fretDividersVisible: true, slideArrowApproachVisible: true, slideArrowNeckVisible: true, slideArrowChainPreviewVisible: true };
|
||||
const VALID_STYLES = new Set(['off', 'particles', 'silhouettes', 'lights', 'geometric', 'image', 'video']);
|
||||
const VALID_CAMERA_MODES = new Set(['steady', 'lookahead']);
|
||||
// Chord diagram is top-only (bl/br removed).
|
||||
const VALID_CHORD_DIAG_POSITIONS = new Set(['tl', 'tr']);
|
||||
// Section HUD still supports all four corners independently.
|
||||
const VALID_SECTION_HUD_POSITIONS = new Set(['tl', 'tr', 'bl', 'br']);
|
||||
const VALID_FRET_GHOST_SCOPES = new Set(['rocksmith', 'all']);
|
||||
const VALID_FRET_GHOST_SCOPES = new Set(['chords', 'all']);
|
||||
// Custom images are persisted as base64 data URLs in
|
||||
// localStorage. base64 expands the byte count by ~4/3, and
|
||||
// localStorage values are stored as UTF-16 (two bytes per
|
||||
@@ -1015,7 +1015,7 @@
|
||||
if (lbl) lbl.textContent = intensity.toFixed(2);
|
||||
if (rea) rea.checked = reactive;
|
||||
if (fon) fon.checked = showFretOnNote;
|
||||
const fgsRock = document.getElementById('h3d-fret-ghost-scope-rocksmith');
|
||||
const fgsRock = document.getElementById('h3d-fret-ghost-scope-chords');
|
||||
const fgsAll = document.getElementById('h3d-fret-ghost-scope-all');
|
||||
const fgsWrap = document.getElementById('h3d-fret-ghost-scope-wrap');
|
||||
if (fretNumberGhostScope === 'all') { if (fgsAll) fgsAll.checked = true; }
|
||||
|
||||
Reference in New Issue
Block a user