mirror of
https://github.com/got-feedBack/feedBack.git
synced 2026-08-12 19:59:35 +00:00
feat(v3): tabbed, card-row settings page + per-plugin settings category (#584)
Replace the single long scrolling v3 settings screen with a horizontal tab bar (Gameplay / Audio / Graphics / Keybinds / Progression / Mic / Plugins / System) over card rows (icon + title + description, control on the right) with a per-category Reset. - static/v3/index.html: tab bar + card-row markup (ids keep hydrating through the unchanged app.js loadSettings()/persistSetting() path). - static/v3/settings.js (new): tab switching + active-tab persistence (localStorage 'v3-settings-tab'), per-category reset, read-only Keybinds reference from window.getAllShortcuts(). - static/v3/v3.css: plain CSS, no Tailwind rebuild. - Per-plugin settings tab: new optional settings.category in plugin.json → plugins/__init__.py surfaces settings_category; app.js mounts each plugin <details> into #plugin-settings-<category> (fallback: Plugins tab). highway_3d ships category: "graphics". - New gameplay settings: countdown_before_song (wired end-to-end, default off); miss_penalty + fail_behavior (persist-only stubs); "Note highway speed" surfaces existing master_difficulty. - New POST /api/settings/reset clears whitelisted keys back to defaults. Tests: test_settings_api.py, test_plugins.py::test_settings_category_parsed_from_manifest, tests/browser/settings-tabbed.spec.ts. 179 passed locally. Ported from the pre-rename feat/v3-settings-tabbed WIP onto current main (slopsmith→feedBack rename applied; settings-screen markup conflict resolved in favour of the new tabbed layout — all prior setting ids preserved). Closes #579 Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Byron Gamatos
co-authored by
Claude Opus 4.8
Claude Opus 4.8
parent
f3a5cb9ed3
commit
3b485fe62b
+326
-154
@@ -343,76 +343,60 @@
|
||||
|
||||
<!-- ══ SETTINGS ═══════════════════════════════════════════════════════ -->
|
||||
<div id="settings" class="screen">
|
||||
<div class="max-w-2xl mx-auto px-6 pt-24 pb-16">
|
||||
<button onclick="showScreen('home')" class="text-gray-500 hover:text-white text-sm mb-6 flex items-center gap-1">
|
||||
<svg class="w-4 h-4" fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M15 19l-7-7 7-7"/></svg> Back
|
||||
<div class="fb-settings">
|
||||
<button onclick="showScreen('home')" class="fb-settings-back">
|
||||
<svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M15 19l-7-7 7-7"/></svg> Home
|
||||
</button>
|
||||
<h2 class="text-3xl font-bold text-white mb-8">Settings</h2>
|
||||
<h2 class="fb-settings-title">Settings</h2>
|
||||
|
||||
<div class="space-y-10">
|
||||
<!-- App Updates — Velopack auto-update, desktop only. Stays
|
||||
hidden in the plain web app; setupAppUpdates() unhides
|
||||
this block when window.feedBackDesktop.update exists,
|
||||
and shows a disabled "not available on Linux" fallback
|
||||
when running on Linux. -->
|
||||
<div id="app-updates-block" class="hidden border border-gray-800 rounded-xl bg-dark-800/40 p-5">
|
||||
<h3 class="text-xs font-semibold uppercase tracking-wider text-gray-500 mb-4">App Updates</h3>
|
||||
<div class="grid grid-cols-1 md:grid-cols-2 gap-4">
|
||||
<div>
|
||||
<label class="text-sm font-medium text-gray-400 mb-2 block" for="app-update-channel">Update channel</label>
|
||||
<select id="app-update-channel"
|
||||
class="w-full bg-dark-700 border border-gray-800 rounded-xl px-3 py-2.5 text-sm text-gray-300 outline-none">
|
||||
<option value="stable">Stable</option>
|
||||
<option value="rc">Release candidate</option>
|
||||
<option value="beta">Beta</option>
|
||||
<option value="alpha">Alpha</option>
|
||||
</select>
|
||||
<!-- Tab bar — click handling + active-tab persistence wired by
|
||||
static/v3/settings.js. data-tab keys match the .fb-tabpanel
|
||||
below; the fallback "Plugins" tab hosts uncategorized plugin
|
||||
panels (manifest settings.category routes the others). -->
|
||||
<div class="fb-tabbar" id="settings-tabbar">
|
||||
<button type="button" class="fb-tab" data-tab="gameplay">Gameplay</button>
|
||||
<button type="button" class="fb-tab" data-tab="audio">Audio</button>
|
||||
<button type="button" class="fb-tab" data-tab="graphics">Graphics</button>
|
||||
<button type="button" class="fb-tab" data-tab="keybinds">Keybinds</button>
|
||||
<button type="button" class="fb-tab" data-tab="progression">Progression</button>
|
||||
<button type="button" class="fb-tab" data-tab="mic">Mic</button>
|
||||
<button type="button" class="fb-tab" data-tab="plugins">Plugins</button>
|
||||
<button type="button" class="fb-tab" data-tab="system">System</button>
|
||||
</div>
|
||||
|
||||
<!-- ══ GAMEPLAY ════════════════════════════════════════════════ -->
|
||||
<div class="fb-tabpanel" data-tab="gameplay">
|
||||
<div class="fb-tabpanel-head">
|
||||
<h3>Gameplay Settings</h3>
|
||||
<button type="button" class="fb-reset-btn" data-reset="gameplay">
|
||||
<svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M4 4v5h.582m15.356 2A8.001 8.001 0 004.582 9m0 0H9m11 11v-5h-.581m0 0a8.003 8.003 0 01-15.357-2m15.357 2H15"/></svg>
|
||||
Reset Gameplay Settings
|
||||
</button>
|
||||
</div>
|
||||
<div class="fb-srows">
|
||||
<!-- Left-handed -->
|
||||
<div class="fb-srow">
|
||||
<span class="fb-srow-icon"><svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M8 7h12m0 0l-4-4m4 4l-4 4M16 17H4m0 0l4 4m-4-4l4-4"/></svg></span>
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Left-handed mode</div>
|
||||
<div class="fb-srow-desc">Invert frets on the note highway for left-handed players.</div>
|
||||
</div>
|
||||
<div class="flex items-end">
|
||||
<button id="app-update-check-now"
|
||||
class="bg-accent hover:bg-accent-light px-4 py-2.5 rounded-xl text-sm font-medium text-white transition disabled:opacity-50">
|
||||
Check for updates
|
||||
</button>
|
||||
<div class="fb-srow-control">
|
||||
<label class="fb-switch">
|
||||
<input type="checkbox" id="setting-lefty" onchange="highway.setLefty(this.checked)">
|
||||
<span class="fb-switch-track"></span>
|
||||
</label>
|
||||
</div>
|
||||
</div>
|
||||
<p id="app-update-status" class="text-xs text-gray-500 mt-3">Loading updater status…</p>
|
||||
<p id="app-update-linux-note" class="hidden text-xs text-yellow-300 mt-2">
|
||||
Auto-update is not available on Linux —
|
||||
<a href="https://github.com/got-feedback/feedBack-desktop/releases" target="_blank" rel="noopener" class="text-accent hover:text-accent-light underline">download new versions from GitHub Releases</a>.
|
||||
</p>
|
||||
</div>
|
||||
|
||||
<!-- ── Core FeedBack settings ─────────────────────────────── -->
|
||||
<section>
|
||||
<h3 class="text-xs font-semibold uppercase tracking-wider text-gray-500 mb-4">FeedBack</h3>
|
||||
<div class="space-y-6">
|
||||
<div>
|
||||
<label class="text-sm font-medium text-gray-400 mb-2 block">Library Folder Path</label>
|
||||
<div class="flex gap-3">
|
||||
<input type="text" id="dlc-path" placeholder="/path/to/your/library"
|
||||
class="flex-1 bg-dark-700 border border-gray-800 rounded-xl px-4 py-2.5 text-sm text-gray-300 placeholder-gray-600 focus:border-accent/50 outline-none">
|
||||
<button onclick="pickDlcFolder()" id="btn-pick-dlc" class="hidden bg-dark-600 hover:bg-dark-500 px-4 py-2.5 rounded-xl text-sm text-gray-300 transition whitespace-nowrap">📂 Browse</button>
|
||||
<button onclick="saveSettings()" class="bg-accent hover:bg-accent-light px-6 py-2.5 rounded-xl text-sm font-semibold text-white transition">Save</button>
|
||||
</div>
|
||||
<!-- Default arrangement -->
|
||||
<div class="fb-srow">
|
||||
<span class="fb-srow-icon"><svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M4 6h16M4 12h16M4 18h16"/></svg></span>
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Default arrangement</div>
|
||||
<div class="fb-srow-desc">Which arrangement loads first when you open a song.</div>
|
||||
</div>
|
||||
<div>
|
||||
<label class="flex items-center gap-3 cursor-pointer select-none">
|
||||
<input type="checkbox" id="setting-lefty" onchange="highway.setLefty(this.checked)"
|
||||
class="rounded border-gray-600 bg-dark-700 text-accent focus:ring-accent/40">
|
||||
<span class="text-sm text-gray-300">Left-handed <span class="text-gray-500">(invert frets on the note highway)</span></span>
|
||||
</label>
|
||||
</div>
|
||||
<div>
|
||||
<label class="flex items-center gap-3 cursor-pointer select-none">
|
||||
<input type="checkbox" id="setting-autoplay-exit" checked onchange="setAutoplayExit(this.checked)"
|
||||
class="rounded border-gray-600 bg-dark-700 text-accent focus:ring-accent/40">
|
||||
<span class="text-sm text-gray-300">Autoplay & auto-exit <span class="text-gray-500">(start songs/lessons automatically and return to the menu when the score screen closes)</span></span>
|
||||
</label>
|
||||
</div>
|
||||
<div>
|
||||
<label class="text-sm font-medium text-gray-400 mb-2 block">Default Arrangement</label>
|
||||
<select id="default-arrangement"
|
||||
onchange="persistSetting('default_arrangement', this.value)"
|
||||
<div class="fb-srow-control">
|
||||
<select id="default-arrangement" onchange="persistSetting('default_arrangement', this.value)"
|
||||
class="bg-dark-700 border border-gray-800 rounded-xl px-3 py-2.5 text-sm text-gray-300 outline-none">
|
||||
<option value="">Most notes (auto)</option>
|
||||
<option value="Lead">Lead</option>
|
||||
@@ -420,112 +404,299 @@
|
||||
<option value="Bass">Bass</option>
|
||||
</select>
|
||||
</div>
|
||||
<div>
|
||||
<label class="text-sm font-medium text-gray-400 mb-2 block">Arrangement Names</label>
|
||||
<select id="arrangement-naming-mode"
|
||||
onchange="_onNamingModeChange(this.value)"
|
||||
</div>
|
||||
<!-- Arrangement routes (naming mode) -->
|
||||
<div class="fb-srow">
|
||||
<span class="fb-srow-icon"><svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M9 20l-5.447-2.724A1 1 0 013 16.382V5.618a1 1 0 011.447-.894L9 7m0 13l6-3m-6 3V7m6 10l4.553 2.276A1 1 0 0021 18.382V7.618a1 1 0 00-1.447-.894L15 4m0 13V4m0 0L9 7"/></svg></span>
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Arrangement routes</div>
|
||||
<div class="fb-srow-desc">How arrangement variants are labelled across the app.</div>
|
||||
</div>
|
||||
<div class="fb-srow-control">
|
||||
<select id="arrangement-naming-mode" onchange="_onNamingModeChange(this.value)"
|
||||
class="bg-dark-700 border border-gray-800 rounded-xl px-3 py-2.5 text-sm text-gray-300 outline-none">
|
||||
<option value="smart">Smart (Lead, Alt. Lead, Rhythm, Bass…)</option>
|
||||
<option value="legacy">Legacy (Combo, Bass)</option>
|
||||
</select>
|
||||
</div>
|
||||
<div>
|
||||
<label for="setting-av-offset" class="text-sm font-medium text-gray-400 mb-2 block">
|
||||
A/V Sync Offset: <span id="setting-av-offset-val">0</span> ms
|
||||
</label>
|
||||
<input type="range" id="setting-av-offset" min="-1000" max="1000" step="1" value="0"
|
||||
oninput="setAvOffsetMs(this.value)"
|
||||
class="w-full slider-input">
|
||||
<p class="text-xs text-gray-600 mt-1">Positive = audio plays ahead of visual notes; raise this value to catch the highway up. Adjust live with the [ and ] keys (Shift for ±50 ms). Auto-saves on every change.</p>
|
||||
</div>
|
||||
<!-- A/V sync offset -->
|
||||
<div class="fb-srow fb-srow-stack">
|
||||
<div style="display:flex; align-items:center; gap:1rem;">
|
||||
<span class="fb-srow-icon"><svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M12 8v4l3 3m6-3a9 9 0 11-18 0 9 9 0 0118 0z"/></svg></span>
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">A/V sync offset: <span id="setting-av-offset-val" style="margin-left:.35rem;">0</span> ms</div>
|
||||
<div class="fb-srow-desc">Positive = audio plays ahead of visual notes; raise to catch the highway up. Adjust live with the [ and ] keys (Shift for ±50 ms). Auto-saves.</div>
|
||||
</div>
|
||||
</div>
|
||||
<div>
|
||||
<label for="setting-live-guitar-tone-source" class="text-sm font-medium text-gray-400 mb-2 block">Live guitar tone source</label>
|
||||
<select id="setting-live-guitar-tone-source"
|
||||
<input type="range" id="setting-av-offset" min="-1000" max="1000" step="1" value="0"
|
||||
oninput="setAvOffsetMs(this.value)" class="fb-srow-wide slider-input">
|
||||
</div>
|
||||
<!-- Note highway speed (master difficulty) -->
|
||||
<div class="fb-srow fb-srow-stack">
|
||||
<div style="display:flex; align-items:center; gap:1rem;">
|
||||
<span class="fb-srow-icon"><svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M13 10V3L4 14h7v7l9-11h-7z"/></svg></span>
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Note highway speed: <span id="setting-highway-speed-val" style="margin-left:.35rem;">100</span>%</div>
|
||||
<div class="fb-srow-desc">Master difficulty — lower simplifies the chart (fewer notes); 100% plays the full arrangement.</div>
|
||||
</div>
|
||||
</div>
|
||||
<input type="range" id="setting-highway-speed" min="0" max="100" step="5" value="100"
|
||||
oninput="setMastery(this.value)" class="fb-srow-wide slider-input">
|
||||
</div>
|
||||
<!-- Miss penalty (stub) -->
|
||||
<div class="fb-srow">
|
||||
<span class="fb-srow-icon"><svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M12 9v2m0 4h.01M5.07 19H19a2 2 0 001.71-3L13.71 4a2 2 0 00-3.42 0L3.34 16a2 2 0 001.73 3z"/></svg></span>
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Miss penalty <span class="fb-stub-note">Not yet active</span></div>
|
||||
<div class="fb-srow-desc">How harshly missed notes are scored. Saved now; scoring wiring lands in a later release.</div>
|
||||
</div>
|
||||
<div class="fb-srow-control">
|
||||
<select id="setting-miss-penalty" onchange="persistSetting('miss_penalty', this.value)"
|
||||
class="bg-dark-700 border border-gray-800 rounded-xl px-3 py-2.5 text-sm text-gray-300 outline-none">
|
||||
<option value="internal">fee[dB]ack internal tone</option>
|
||||
<option value="external_hardware">External amp / hardware pedalboard</option>
|
||||
<option value="spark_control_x">Spark LIVE + Spark Control X</option>
|
||||
<option value="none">None</option>
|
||||
<option value="low">Low</option>
|
||||
<option value="medium">Standard</option>
|
||||
<option value="high">High</option>
|
||||
</select>
|
||||
<p class="text-xs text-gray-600 mt-1">Choose External/Spark if your guitar tone comes from hardware like Spark LIVE. fee[dB]ack will still score your playing but won’t warn that no internal amp tone is loaded.</p>
|
||||
</div>
|
||||
<div>
|
||||
<label for="demucs-server-url" class="text-sm font-medium text-gray-400 mb-2 block">Demucs Server (for stem separation)</label>
|
||||
<div class="flex gap-3">
|
||||
<input type="text" id="demucs-server-url" placeholder="http://192.168.1.100:7865"
|
||||
class="flex-1 bg-dark-700 border border-gray-800 rounded-xl px-4 py-2.5 text-sm text-gray-300 placeholder-gray-600 focus:border-accent/50 outline-none">
|
||||
<button onclick="saveSettings()" class="bg-accent hover:bg-accent-light px-6 py-2.5 rounded-xl text-sm font-semibold text-white transition">Save</button>
|
||||
</div>
|
||||
<p class="text-xs text-gray-600 mt-1">Optional. Run <a href="https://github.com/got-feedBack/feedBack-demucs-server" target="_blank" rel="noopener" class="text-accent hover:text-accent-light underline">feedBack-demucs-server</a> on a machine with a GPU to offload stem splitting and avoid resource exhaustion on the host running FeedBack.</p>
|
||||
</div>
|
||||
<div>
|
||||
<label class="text-sm font-medium text-gray-400 mb-2 block">Library</label>
|
||||
<div class="flex items-center gap-3">
|
||||
<button onclick="rescanLibrary()" id="btn-rescan" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Rescan Library</button>
|
||||
<button onclick="fullRescanLibrary()" id="btn-full-rescan" class="bg-dark-600 hover:bg-red-900/30 px-5 py-2.5 rounded-xl text-sm text-gray-400 transition">Full Rescan</button>
|
||||
<span id="rescan-status" class="text-xs text-gray-500"></span>
|
||||
</div>
|
||||
<p class="text-xs text-gray-600 mt-1">Rescan checks for new songs. Full Rescan clears the cache and re-imports everything.</p>
|
||||
</div>
|
||||
<div>
|
||||
<label class="text-sm font-medium text-gray-400 mb-2 block">Backup</label>
|
||||
<div class="flex items-center gap-3">
|
||||
<button onclick="exportSettings()" id="btn-export-settings" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Export Settings</button>
|
||||
<button onclick="document.getElementById('import-settings-file').click()" id="btn-import-settings" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Import Settings</button>
|
||||
<input type="file" id="import-settings-file" accept="application/json,.json" class="hidden" onchange="importSettings(this.files[0]); this.value=''">
|
||||
<span id="backup-status" class="text-xs text-gray-500"></span>
|
||||
</div>
|
||||
<p class="text-xs text-gray-600 mt-1">Export bundles server config, browser preferences, and opted-in plugin data into one JSON file. Import overwrites current settings and reloads.</p>
|
||||
</div>
|
||||
<!-- ── Diagnostics (feedBack#166) ────────────────────── -->
|
||||
<div>
|
||||
<label class="text-sm font-medium text-gray-400 mb-2 block">Diagnostics</label>
|
||||
<div class="grid grid-cols-2 gap-2 mb-3 text-xs text-gray-400">
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-incl-system" checked class="rounded border-gray-600 bg-dark-700 text-accent"> System info</label>
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-incl-hardware" checked class="rounded border-gray-600 bg-dark-700 text-accent"> Hardware (CPU/GPU/RAM)</label>
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-incl-logs" checked class="rounded border-gray-600 bg-dark-700 text-accent"> Server logs (last 5 MB)</label>
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-incl-console" checked class="rounded border-gray-600 bg-dark-700 text-accent"> Browser console + errors</label>
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-incl-plugins" checked class="rounded border-gray-600 bg-dark-700 text-accent"> Plugin diagnostics</label>
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-redact" checked class="rounded border-gray-600 bg-dark-700 text-accent"> Redact paths & song names</label>
|
||||
</div>
|
||||
<div class="flex items-center gap-3">
|
||||
<button onclick="previewDiagnostics()" id="btn-diag-preview" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Preview Bundle</button>
|
||||
<button onclick="exportDiagnostics()" id="btn-diag-export" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Export Diagnostics</button>
|
||||
<span id="diag-status" class="text-xs text-gray-500"></span>
|
||||
</div>
|
||||
<p class="text-xs text-gray-600 mt-1">Bundles server logs, hardware info, plugin inventory, and the browser console transcript into one zip for bug reports. Redaction strips DLC paths, song filenames, and IP addresses by default. Attach to GitHub issues; AI agents can parse the included <code>manifest.json</code>.</p>
|
||||
<div id="diag-preview" class="hidden mt-3 bg-dark-700 border border-gray-800 rounded-xl p-3 text-xs text-gray-400 max-h-96 overflow-auto"></div>
|
||||
</div>
|
||||
<div id="settings-status" class="text-sm text-gray-500"></div>
|
||||
</div>
|
||||
</section>
|
||||
<!-- Countdown before song -->
|
||||
<div class="fb-srow">
|
||||
<span class="fb-srow-icon"><svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M12 8v4l3 3m-3 5a9 9 0 100-18 9 9 0 000 18z"/></svg></span>
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Countdown before song</div>
|
||||
<div class="fb-srow-desc">Play a four-beat count-in before a song starts so you can get ready.</div>
|
||||
</div>
|
||||
<div class="fb-srow-control">
|
||||
<label class="fb-switch">
|
||||
<input type="checkbox" id="setting-countdown-before-song" onchange="setCountdownBeforeSong(this.checked)">
|
||||
<span class="fb-switch-track"></span>
|
||||
</label>
|
||||
</div>
|
||||
</div>
|
||||
<!-- Fail behavior (stub) -->
|
||||
<div class="fb-srow">
|
||||
<span class="fb-srow-icon"><svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M4 4v5h.582m15.356 2A8.001 8.001 0 004.582 9m0 0H9m11 11v-5h-.581m0 0a8.003 8.003 0 01-15.357-2m15.357 2H15"/></svg></span>
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Fail behavior <span class="fb-stub-note">Not yet active</span></div>
|
||||
<div class="fb-srow-desc">What happens when you fail a section. Saved now; gameplay wiring lands in a later release.</div>
|
||||
</div>
|
||||
<div class="fb-srow-control">
|
||||
<select id="setting-fail-behavior" onchange="persistSetting('fail_behavior', this.value)"
|
||||
class="bg-dark-700 border border-gray-800 rounded-xl px-3 py-2.5 text-sm text-gray-300 outline-none">
|
||||
<option value="continue">Continue playing</option>
|
||||
<option value="restart">Restart section</option>
|
||||
<option value="stop">Stop song</option>
|
||||
</select>
|
||||
</div>
|
||||
</div>
|
||||
<!-- Autoplay & auto-exit -->
|
||||
<div class="fb-srow">
|
||||
<span class="fb-srow-icon"><svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M14.752 11.168l-3.197-2.132A1 1 0 0010 9.87v4.263a1 1 0 001.555.832l3.197-2.132a1 1 0 000-1.664z"/><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M21 12a9 9 0 11-18 0 9 9 0 0118 0z"/></svg></span>
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Autoplay & auto-exit</div>
|
||||
<div class="fb-srow-desc">Start songs/lessons automatically and return to the menu when the score screen closes.</div>
|
||||
</div>
|
||||
<div class="fb-srow-control">
|
||||
<label class="fb-switch">
|
||||
<input type="checkbox" id="setting-autoplay-exit" checked onchange="setAutoplayExit(this.checked)">
|
||||
<span class="fb-switch-track"></span>
|
||||
</label>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<!-- ── Plugin settings ─────────────────────────────────────── -->
|
||||
<section id="plugin-settings-area" class="hidden">
|
||||
<h3 class="text-xs font-semibold uppercase tracking-wider text-gray-500 mb-4">Plugins</h3>
|
||||
<div class="space-y-6">
|
||||
<div>
|
||||
<label class="text-sm font-medium text-gray-400 mb-2 block">Plugin Updates</label>
|
||||
<div class="flex items-center gap-3 mb-2">
|
||||
<button onclick="checkPluginUpdates()" id="btn-check-updates" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Check for Updates</button>
|
||||
<span id="updates-status" class="text-xs text-gray-500"></span>
|
||||
<!-- ══ AUDIO ═══════════════════════════════════════════════════ -->
|
||||
<div class="fb-tabpanel" data-tab="audio">
|
||||
<div class="fb-tabpanel-head"><h3>Audio Settings</h3></div>
|
||||
<div class="fb-srows">
|
||||
<!-- Live guitar tone source -->
|
||||
<div class="fb-srow fb-srow-stack">
|
||||
<div style="display:flex; align-items:center; gap:1rem;">
|
||||
<span class="fb-srow-icon"><svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M15.536 8.464a5 5 0 010 7.072M19 5a9 9 0 010 14M5 9v6h4l5 5V4L9 9H5z"/></svg></span>
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Live guitar tone source</div>
|
||||
<div class="fb-srow-desc">Choose External/Spark if your guitar tone comes from hardware like Spark LIVE. fee[dB]ack still scores your playing but won't warn that no internal amp tone is loaded.</div>
|
||||
</div>
|
||||
<div id="plugin-updates-list" class="space-y-2"></div>
|
||||
</div>
|
||||
<!-- Per-plugin collapsible sections injected here -->
|
||||
<div id="plugin-settings" class="space-y-3"></div>
|
||||
<select id="setting-live-guitar-tone-source"
|
||||
class="fb-srow-wide bg-dark-700 border border-gray-800 rounded-xl px-3 py-2.5 text-sm text-gray-300 outline-none">
|
||||
<option value="internal">fee[dB]ack internal tone</option>
|
||||
<option value="external_hardware">External amp / hardware pedalboard</option>
|
||||
<option value="spark_control_x">Spark LIVE + Spark Control X</option>
|
||||
</select>
|
||||
</div>
|
||||
</section>
|
||||
<!-- Demucs server -->
|
||||
<div class="fb-srow fb-srow-stack">
|
||||
<div style="display:flex; align-items:center; gap:1rem;">
|
||||
<span class="fb-srow-icon"><svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M5 12h14M5 12a2 2 0 01-2-2V6a2 2 0 012-2h14a2 2 0 012 2v4a2 2 0 01-2 2M5 12a2 2 0 00-2 2v4a2 2 0 002 2h14a2 2 0 002-2v-4a2 2 0 00-2-2"/></svg></span>
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Demucs server (for stem separation)</div>
|
||||
<div class="fb-srow-desc">Optional. Run <a href="https://github.com/got-feedback/feedBack-demucs-server" target="_blank" rel="noopener" class="text-accent hover:text-accent-light underline">feedBack-demucs-server</a> on a GPU machine to offload stem splitting and avoid resource exhaustion on the host.</div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="fb-srow-control">
|
||||
<input type="text" id="demucs-server-url" placeholder="http://192.168.1.100:7865"
|
||||
class="bg-dark-700 border border-gray-800 rounded-xl px-4 py-2.5 text-sm text-gray-300 placeholder-gray-600 focus:border-accent/50 outline-none">
|
||||
<button onclick="saveSettings()" class="bg-accent hover:bg-accent-light px-6 py-2.5 rounded-xl text-sm font-semibold text-white transition">Save</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<!-- ── About / Source / License (AGPL §13 disclosure) ──────── -->
|
||||
<section>
|
||||
<h3 class="text-xs font-semibold uppercase tracking-wider text-gray-500 mb-4">About</h3>
|
||||
<div class="space-y-2 text-sm text-gray-400">
|
||||
<div>FeedBack <span id="app-version-about" class="text-gray-500"></span></div>
|
||||
<div>Licensed under <a id="about-license-link" href="https://github.com/got-feedback/feedBack/blob/main/LICENSE" target="_blank" rel="noopener" class="text-accent hover:text-accent-light underline">GNU AGPL v3.0</a>.</div>
|
||||
<div><a id="about-source-link" href="https://github.com/got-feedback/feedBack" target="_blank" rel="noopener" class="text-accent hover:text-accent-light underline">Source code repository</a></div>
|
||||
<p class="text-xs text-gray-600 mt-2">FeedBack is free software. You can redistribute it and modify it under the terms of the AGPL. If you run a modified version that interacts with users over a network, you must make the modified source available to those users.</p>
|
||||
<!-- ══ GRAPHICS ════════════════════════════════════════════════ -->
|
||||
<div class="fb-tabpanel" data-tab="graphics">
|
||||
<div class="fb-tabpanel-head"><h3>Graphics Settings</h3></div>
|
||||
<!-- highway_3d (manifest settings.category="graphics") mounts here. -->
|
||||
<div id="plugin-settings-graphics" class="space-y-3"></div>
|
||||
<p class="fb-tabpanel-empty" data-empty-for="plugin-settings-graphics">No graphics plugins are installed.</p>
|
||||
</div>
|
||||
|
||||
<!-- ══ KEYBINDS ════════════════════════════════════════════════ -->
|
||||
<div class="fb-tabpanel" data-tab="keybinds">
|
||||
<div class="fb-tabpanel-head"><h3>Keyboard Shortcuts</h3></div>
|
||||
<!-- Populated by settings.js from the live shortcut registry. -->
|
||||
<div id="settings-keybinds"></div>
|
||||
</div>
|
||||
|
||||
<!-- ══ PROGRESSION ═════════════════════════════════════════════ -->
|
||||
<div class="fb-tabpanel" data-tab="progression">
|
||||
<div class="fb-tabpanel-head"><h3>Progression Settings</h3></div>
|
||||
<div id="plugin-settings-progression" class="space-y-3"></div>
|
||||
<p class="fb-tabpanel-empty" data-empty-for="plugin-settings-progression">No progression plugins are installed.</p>
|
||||
</div>
|
||||
|
||||
<!-- ══ MIC ═════════════════════════════════════════════════════ -->
|
||||
<div class="fb-tabpanel" data-tab="mic">
|
||||
<div class="fb-tabpanel-head"><h3>Microphone & Detection</h3></div>
|
||||
<div id="plugin-settings-mic" class="space-y-3"></div>
|
||||
<p class="fb-tabpanel-empty" data-empty-for="plugin-settings-mic">No microphone/detection plugins are installed.</p>
|
||||
</div>
|
||||
|
||||
<!-- ══ PLUGINS (fallback for uncategorized panels) ═════════════ -->
|
||||
<div class="fb-tabpanel" data-tab="plugins">
|
||||
<div class="fb-tabpanel-head"><h3>Plugins</h3></div>
|
||||
<div class="fb-srows">
|
||||
<div class="fb-srow fb-srow-stack">
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Plugin updates</div>
|
||||
<div class="fb-srow-desc">Check installed plugins for newer versions.</div>
|
||||
</div>
|
||||
<div class="fb-srow-control" style="justify-content:flex-start;">
|
||||
<button onclick="checkPluginUpdates()" id="btn-check-updates" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Check for Updates</button>
|
||||
<span id="updates-status" class="text-xs text-gray-500"></span>
|
||||
</div>
|
||||
<div id="plugin-updates-list" class="space-y-2 fb-srow-wide"></div>
|
||||
</div>
|
||||
</section>
|
||||
</div>
|
||||
<!-- Per-plugin collapsible sections injected here (uncategorized). -->
|
||||
<div id="plugin-settings" class="space-y-3" style="margin-top:.6rem;"></div>
|
||||
</div>
|
||||
|
||||
<!-- ══ SYSTEM ══════════════════════════════════════════════════ -->
|
||||
<div class="fb-tabpanel" data-tab="system">
|
||||
<div class="fb-tabpanel-head"><h3>System</h3></div>
|
||||
<div class="fb-srows">
|
||||
<!-- App Updates — desktop-only; setupAppUpdates() unhides. -->
|
||||
<div id="app-updates-block" class="hidden fb-srow fb-srow-stack">
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">App updates</div>
|
||||
<div class="fb-srow-desc">Velopack auto-update channel for the desktop app.</div>
|
||||
</div>
|
||||
<div class="fb-srow-control" style="flex-wrap:wrap;">
|
||||
<select id="app-update-channel"
|
||||
class="bg-dark-700 border border-gray-800 rounded-xl px-3 py-2.5 text-sm text-gray-300 outline-none">
|
||||
<option value="stable">Stable</option>
|
||||
<option value="rc">Release candidate</option>
|
||||
<option value="beta">Beta</option>
|
||||
<option value="alpha">Alpha</option>
|
||||
</select>
|
||||
<button id="app-update-check-now"
|
||||
class="bg-accent hover:bg-accent-light px-4 py-2.5 rounded-xl text-sm font-medium text-white transition disabled:opacity-50">
|
||||
Check for updates
|
||||
</button>
|
||||
</div>
|
||||
<p id="app-update-status" class="text-xs text-gray-500 fb-srow-wide">Loading updater status…</p>
|
||||
<p id="app-update-linux-note" class="hidden text-xs text-yellow-300 fb-srow-wide">
|
||||
Auto-update is not available on Linux —
|
||||
<a href="https://github.com/got-feedback/feedback-desktop/releases" target="_blank" rel="noopener" class="text-accent hover:text-accent-light underline">download new versions from GitHub Releases</a>.
|
||||
</p>
|
||||
</div>
|
||||
<!-- Library folder path -->
|
||||
<div class="fb-srow fb-srow-stack">
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Library folder path</div>
|
||||
<div class="fb-srow-desc">The folder fee[dB]ack scans for your song library.</div>
|
||||
</div>
|
||||
<div class="fb-srow-control">
|
||||
<input type="text" id="dlc-path" placeholder="/path/to/your/library"
|
||||
class="bg-dark-700 border border-gray-800 rounded-xl px-4 py-2.5 text-sm text-gray-300 placeholder-gray-600 focus:border-accent/50 outline-none">
|
||||
<button onclick="pickDlcFolder()" id="btn-pick-dlc" class="hidden bg-dark-600 hover:bg-dark-500 px-4 py-2.5 rounded-xl text-sm text-gray-300 transition whitespace-nowrap">📂 Browse</button>
|
||||
<button onclick="saveSettings()" class="bg-accent hover:bg-accent-light px-6 py-2.5 rounded-xl text-sm font-semibold text-white transition">Save</button>
|
||||
</div>
|
||||
</div>
|
||||
<!-- Library rescan -->
|
||||
<div class="fb-srow fb-srow-stack">
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Library</div>
|
||||
<div class="fb-srow-desc">Rescan checks for new songs. Full Rescan clears the cache and re-imports everything.</div>
|
||||
</div>
|
||||
<div class="fb-srow-control">
|
||||
<button onclick="rescanLibrary()" id="btn-rescan" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Rescan Library</button>
|
||||
<button onclick="fullRescanLibrary()" id="btn-full-rescan" class="bg-dark-600 hover:bg-red-900/30 px-5 py-2.5 rounded-xl text-sm text-gray-400 transition">Full Rescan</button>
|
||||
<span id="rescan-status" class="text-xs text-gray-500"></span>
|
||||
</div>
|
||||
</div>
|
||||
<!-- Backup -->
|
||||
<div class="fb-srow fb-srow-stack">
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Backup</div>
|
||||
<div class="fb-srow-desc">Export bundles server config, browser preferences, and opted-in plugin data into one JSON file. Import overwrites current settings and reloads.</div>
|
||||
</div>
|
||||
<div class="fb-srow-control">
|
||||
<button onclick="exportSettings()" id="btn-export-settings" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Export Settings</button>
|
||||
<button onclick="document.getElementById('import-settings-file').click()" id="btn-import-settings" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Import Settings</button>
|
||||
<input type="file" id="import-settings-file" accept="application/json,.json" class="hidden" onchange="importSettings(this.files[0]); this.value=''">
|
||||
<span id="backup-status" class="text-xs text-gray-500"></span>
|
||||
</div>
|
||||
</div>
|
||||
<!-- Diagnostics -->
|
||||
<div class="fb-srow fb-srow-stack">
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">Diagnostics</div>
|
||||
<div class="fb-srow-desc">Bundles server logs, hardware info, plugin inventory, and the browser console transcript into one zip for bug reports. Redaction strips DLC paths, song filenames, and IP addresses by default.</div>
|
||||
</div>
|
||||
<div class="grid grid-cols-2 gap-2 mb-1 text-xs text-gray-400 fb-srow-wide">
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-incl-system" checked class="rounded border-gray-600 bg-dark-700 text-accent"> System info</label>
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-incl-hardware" checked class="rounded border-gray-600 bg-dark-700 text-accent"> Hardware (CPU/GPU/RAM)</label>
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-incl-logs" checked class="rounded border-gray-600 bg-dark-700 text-accent"> Server logs (last 5 MB)</label>
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-incl-console" checked class="rounded border-gray-600 bg-dark-700 text-accent"> Browser console + errors</label>
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-incl-plugins" checked class="rounded border-gray-600 bg-dark-700 text-accent"> Plugin diagnostics</label>
|
||||
<label class="flex items-center gap-2"><input type="checkbox" id="diag-redact" checked class="rounded border-gray-600 bg-dark-700 text-accent"> Redact paths & song names</label>
|
||||
</div>
|
||||
<div class="fb-srow-control">
|
||||
<button onclick="previewDiagnostics()" id="btn-diag-preview" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Preview Bundle</button>
|
||||
<button onclick="exportDiagnostics()" id="btn-diag-export" class="bg-dark-600 hover:bg-dark-500 px-5 py-2.5 rounded-xl text-sm text-gray-300 transition">Export Diagnostics</button>
|
||||
<span id="diag-status" class="text-xs text-gray-500"></span>
|
||||
</div>
|
||||
<div id="diag-preview" class="hidden mt-1 bg-dark-700 border border-gray-800 rounded-xl p-3 text-xs text-gray-400 max-h-96 overflow-auto fb-srow-wide"></div>
|
||||
</div>
|
||||
<!-- About -->
|
||||
<div class="fb-srow fb-srow-stack">
|
||||
<div class="fb-srow-main">
|
||||
<div class="fb-srow-title">About</div>
|
||||
<div class="fb-srow-desc">
|
||||
fee[dB]ack <span id="app-version-about" class="text-gray-500"></span> · Licensed under
|
||||
<a id="about-license-link" href="https://github.com/got-feedback/feedback/blob/main/LICENSE" target="_blank" rel="noopener" class="text-accent hover:text-accent-light underline">GNU AGPL v3.0</a> ·
|
||||
<a id="about-source-link" href="https://github.com/got-feedback/feedback" target="_blank" rel="noopener" class="text-accent hover:text-accent-light underline">Source code repository</a>.
|
||||
Free software — if you run a modified version that interacts with users over a network, you must make the modified source available to those users.
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
<div id="settings-status" class="text-sm text-gray-500"></div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
@@ -900,6 +1071,7 @@
|
||||
<script src="/static/v3/songs.js"></script>
|
||||
<script src="/static/v3/lessons.js"></script>
|
||||
<script src="/static/v3/dashboard.js"></script>
|
||||
<script src="/static/v3/settings.js"></script>
|
||||
<!-- First-run home tour: spotlights the home cards via the shared tour
|
||||
engine (tour-engine.js, loaded above). Auto-runs once after onboarding
|
||||
(triggered from profile.js finish()); replayable from the "?" menu. -->
|
||||
|
||||
@@ -0,0 +1,208 @@
|
||||
// ════════════════════════════════════════════════════════════════════════
|
||||
// v3 tabbed settings page — behaviour layer (feat/v3-settings-tabbed)
|
||||
//
|
||||
// The markup (tab bar, card rows, per-tab plugin mount containers) lives
|
||||
// statically in static/v3/index.html so the element ids exist before app.js's
|
||||
// loadSettings() hydrates them. This module owns the *behaviour*:
|
||||
// • tab switching + active-tab persistence (localStorage 'v3-settings-tab')
|
||||
// • the per-category "Reset" button(s)
|
||||
// • the read-only Keybinds reference (from window.getAllShortcuts())
|
||||
// • empty-state notes for plugin tabs with no installed plugins
|
||||
//
|
||||
// It is a plain non-module script (matches the rest of static/v3/*). All
|
||||
// reads are null-guarded so it no-ops gracefully on the classic v2 page (which
|
||||
// ships its own settings markup and never creates #settings-tabbar).
|
||||
// ════════════════════════════════════════════════════════════════════════
|
||||
(function () {
|
||||
'use strict';
|
||||
|
||||
var TAB_KEY = 'v3-settings-tab';
|
||||
var DEFAULT_TAB = 'gameplay';
|
||||
|
||||
// Per-category reset descriptors. `server` keys are cleared via
|
||||
// POST /api/settings/reset (so the next GET falls back to defaults);
|
||||
// `local` keys are client-only localStorage prefs; `after` re-applies any
|
||||
// live-object default that won't pick itself back up from a cleared key.
|
||||
// Only tabs with a [data-reset] button in the markup need an entry — today
|
||||
// that's Gameplay; others can be added alongside a button later.
|
||||
var RESET_MAP = {
|
||||
gameplay: {
|
||||
server: ['master_difficulty', 'av_offset_ms', 'miss_penalty',
|
||||
'fail_behavior', 'countdown_before_song', 'default_arrangement'],
|
||||
local: ['lefty', 'autoplayExit', 'arrangementNamingMode', 'countdownBeforeSong'],
|
||||
after: function () {
|
||||
// Left-handed is held on the highway object, not re-derived
|
||||
// from localStorage on load — flip it back to the default.
|
||||
try { if (window.highway && window.highway.setLefty) window.highway.setLefty(false); } catch (_) { /* noop */ }
|
||||
},
|
||||
},
|
||||
};
|
||||
|
||||
function esc(s) {
|
||||
return String(s == null ? '' : s)
|
||||
.replace(/&/g, '&').replace(/</g, '<').replace(/>/g, '>');
|
||||
}
|
||||
|
||||
// ── Tab switching ────────────────────────────────────────────────────
|
||||
function knownTabs() {
|
||||
var out = [];
|
||||
document.querySelectorAll('#settings-tabbar .fb-tab').forEach(function (b) {
|
||||
if (b.dataset.tab) out.push(b.dataset.tab);
|
||||
});
|
||||
return out;
|
||||
}
|
||||
|
||||
function activateTab(tab) {
|
||||
var tabs = knownTabs();
|
||||
if (tabs.indexOf(tab) === -1) tab = tabs.length ? tabs[0] : DEFAULT_TAB;
|
||||
document.querySelectorAll('#settings-tabbar .fb-tab').forEach(function (b) {
|
||||
b.classList.toggle('active', b.dataset.tab === tab);
|
||||
});
|
||||
document.querySelectorAll('#settings .fb-tabpanel').forEach(function (p) {
|
||||
p.classList.toggle('active', p.dataset.tab === tab);
|
||||
});
|
||||
try { localStorage.setItem(TAB_KEY, tab); } catch (_) { /* private mode */ }
|
||||
}
|
||||
|
||||
function wireTabs() {
|
||||
var bar = document.getElementById('settings-tabbar');
|
||||
if (!bar || bar.dataset.wired === '1') return;
|
||||
bar.dataset.wired = '1';
|
||||
bar.addEventListener('click', function (e) {
|
||||
var btn = e.target.closest ? e.target.closest('.fb-tab') : null;
|
||||
if (btn && btn.dataset.tab) activateTab(btn.dataset.tab);
|
||||
});
|
||||
var saved = DEFAULT_TAB;
|
||||
try { saved = localStorage.getItem(TAB_KEY) || DEFAULT_TAB; } catch (_) { /* noop */ }
|
||||
activateTab(saved);
|
||||
}
|
||||
|
||||
// ── Per-category reset ────────────────────────────────────────────────
|
||||
function wireResets() {
|
||||
document.querySelectorAll('#settings [data-reset]').forEach(function (btn) {
|
||||
if (btn.dataset.wired === '1') return;
|
||||
btn.dataset.wired = '1';
|
||||
btn.addEventListener('click', function () { resetCategory(btn.dataset.reset); });
|
||||
});
|
||||
}
|
||||
|
||||
function resetCategory(cat) {
|
||||
var map = RESET_MAP[cat];
|
||||
if (!map) return;
|
||||
var confirmFn = (typeof window._confirmDialog === 'function')
|
||||
? window._confirmDialog({
|
||||
title: 'Reset ' + cat.charAt(0).toUpperCase() + cat.slice(1) + ' Settings',
|
||||
body: '<p class="text-sm text-gray-300">Restore these settings to their defaults? This can\'t be undone.</p>',
|
||||
confirmText: 'Reset', cancelText: 'Cancel', danger: true,
|
||||
})
|
||||
: Promise.resolve(window.confirm('Reset ' + cat + ' settings to defaults?'));
|
||||
confirmFn.then(function (ok) {
|
||||
if (!ok) return;
|
||||
var done = Promise.resolve();
|
||||
if (map.server && map.server.length) {
|
||||
done = fetch('/api/settings/reset', {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/json' },
|
||||
body: JSON.stringify({ keys: map.server }),
|
||||
}).catch(function () { /* best-effort */ });
|
||||
}
|
||||
done.then(function () {
|
||||
(map.local || []).forEach(function (k) {
|
||||
try { localStorage.removeItem(k); } catch (_) { /* noop */ }
|
||||
});
|
||||
if (typeof map.after === 'function') { try { map.after(); } catch (_) { /* noop */ } }
|
||||
// Re-hydrate every control from the now-default server + local state.
|
||||
if (typeof window.loadSettings === 'function') {
|
||||
try { window.loadSettings(); } catch (_) { /* noop */ }
|
||||
}
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
// ── Keybinds reference (read-only) ────────────────────────────────────
|
||||
var SCOPE_TITLES = {
|
||||
global: 'Global', player: 'Player', library: 'Library', settings: 'Settings',
|
||||
};
|
||||
function scopeTitle(scope) {
|
||||
if (SCOPE_TITLES[scope]) return SCOPE_TITLES[scope];
|
||||
if (scope && scope.indexOf('plugin-') === 0) return 'Plugin: ' + scope.slice(7);
|
||||
return scope || 'Other';
|
||||
}
|
||||
|
||||
function renderKeybinds() {
|
||||
var host = document.getElementById('settings-keybinds');
|
||||
if (!host) return;
|
||||
var list = [];
|
||||
try { if (typeof window.getAllShortcuts === 'function') list = window.getAllShortcuts() || []; } catch (_) { list = []; }
|
||||
if (!list.length) {
|
||||
host.innerHTML = '<p class="fb-tabpanel-empty">No keyboard shortcuts are registered yet.</p>';
|
||||
return;
|
||||
}
|
||||
// Group by scope, stable scope order with anything unknown last.
|
||||
var order = ['global', 'player', 'library', 'settings'];
|
||||
var groups = {};
|
||||
list.forEach(function (s) {
|
||||
(groups[s.scope] = groups[s.scope] || []).push(s);
|
||||
});
|
||||
var scopes = Object.keys(groups).sort(function (a, b) {
|
||||
var ia = order.indexOf(a), ib = order.indexOf(b);
|
||||
if (ia === -1) ia = order.length;
|
||||
if (ib === -1) ib = order.length;
|
||||
return ia - ib || a.localeCompare(b);
|
||||
});
|
||||
var html = '';
|
||||
scopes.forEach(function (scope) {
|
||||
html += '<div class="fb-kbd-group-title">' + esc(scopeTitle(scope)) + '</div>';
|
||||
html += '<div class="fb-srows">';
|
||||
groups[scope].forEach(function (s) {
|
||||
html += '<div class="fb-srow">'
|
||||
+ '<div class="fb-srow-main"><div class="fb-srow-title">' + esc(s.description || s.combo) + '</div></div>'
|
||||
+ '<div class="fb-srow-control"><span class="fb-kbd">' + esc(s.combo) + '</span></div>'
|
||||
+ '</div>';
|
||||
});
|
||||
html += '</div>';
|
||||
});
|
||||
html += '<p class="fb-settings-note">Remapping shortcuts is not yet supported.</p>';
|
||||
host.innerHTML = html;
|
||||
}
|
||||
|
||||
// ── Empty-state notes for plugin tabs ─────────────────────────────────
|
||||
function refreshEmptyStates() {
|
||||
document.querySelectorAll('#settings [data-empty-for]').forEach(function (note) {
|
||||
var target = document.getElementById(note.dataset.emptyFor);
|
||||
var empty = !target || target.children.length === 0;
|
||||
note.style.display = empty ? '' : 'none';
|
||||
});
|
||||
}
|
||||
|
||||
// ── Boot + refresh on settings entry ──────────────────────────────────
|
||||
function init() {
|
||||
if (!document.getElementById('settings-tabbar')) return; // not the v3 page
|
||||
wireTabs();
|
||||
wireResets();
|
||||
renderKeybinds();
|
||||
refreshEmptyStates();
|
||||
// Safety net for plugin-panel injection ordering: tell app.js the
|
||||
// settings containers exist now (it injects plugin <details> into the
|
||||
// per-category containers). Harmless if no listener is attached.
|
||||
try { document.dispatchEvent(new CustomEvent('v3:settings-rendered')); } catch (_) { /* noop */ }
|
||||
}
|
||||
|
||||
// Re-derive the dynamic bits whenever the user enters Settings: shortcuts
|
||||
// and plugin panels may have registered/mounted since the last visit.
|
||||
if (window.feedBack && typeof window.feedBack.on === 'function') {
|
||||
window.feedBack.on('screen:changed', function (e) {
|
||||
if (e && e.id === 'settings') {
|
||||
// Plugin panels (and shortcuts) may have mounted since the last
|
||||
// visit — re-derive the dynamic bits on every Settings entry.
|
||||
wireTabs(); wireResets(); renderKeybinds(); refreshEmptyStates();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
if (document.readyState === 'loading') {
|
||||
document.addEventListener('DOMContentLoaded', init, { once: true });
|
||||
} else {
|
||||
init();
|
||||
}
|
||||
})();
|
||||
@@ -968,3 +968,109 @@ body.font-display { font-family: Rubik, system-ui, sans-serif; }
|
||||
color: #ddd6fe; background: rgba(76, 29, 149, .6);
|
||||
border: 1px solid rgba(139, 92, 246, .4); border-radius: .3rem; padding: .04rem .28rem;
|
||||
}
|
||||
|
||||
/* ════════════════════════════════════════════════════════════════════════
|
||||
Tabbed settings page (v3) — feat/v3-settings-tabbed
|
||||
Card-row layout: leading icon + title/description + right-aligned control,
|
||||
grouped under a horizontal tab bar. Pure CSS (no Tailwind rebuild); colors
|
||||
mirror the fb-* design tokens so the page matches the rest of the v3 shell.
|
||||
════════════════════════════════════════════════════════════════════════ */
|
||||
#settings .fb-settings { max-width: 56rem; margin: 0 auto; padding: 6rem 1.5rem 4rem; }
|
||||
.fb-settings-back {
|
||||
display: inline-flex; align-items: center; gap: .25rem;
|
||||
font-size: .8rem; color: #94a3b8; background: none; border: none; cursor: pointer;
|
||||
padding: 0; margin-bottom: 1rem; transition: color .15s;
|
||||
}
|
||||
.fb-settings-back:hover { color: #f8fafc; }
|
||||
.fb-settings-back svg { width: 1rem; height: 1rem; }
|
||||
.fb-settings-title { font-size: 1.875rem; font-weight: 800; color: #f8fafc; }
|
||||
|
||||
/* Tab bar */
|
||||
.fb-tabbar {
|
||||
display: flex; flex-wrap: wrap; gap: .25rem;
|
||||
border-bottom: 1px solid rgba(51, 65, 85, .6);
|
||||
margin: 1.25rem 0 1.5rem;
|
||||
}
|
||||
.fb-tab {
|
||||
appearance: none; background: none; border: none; cursor: pointer;
|
||||
padding: .55rem .85rem; font-size: .85rem; font-weight: 600;
|
||||
color: #94a3b8; border-bottom: 2px solid transparent;
|
||||
margin-bottom: -1px; transition: color .15s, border-color .15s; white-space: nowrap;
|
||||
}
|
||||
.fb-tab:hover { color: #e2e8f0; }
|
||||
.fb-tab.active { color: #f8fafc; border-bottom-color: #0ea5e9; }
|
||||
|
||||
/* Panels */
|
||||
.fb-tabpanel { display: none; }
|
||||
.fb-tabpanel.active { display: block; }
|
||||
.fb-tabpanel-head { display: flex; align-items: center; justify-content: space-between; gap: 1rem; margin-bottom: 1rem; }
|
||||
.fb-tabpanel-head h3 { font-size: 1.1rem; font-weight: 700; color: #f8fafc; }
|
||||
|
||||
/* Card rows */
|
||||
.fb-srows { display: flex; flex-direction: column; gap: .6rem; }
|
||||
.fb-srow {
|
||||
display: flex; align-items: center; gap: 1rem;
|
||||
background: #1e293b; border: 1px solid rgba(51, 65, 85, .55);
|
||||
border-radius: .75rem; padding: .85rem 1rem;
|
||||
}
|
||||
.fb-srow-stack { flex-direction: column; align-items: stretch; gap: .65rem; }
|
||||
.fb-srow-icon {
|
||||
flex: none; width: 2.25rem; height: 2.25rem; border-radius: .6rem;
|
||||
display: flex; align-items: center; justify-content: center;
|
||||
background: rgba(14, 165, 233, .12); color: #38bdf8;
|
||||
}
|
||||
.fb-srow-icon svg { width: 1.15rem; height: 1.15rem; }
|
||||
.fb-srow-main { flex: 1 1 auto; min-width: 0; }
|
||||
.fb-srow-title { font-size: .9rem; font-weight: 600; color: #e2e8f0; display: flex; align-items: center; }
|
||||
.fb-srow-desc { font-size: .75rem; color: #94a3b8; margin-top: .15rem; }
|
||||
.fb-srow-control { flex: none; display: flex; align-items: center; gap: .5rem; }
|
||||
.fb-srow-control select,
|
||||
.fb-srow-control input[type="text"] { min-width: 11rem; }
|
||||
.fb-srow-stack .fb-srow-control { width: 100%; }
|
||||
.fb-srow-stack .fb-srow-control input[type="text"] { flex: 1 1 auto; min-width: 0; }
|
||||
.fb-srow-wide { width: 100%; }
|
||||
|
||||
/* Toggle switch */
|
||||
.fb-switch { position: relative; display: inline-block; width: 2.6rem; height: 1.5rem; flex: none; }
|
||||
.fb-switch input { position: absolute; opacity: 0; width: 0; height: 0; }
|
||||
.fb-switch .fb-switch-track {
|
||||
position: absolute; inset: 0; cursor: pointer;
|
||||
background: #334155; border-radius: 999px; transition: background .15s;
|
||||
}
|
||||
.fb-switch .fb-switch-track::before {
|
||||
content: ""; position: absolute; height: 1.1rem; width: 1.1rem; left: .2rem; top: .2rem;
|
||||
background: #f8fafc; border-radius: 50%; transition: transform .15s;
|
||||
}
|
||||
.fb-switch input:checked + .fb-switch-track { background: #0ea5e9; }
|
||||
.fb-switch input:checked + .fb-switch-track::before { transform: translateX(1.1rem); }
|
||||
.fb-switch input:focus-visible + .fb-switch-track { box-shadow: 0 0 0 2px rgba(56, 189, 248, .5); }
|
||||
|
||||
/* "Not yet active" stub badge */
|
||||
.fb-stub-note {
|
||||
font-size: .6rem; font-weight: 700; text-transform: uppercase; letter-spacing: .04em;
|
||||
color: #fde68a; background: rgba(234, 179, 8, .12);
|
||||
border-radius: 999px; padding: .1rem .45rem; margin-left: .5rem; white-space: nowrap;
|
||||
}
|
||||
|
||||
/* Per-category reset */
|
||||
.fb-reset-btn {
|
||||
display: inline-flex; align-items: center; gap: .35rem;
|
||||
font-size: .8rem; color: #94a3b8; background: none; border: none; cursor: pointer;
|
||||
padding: .35rem .5rem; border-radius: .5rem; transition: color .15s, background .15s;
|
||||
}
|
||||
.fb-reset-btn:hover { color: #fca5a5; background: rgba(239, 68, 68, .08); }
|
||||
.fb-reset-btn svg { width: .9rem; height: .9rem; }
|
||||
|
||||
/* Keybinds reference */
|
||||
.fb-kbd {
|
||||
display: inline-block; font-family: ui-monospace, SFMono-Regular, Menlo, monospace;
|
||||
font-size: .72rem; color: #e2e8f0; background: #0b1220;
|
||||
border: 1px solid rgba(51, 65, 85, .8); border-bottom-width: 2px;
|
||||
border-radius: .35rem; padding: .1rem .4rem; min-width: 1.4rem; text-align: center;
|
||||
}
|
||||
.fb-kbd-group-title {
|
||||
font-size: .7rem; font-weight: 700; text-transform: uppercase; letter-spacing: .06em;
|
||||
color: #94a3b8; margin: 1.25rem 0 .5rem;
|
||||
}
|
||||
.fb-settings-note { font-size: .75rem; color: #64748b; margin-top: 1rem; }
|
||||
.fb-tabpanel-empty { font-size: .8rem; color: #64748b; padding: .5rem 0; }
|
||||
|
||||
Reference in New Issue
Block a user