fix(highway): user-selectable scoreboard to stop duplicate HUDs

The highway showed two overlapping note-detection scoreboards at once: the core v3 live-performance HUD (#v3-live-performance-hud) and the note_detect plugin's own HUD (.nd-hud). Both auto-render off the same note:hit/note:miss events and neither suppressed the other. Add a Settings → Visualization "Scoreboard" selector (Streak / Detailed / Off, default Streak) backed by a single source of truth on <html data-scoreboard>. CSS shows exactly one: core (default) → core HUD; hide .nd-hud detailed → .nd-hud; hide the core HUD off → hide both CSS-based suppression keys the default off ":not(detailed):not(off)", so the correct HUD is right even before the pref script runs (no flash) and it robustly hides any .nd-hud regardless of how many note_detect instances load. Detection itself is untouched — only the duplicate scoreboard panel is hidden. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-08-11 19:29:33 +00:00 · 2026-06-19 20:56:38 +02:00
parent a7a93e9bef
commit 36aeea67ac
3 changed files with 72 additions and 0 deletions
@@ -0,0 +1,50 @@
+/*
+ * fee[dB]ack — highway scoreboard preference.
+ *
+ * The 3D/2D highway can show note-detection scoring two ways: the core v3
+ * live-performance HUD (#v3-live-performance-hud) and the note_detect plugin's
+ * own HUD (.nd-hud). Both auto-render off the same note:hit/note:miss events,
+ * so without a preference you get two overlapping scoreboards.
+ *
+ * This module is the single source of truth: it writes <html data-scoreboard>
+ * (core | detailed | off) and CSS in v3.css hides the non-selected HUD(s).
+ * Default is 'core'. The CSS keys the default off "not detailed and not off",
+ * so the right HUD is correct even before this script runs (no flash).
+ */
+(function () {
+    'use strict';
+
+    var KEY = 'highwayScoreboard';
+    var VALID = { core: 1, detailed: 1, off: 1 };
+
+    function read() {
+        var v = null;
+        try { v = localStorage.getItem(KEY); } catch (_e) { /* private mode */ }
+        return VALID[v] ? v : 'core';
+    }
+
+    function apply(v) {
+        if (document.documentElement) {
+            document.documentElement.setAttribute('data-scoreboard', v);
+        }
+    }
+
+    function setScoreboard(v) {
+        if (!VALID[v]) v = 'core';
+        try { localStorage.setItem(KEY, v); } catch (_e) { /* private mode */ }
+        apply(v);
+        var sel = document.getElementById('scoreboard-select');
+        if (sel && sel.value !== v) sel.value = v;
+    }
+
+    // Apply immediately so the correct HUD is set before the first note arrives.
+    apply(read());
+
+    // onchange="setScoreboard(this.value)" on the Settings select.
+    window.setScoreboard = setScoreboard;
+
+    document.addEventListener('DOMContentLoaded', function () {
+        var sel = document.getElementById('scoreboard-select');
+        if (sel) sel.value = read();
+    });
+})();