got-feedBack/feedBack
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack.git synced 2026-09-12 21:58:33 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

test(career): F2b — drive real closeBook() in in-flight-discard test (Creed closer)

Browse Source 
The previous test for closeBook() invalidating in-flight requests bumped
_ppBookGen directly via setBookGen instead of calling the production closeBook().
Deleting ++_ppBookGen from closeBook() left the test green — decoration.

Fix: expose closeBook via the __careerPassportTest seam and call it directly
in the test. Mutation proof (run before commit):
  - delete ++_ppBookGen from closeBook() → 1 fail (test RED)  ✓
  - restore → 14/14 pass (GREEN)  ✓

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01H2bM5jSbMskpdxm2CmuQVj
This commit is contained in:
byrongamatos
2026-09-03 18:34:02 +02:00
co-authored by Claude Sonnet 4.6
parent 1033de87ce
commit 2ae46fe754
2 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/career/screen.js
+1 -1
View File
@@ -1721,7 +1721,7 @@
getBookGen() { return _ppBookGen; }, getBookGen() { return _ppBookGen; },
setBookGen(g) { _ppBookGen = g; }, setBookGen(g) { _ppBookGen = g; },
getProposal() { return _ppGigProposal; }, getProposal() { return _ppGigProposal; },
bookGig, bookGig, closeBook,
}; };
if (document.readyState === 'loading') { if (document.readyState === 'loading') {
tests/js/career_gig_tuning.test.js
+11 -10
View File
@@ -307,9 +307,12 @@ describe('career-gig-tuning bookGig', () => {
}); });
test('F2: closeBook() invalidates in-flight request — overlay stays closed', async () => { test('F2: closeBook() invalidates in-flight request — overlay stays closed', async () => {
// Failure input: user opens poster, a booking request is in flight (pending), // Failure input: a booking request is in flight (pending fetch), then the user
// user closes the poster via closeBook. Without _ppBookGen increment in closeBook, // closes the poster via the REAL closeBook(). Without ++_ppBookGen in closeBook,
// the pending response resolves, repopulates _ppGigProposal, and reopens the overlay. // the pending response resolves and repopulates _ppGigProposal.
//
// Mutation proof: delete `++_ppBookGen` from closeBook() → test goes RED
// (proposal is non-null, assert fails). Restore → GREEN.
const ctx = makeBookCtx(); const ctx = makeBookCtx();
let resolvePending; let resolvePending;
ctx.fetch = () => new Promise(r => { resolvePending = r; }); ctx.fetch = () => new Promise(r => { resolvePending = r; });
@@ -318,17 +321,15 @@ describe('career-gig-tuning bookGig', () => {
vm.runInContext(`window.__careerPassportTest.setTuningPref('any');`, ctx); vm.runInContext(`window.__careerPassportTest.setTuningPref('any');`, ctx);
const pending = vm.runInContext(`window.__careerPassportTest.bookGig('rock');`, ctx); const pending = vm.runInContext(`window.__careerPassportTest.bookGig('rock');`, ctx);
// User closes the poster — must invalidate the in-flight request // User closes the poster — call the REAL closeBook() via the test seam
// closeBook() is not in the test seam; simulate by incrementing gen directly vm.runInContext(`window.__careerPassportTest.closeBook();`, ctx);
// (equivalent to what closeBook does with ++_ppBookGen)
vm.runInContext(`window.__careerPassportTest.setBookGen(window.__careerPassportTest.getBookGen() + 1);`, ctx);
// Now resolve the pending request with a valid payload // Now resolve the pending fetch with a valid payload
resolvePending({ ok: true, status: 200, json: async () => ({ songs: [{ filename: 'a.sloppak', tuning_name: 'E Standard' }], tuning_pref: 'any' }) }); resolvePending({ ok: true, status: 200, json: async () => ({ songs: [{ filename: 'a.sloppak', tuning_name: 'E Standard' }], tuning_pref: 'any' }) });
await pending; await pending;
// Proposal must remain null — the response was discarded // Proposal must remain null — closeBook() incremented _ppBookGen so response was discarded
const proposal = vm.runInContext(`window.__careerPassportTest.getProposal()`, ctx); const proposal = vm.runInContext(`window.__careerPassportTest.getProposal()`, ctx);
assert.equal(proposal, null, 'closeBook-invalidated request must not repopulate _ppGigProposal'); assert.equal(proposal, null, 'closeBook() must invalidate in-flight request via ++_ppBookGen');
}); });
}); });