refactor(h3d-carve-9): extract W-section (camera lerp) → src/camera.js

effectiveVfov + camUpdate (~192 lines) extracted from the screen.js IIFE
into a createCamera() ES-module factory in plugins/highway_3d/src/camera.js.
screen.js imports and destructures the return { effectiveVfov, camUpdate }.

DI surface (48 params): 22 plain constants, 11 getters, 5 getter+setter pairs,
5 fn-refs (DI-renamed: _freeCamFor→freeCamFor, _aspectPaneKey→aspectPaneKey,
_resolveTuneFor→resolveTuneFor, _aspectRegisterPane→aspectRegisterPane).
Peer ES imports at module level: computeBPM (geometry.js), _ssActive (utils.js).
Per-call write-backs: setCurX, setCurDist, setCurLookY, setTgtLookY,
setFretRowFitBoost (all write-backs confirmed by setter class-killer tests).

Test retargeting (54 tests across 4 files):
- highway_3d_wide_fov.test.js:   6 tests → cameraSrc; 4 regexes updated for
  DI-renamed fn refs (resolveTuneFor, aspectRegisterPane, aspectPaneKey/getPaneUid)
- highway_3d_camera_framing.test.js: 5 tests → cameraSrc; getTgtDist() regex fix
- highway_3d_camera_bootstrap.test.js: extractFn retargeted to cameraSrc;
  getTgtX() ordering-check fix; 2 new setter class-killers added (setCurX,
  setFretRowFitBoost)
- highway_3d_lefty.test.js: shoulder-offset test → cameraSrc + getLeftyCached()
- highway_3d_panel_controls.test.js: createCamera stub added

Bite proofs:
- Gut effectiveVfov in camera.js → wide_fov not ok 4 (RED) ✓
- Gut camUpdate body (H_NEAR lerp) → framing not ok 3 (RED) ✓
- Gut camUpdate body (curX+=) → bootstrap not ok 11 (RED) ✓
- Sever setCurX → bootstrap not ok 12 (RED) ✓
- Sever setFretRowFitBoost → bootstrap not ok 13 (RED) ✓

Suite: 1271/1273 pass; 2 pre-existing failures unchanged from cut-8 baseline
(#46 analyser fallback, #591 nut-labels — both in flight before cut 9).

plugin.json: 3.44.0 → 3.45.0

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014uZ169yfoFYArXz962g7KW

tests/js/highway_3d_wide_fov.test.js

@@ -21,7 +21,9 @@ const fs = require('node:fs');
 const path = require('node:path');
 
 const SCREEN_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'screen.js');
+const CAMERA_JS = path.join(__dirname, '..', '..', 'plugins', 'highway_3d', 'src', 'camera.js'); // h3d-carve-9
 const src = fs.readFileSync(SCREEN_JS, 'utf8');
+const cameraSrc = fs.readFileSync(CAMERA_JS, 'utf8'); // h3d-carve-9: effectiveVfov/camUpdate moved here
 
 // ── Constants ────────────────────────────────────────────────────────────────
 
@@ -53,16 +55,18 @@ test('the Hor+ start-aspect and min-vfov defaults exist', () => {
 test('effectiveVfov returns the base fov when the bridge is off/absent', () => {
     // The disabled / malformed-input guard returns `base` before any Hor+ math,
     // so normal panes are unaffected when __h3dAspectTune is missing or off.
+    // h3d-carve-9: effectiveVfov moved to src/camera.js — retarget to cameraSrc.
     assert.match(
-        src,
+        cameraSrc,
         /function\s+effectiveVfov\s*\(\s*aspect\s*,\s*tune\s*\)\s*\{[\s\S]*?if\s*\(\s*!tune\s*\|\|\s*!tune\.enabled[\s\S]*?return\s+base\s*;/,
         'effectiveVfov must short-circuit to the base fov when disabled',
     );
 });
 
 test('effectiveVfov is a no-op at/under the start aspect', () => {
+    // h3d-carve-9: effectiveVfov moved to src/camera.js — retarget to cameraSrc.
     assert.match(
-        src,
+        cameraSrc,
         /if\s*\(\s*aspect\s*<=\s*start\s*\)\s*return\s+base\s*;/,
         'effectiveVfov must return base when aspect <= start (no-op for normal/2x2 panes)',
     );
@@ -121,10 +125,11 @@ test('applySize caches the pane aspect for camUpdate', () => {
 });
 
 test('camUpdate resolves a per-pane tune and respects splitOnly', () => {
+    // h3d-carve-9: camUpdate moved to src/camera.js; resolveTuneFor is DI-renamed.
     assert.match(
-        src,
-        /const\s+_aspTune\s*=\s*_resolveTuneFor\(\s*_paneKey\s*\)\s*;[\s\S]*?_aspTune\.splitOnly\s*&&\s*!_ssActive\(\)/,
-        'camUpdate must resolve the tune per pane via _resolveTuneFor(_paneKey) and gate splitOnly',
+        cameraSrc,
+        /const\s+_aspTune\s*=\s*resolveTuneFor\(\s*_paneKey\s*\)\s*;[\s\S]*?_aspTune\.splitOnly\s*&&\s*!_ssActive\(\)/,
+        'camUpdate must resolve the tune per pane via resolveTuneFor(_paneKey) and gate splitOnly',
     );
 });
 
@@ -170,7 +175,8 @@ test('a Target select and pane registry drive the per-pane picker', () => {
         'the panel must build a Target <select>');
     assert.match(src, /function\s+_aspectRegisterPane\s*\(/,
         '_aspectRegisterPane must record live panes for the picker');
-    assert.match(src, /if\s*\(\s*window\.__h3dAspectPanelOpen\s*\)\s*_aspectRegisterPane\(\s*_paneKey\s*\)/,
+    // h3d-carve-9: camUpdate moved to camera.js; fn-ref DI-renamed (no underscore).
+    assert.match(cameraSrc, /if\s*\(\s*window\.__h3dAspectPanelOpen\s*\)\s*aspectRegisterPane\(\s*_paneKey\s*\)/,
         'camUpdate must register its pane only while the tuner panel is open');
 });
 
@@ -183,9 +189,11 @@ test('panes are keyed by arrangement (stable across songs, no split-API dep)', (
         /function\s+_aspectPaneKey\s*\(\s*arrangement\s*,\s*uid\s*\)[\s\S]*?'arr:'\s*\+\s*a[\s\S]*?'pane:'\s*\+\s*uid/,
         '_aspectPaneKey must prefer arr:<name> and fall back to pane:<uid>',
     );
+    // h3d-carve-9: camUpdate moved to camera.js; fn-ref DI-renamed (no underscore),
+    // _paneUid replaced by getPaneUid() accessor call.
     assert.match(
-        src,
-        /const\s+_paneKey\s*=\s*_aspectPaneKey\(\s*[\s\S]*?songInfo[\s\S]*?arrangement\s*,\s*_paneUid\s*\)\s*;/,
+        cameraSrc,
+        /const\s+_paneKey\s*=\s*aspectPaneKey\(\s*[\s\S]*?songInfo[\s\S]*?arrangement\s*,\s*getPaneUid\(\)\s*\)\s*;/,
         'camUpdate must key the pane by arrangement (with the uid fallback)',
     );
 });
@@ -286,8 +294,9 @@ test('the panel has a dismiss (close) control', () => {
 test('camUpdate only writes cam.fov when it actually changes', () => {
     // Guarding the write avoids a per-frame updateProjectionMatrix on a steady
     // pane and keeps the disabled path free.
+    // h3d-carve-9: camUpdate moved to src/camera.js — retarget to cameraSrc.
     assert.match(
-        src,
+        cameraSrc,
         /Math\.abs\(\s*_vfov\s*-\s*cam\.fov\s*\)\s*>\s*1e-4[\s\S]*?cam\.fov\s*=\s*_vfov\s*;[\s\S]*?cam\.updateProjectionMatrix\(\)/,
         'camUpdate must guard the cam.fov write behind a change check',
     );