feat(achievements): local engine + tabbed Profile shell (epic PR1) (#587)

mirror of https://github.com/got-feedBack/feedBack.git synced 2026-08-10 18:59:56 +00:00

Adds the Achievements & Feats of Power local engine, fully offline.

Core (static/v3/profile.js): the Profile screen becomes tabbed exactly
like v3 Settings (.fb-tabbar/.fb-tab/.fb-tabpanel, active tab persisted in
localStorage 'v3-profile-tab'). A Profile (main) tab carries the existing
cards + a Feats trophy-shelf mount (#v3-profile-feats-slot, earned-only),
and an Achievements tab carries a plugin mount
(#v3-profile-achievements-mount) + empty-state note. A new
`v3:profile-rendered` event fires after every render so the plugin
re-injects (mirrors v3:settings-rendered).

New bundled plugin (plugins/achievements/): SQLite engine
(unlocks/counters/comp_ledger/sync_queue) with pure threshold/criterion
math in the testable sibling engine.py (P-V); routes activity/
report-unlock/report-criterion/catalog/earned/feats/remove-me. Feats read
activity counters only (batched song:ended POST; notes only when notedetect
present — graceful degradation); competency Achievements evaluate from
progression events only — the integration law, never crossed. Catalogue is
always shown (locked=greyed), grouped by the real progression paths
(Global/Guitar/Bass/Drums/Keys, auto-extending) with per-category earned
badges. Versioned window.feedBack.achievements registration API with the
__feedBackAchievementsPending load-order queue + achievements:ready event.

Verified natively (uvicorn) end-to-end + Playwright (tabbar, earned-only
Feats shelf, greyed catalogue, registration API, zero console errors);
24 plugin tests pass incl. the integration-law assertion.

Opt-in/privacy/data-min gate (PR2) and the hosted wall (PR3) follow.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

This commit is contained in:

Byron Gamatos

2026-06-24 16:57:37 +02:00

committed by

GitHub

co-authored by

Claude Opus 4.8

parent 873ee3d5f2

commit 05dd3d227a

15 changed files with 1474 additions and 10 deletions

									
										plugins/achievements/settings.html
									
		+8
		
												View File
												
				@@ -0,0 +1,8 @@

				<!-- Achievements plugin settings panel. PR1 ships an informational stub; the

				     Privacy opt-in toggle + "Remove me from the wall" button land in PR2. -->

				<div class="text-sm text-gray-300 space-y-2">

				  <p>Your <strong>Achievements</strong> (skill milestones) and <strong>Feats of Power</strong>

				     (rare activity trophies) live on your <em>Profile</em> page. Everything here is

				     local and private.</p>

				  <p class="text-gray-400">Sharing Feats on the public wall is opt-in and arrives in a later update.</p>

				</div>