mirror of
https://github.com/got-feedBack/feedBack-desktop.git
synced 2026-08-11 11:19:24 +00:00
17f554c501
Three independent gaps currently break a from-scratch Linux build (and CI):
1. .build-config.json is missing `versions.dotnet`, yet both the devcontainer
Dockerfile (`dotnet-install.sh --channel ${DOTNET_VERSION}`) and the CI
workflows (`require('./.build-config.json').versions.dotnet` → setup-dotnet
`${dotnet}.x`) read it. Empty → the image build / setup-dotnet step fails.
Add `"dotnet": "8.0"` (Velopack's vpk targets .NET 8; "8.0" satisfies both
`--channel 8.0` and setup-dotnet's `8.0.x`). Keeps .NET available for
`vpk pack` on tagged release builds.
2. build-linux-docker.sh never forwards GH_CLONE_TOKEN or SLOPSMITH_REF into
the container, so a local `bash scripts/build-linux-docker.sh` can't clone
the private got-feedback core/plugins or select a core ref. Pass both
through (defaulting SLOPSMITH_REF to main).
3. The ffmpeg libvorbis guard pipes `ffmpeg | grep -wq`, which is racy under
`set -o pipefail`: grep -q closes the pipe on first match, ffmpeg takes
SIGPIPE (141), pipefail returns 141, and the guard false-fails even though
libvorbis is present (reproducible on Docker Desktop). Capture the encoder
list into a variable first, then grep.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
54 lines
2.7 KiB
JSON
54 lines
2.7 KiB
JSON
{
|
|
"versions": {
|
|
"node": "22",
|
|
"python": "3.12.9",
|
|
"electron": "35.0.0",
|
|
"cmake": "3.22",
|
|
"ubuntu": "22.04",
|
|
"dotnet": "8.0"
|
|
},
|
|
"external": {
|
|
"fluidsynth_windows": {
|
|
"version": "v2.5.4",
|
|
"url": "https://github.com/FluidSynth/fluidsynth/releases/download/v2.5.4/fluidsynth-v2.5.4-win10-x64-cpp11.zip"
|
|
},
|
|
"soundfont_general_user": {
|
|
"url": "https://github.com/got-feedback/feedback-soundfonts/releases/download/soundfonts-v1/GeneralUser-GS.sf2",
|
|
"sha256": "9575028c7a1f589f5770fccc8cff2734566af40cd26ed836944e9a5152688cfe"
|
|
},
|
|
"python_standalone_macos_arm64": {
|
|
"url": "https://github.com/astral-sh/python-build-standalone/releases/download/20250317/cpython-3.12.9+20250317-aarch64-apple-darwin-install_only_stripped.tar.gz",
|
|
"sha256": "0a4647b7df3c8eca11071d6cea68a14a4b102bd6fc6afae314e9852510654b7d"
|
|
},
|
|
"python_standalone_macos_x64": {
|
|
"url": "https://github.com/astral-sh/python-build-standalone/releases/download/20250317/cpython-3.12.9+20250317-x86_64-apple-darwin-install_only_stripped.tar.gz",
|
|
"sha256": "1a414bf392a7afe08c742502a82edd41893a1144ccbceb184dc5ee6ee9c069c0"
|
|
},
|
|
"python_standalone_linux_x64": {
|
|
"url": "https://github.com/astral-sh/python-build-standalone/releases/download/20250317/cpython-3.12.9+20250317-x86_64-unknown-linux-gnu-install_only_stripped.tar.gz",
|
|
"sha256": "a36bc60c38fe146e908e2e71fc21266c8558b24a9407226b1d887212839437ef"
|
|
},
|
|
"ffmpeg_macos_arm64": {
|
|
"url": "https://www.osxexperts.net/ffmpeg81arm.zip",
|
|
"sha256": "ebb82529562b71170807bbc6b0e7eb4f0b13af8cbb0e085bb9e8f6fe709598ad"
|
|
},
|
|
"ffprobe_macos_arm64": {
|
|
"url": "https://www.osxexperts.net/ffprobe81arm.zip",
|
|
"sha256": "a6640a77d38a6f0527c5b597e599cb36a3427a6931444ed80bc62542421950a1"
|
|
},
|
|
"ffmpeg_macos_x64": {
|
|
"url": "https://evermeet.cx/ffmpeg/ffmpeg-8.1.1.zip",
|
|
"sha256": "4610988e2f54c243c50da73a09e4e2c36d9bb77546f9aa6c84cb328dcb1a98c1"
|
|
},
|
|
"ffprobe_macos_x64": {
|
|
"url": "https://evermeet.cx/ffmpeg/ffprobe-8.1.1.zip",
|
|
"sha256": "aeade29dee3c3844e9bcc974f4ae4b29cc4f87994177d77003a8589fa531009e"
|
|
},
|
|
"ffmpeg_macos_rubberband": {
|
|
"_comment": "Intel ffmpeg with --enable-librubberband, bundled as resources/bin/ffmpeg-rubberband on Apple Silicon ONLY (runs via Rosetta 2). The native arm64 static builds (osxexperts/martin-riedl) omit librubberband, so Retune's pitch-shift step has no rubberband filter there. Used solely by lib/retune.py; all other ffmpeg use stays on the native arm64 binary. Same evermeet build as ffmpeg_macos_x64.",
|
|
"url": "https://evermeet.cx/ffmpeg/ffmpeg-8.1.1.zip",
|
|
"sha256": "4610988e2f54c243c50da73a09e4e2c36d9bb77546f9aa6c84cb328dcb1a98c1"
|
|
}
|
|
}
|
|
}
|