mirror of
https://github.com/got-feedBack/feedBack-desktop.git
synced 2026-07-23 05:11:43 +00:00
17f554c501
Three independent gaps currently break a from-scratch Linux build (and CI):
1. .build-config.json is missing `versions.dotnet`, yet both the devcontainer
Dockerfile (`dotnet-install.sh --channel ${DOTNET_VERSION}`) and the CI
workflows (`require('./.build-config.json').versions.dotnet` → setup-dotnet
`${dotnet}.x`) read it. Empty → the image build / setup-dotnet step fails.
Add `"dotnet": "8.0"` (Velopack's vpk targets .NET 8; "8.0" satisfies both
`--channel 8.0` and setup-dotnet's `8.0.x`). Keeps .NET available for
`vpk pack` on tagged release builds.
2. build-linux-docker.sh never forwards GH_CLONE_TOKEN or SLOPSMITH_REF into
the container, so a local `bash scripts/build-linux-docker.sh` can't clone
the private got-feedback core/plugins or select a core ref. Pass both
through (defaulting SLOPSMITH_REF to main).
3. The ffmpeg libvorbis guard pipes `ffmpeg | grep -wq`, which is racy under
`set -o pipefail`: grep -q closes the pipe on first match, ffmpeg takes
SIGPIPE (141), pipefail returns 141, and the guard false-fails even though
libvorbis is present (reproducible on Docker Desktop). Capture the encoder
list into a variable first, then grep.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| dev | ||
| BUILD_SCRIPTS.md | ||
| build-audio.sh | ||
| build-common.sh | ||
| build-linux-docker.sh | ||
| build-linux-ubuntu.sh | ||
| build-macos.sh | ||
| build-release.sh | ||
| build-windows.sh | ||
| bundle-binaries.sh | ||
| bundle-python.sh | ||
| bundle-slopsmith.sh | ||
| bundle-soundfont.sh | ||
| bundle.sh | ||
| bundled-lib-skiplist.sh | ||
| fix-onnxruntime-install-names.sh | ||
| parse-build-config.py | ||
| setup-dev.sh | ||
| sign-macos-binaries.sh | ||
| VST_TRACE_README.md | ||