mirror of
https://github.com/got-feedBack/feedBack-desktop.git
synced 2026-09-10 23:24:10 +00:00
fix/asio-device-lifecycle-message-thread
Review follow-up (PR #113, finding 1): ProbeDeviceOptions constructs and destroys short-lived ASIO device objects (DeviceSetup::probeDual / rateSupportedBy createDevice) on the Node thread - the same create/destroy-off-the-message-thread pattern as the lifecycle ops, and a probe ASIOAudioIODevice owns the same reset-timer machinery. Wrap it in runDeviceLifecycleOp for consistency. Finding 2 (timeout desync - op reported failed may still complete late) is documented as a known limitation on the helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Languages
C++
52%
TypeScript
18.6%
JavaScript
17.9%
Shell
7.3%
CMake
2.4%
Other
1.8%