mirror of
https://github.com/got-feedBack/feedBack-desktop.git
synced 2026-08-12 11:49:27 +00:00
fix(release): glob the win launcher exe (productName is sanitized to feedback.exe) (#69)
electron-builder strips the brackets from productName 'fee[dB]ack' → the win launcher is 'feedback.exe', so deriving --mainExe from raw productName ('fee[dB]ack.exe') didn't match. Glob release/win-unpacked/*.exe instead (single root exe), mirroring the mac .app glob. Confirmed via the fail-loud guard on the v0.3.0-alpha.1 build.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
e84f675dad
commit
cdbc88036b
@@ -320,13 +320,13 @@ jobs:
|
|||||||
shell: bash
|
shell: bash
|
||||||
run: |
|
run: |
|
||||||
set -euo pipefail
|
set -euo pipefail
|
||||||
# The launcher exe is named after productName (electron-builder
|
# The launcher exe is the electron-builder 'dir' output, whose name is
|
||||||
# 'dir' target), not the packId. Velopack otherwise looks for
|
# the SANITIZED productName (e.g. fee[dB]ack -> feedback.exe), not the
|
||||||
# <packId>.exe and fails. Derive it from package.json so a rebrand
|
# raw productName or the packId. Find it dynamically — there's a
|
||||||
# can't break the pack.
|
# single .exe at the win-unpacked root.
|
||||||
mainexe="$(node -p "require('./package.json').build.productName").exe"
|
mainexe=$(basename "$(ls release/win-unpacked/*.exe 2>/dev/null | head -n1)")
|
||||||
if [[ ! -f "release/win-unpacked/${mainexe}" ]]; then
|
if [[ -z "${mainexe:-}" ]]; then
|
||||||
echo "::error::Launcher release/win-unpacked/${mainexe} not found"; ls -1 release/win-unpacked/*.exe || true; exit 1
|
echo "::error::No .exe launcher in release/win-unpacked/"; ls -1 release/win-unpacked/ | head -20; exit 1
|
||||||
fi
|
fi
|
||||||
vpk pack \
|
vpk pack \
|
||||||
--packId Slopsmith \
|
--packId Slopsmith \
|
||||||
|
|||||||
Reference in New Issue
Block a user