got-feedBack/feedBack-desktop
1
0
Fork 0
mirror of https://github.com/got-feedBack/feedBack-desktop.git synced 2026-08-11 03:09:56 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(build): strip dangling symlinks so macOS builds aren't "damaged" (#30)

Browse Source 
A local macOS tester reported the DMG as "damaged and can't be opened."
Root cause: the bundled tree contained a dangling symlink — rig_builder
ships a build-time link `vst/src/racks/DPF` -> DISTRHO framework that isn't
present at runtime. A broken symlink is harmless on Linux/squashfs (the
AppImage was fine), but on macOS it:
  - breaks codesign — `spctl` reports "a sealed resource is missing or
    invalid", which Gatekeeper surfaces as "damaged"; and
  - breaks `xattr -dr com.apple.quarantine` — it aborts on the dangling
    link, so even the quarantine-removal workaround can't complete.

Strip dangling symlinks from the cloned core+plugins tree after bundling
(safe on every platform — they're broken/unused). Verified on-device:
after removal + ad-hoc re-sign the app verifies clean and launches once
quarantine is cleared.

Also fix build-macos.sh's artifact check, which still globbed the
pre-rebrand `Slopsmith.app` and falsely reported "No artifacts found" for
the now `feedback.app` bundle.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Byron Gamatos
2026-06-21 08:19:59 +02:00
committed by GitHub
co-authored by Claude Opus 4.8
parent cb1915f745
commit 7b7a5b59da
2 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/build-common.sh
+14
View File
@@ -198,6 +198,20 @@ clone_slopsmith() {
fi
done
# Strip dangling symlinks from the bundled tree. Some plugins ship
# build-time symlinks into sources that aren't present at runtime (e.g.
# rig_builder's vst/src/racks/DPF -> DISTRHO framework). A broken symlink
# is harmless on Linux/squashfs, but on macOS it BREAKS codesign ("a
# sealed resource is missing or invalid" -> the app reads as "damaged")
# AND breaks `xattr -dr com.apple.quarantine` (it aborts on the dangling
# link, so the quarantine-removal workaround can't complete). Remove them.
local _dangling
_dangling=$(find "$clone_dir" -type l ! -exec test -e {} \; -print 2>/dev/null | wc -l | tr -d ' ')
if [[ "${_dangling:-0}" != "0" ]]; then
find "$clone_dir" -type l ! -exec test -e {} \; -delete 2>/dev/null || true
echo "Stripped ${_dangling} dangling symlink(s) from the bundled tree (macOS codesign safety)"
fi
export SLOPSMITH_DIR="$clone_dir"
echo "Cloned ${cloned} of ${total} plugins"
cd - >/dev/null
scripts/build-macos.sh
+5 -4
View File
@@ -153,11 +153,12 @@ bundle_python_impl() {
# Platform-specific: Return expected artifact patterns
get_expected_artifacts() {
# mac.target is "dir": electron-builder writes the unpacked
# Slopsmith.app to release/mac-arm64/ (no .dmg/.zip). Velopack's
# <productName>.app to release/mac-arm64/ (no .dmg/.zip). Velopack's
# pack step turns that .app into the actual release assets. Glob
# mac*/ so the check also passes for an x64 (mac/) or universal
# (mac-universal/) local build — verify_artifacts expands this.
printf "%s\n" "$PROJECT_DIR/release/mac*/Slopsmith.app"
# mac*/*.app so the check matches the productName-derived bundle name
# (now feedback.app, not the pre-rebrand Slopsmith.app) and also passes
# for an x64 (mac/) or universal (mac-universal/) local build.
printf "%s\n" "$PROJECT_DIR/release/mac*/*.app"
}
# Platform-specific: Bundle system binaries