mirror of
https://github.com/got-feedBack/feedBack-desktop.git
synced 2026-08-11 03:09:56 +00:00
fix(build): bundle Rig Builder by its current repo name, not the pre-rename redirect (#59)
The bundled-plugin list cloned got-feedback/rig_builder, a name two renames behind the current feedBack-plugin-rig-builder. That works only via GitHub's rename redirect, which silently breaks the moment any new repo takes the old name — a nightly would then bundle the wrong code without failing. Point at the canonical repo with an explicit :rig_builder dirname (capital B means the lowercase feedback-plugin- prefix strip doesn't apply), which keeps the bundled module name byte-identical. The other lowercase feedback-plugin-* entries are deliberately untouched: GitHub repo names are case-insensitively unique, so a case-only mismatch can never be shadowed or break, and canonicalizing them would force a case-insensitive rewrite of the prefix strip (risky on the macOS build host's bash 3.2) for zero functional gain. Claude-Session: https://claude.ai/code/session_01H1ZBEcZoJinde9ms5fAjwc Co-authored-by: ChrisBeWithYou <chris@rifflarr.local> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
ChrisBeWithYou
Claude Fable 5
parent
dcfa6be19d
commit
1524e349cb
@@ -163,8 +163,12 @@ clone_slopsmith() {
|
||||
got-feedback/feedback-plugin-tutorials
|
||||
got-feedback/feedback-plugin-update-manager
|
||||
got-feedback/feedback-plugin-virtuoso
|
||||
# Rig Builder (NAM tone builder) — repo is not under the feedback-plugin-* prefix.
|
||||
got-feedback/rig_builder
|
||||
# Rig Builder (NAM tone builder) — the repo was renamed
|
||||
# feedBack-plugin-rig-builder (capital B, so the lowercase prefix
|
||||
# strip doesn't apply; explicit dirname instead). The old
|
||||
# `got-feedback/rig_builder` name only worked via a GitHub rename
|
||||
# redirect, which silently breaks if a new repo ever takes that name.
|
||||
got-feedback/feedBack-plugin-rig-builder:rig_builder
|
||||
)
|
||||
|
||||
local total=0
|
||||
|
||||
Reference in New Issue
Block a user