H3cJP/yuzu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vi: Don't let uninitialized data pass as a response for SetBufferCount

Browse Source 
Currently SetBufferCount doesn't write to the out buffer which then contains uninitialized data. This leads to non-zero data which leads to responding with different error codes
This commit is contained in:
David Marcec 2020-04-24 17:16:39 +10:00
parent 8f548266cd
commit 03a6f3b0f4
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/core/hle/service/vi/vi.cpp
View File

@ -267,7 +267,7 @@ protected:
private: private:
struct Data { struct Data {
u32_le unk_0; u32_le unk_0{};
}; };
Data data{}; Data data{};
@ -614,6 +614,14 @@ private:
ctx.WriteBuffer(response.Serialize()); ctx.WriteBuffer(response.Serialize());
break; break;
} }
case TransactionId::SetBufferCount: {
LOG_WARNING(Service_VI, "(STUBBED) called, transaction=SetBufferCount");
[[maybe_unused]] const auto buffer = ctx.ReadBuffer();
IGBPEmptyResponseParcel response{};
ctx.WriteBuffer(response.Serialize());
break;
}
default: default:
ASSERT_MSG(false, "Unimplemented"); ASSERT_MSG(false, "Unimplemented");
} }