mirror of
https://git.ryujinx.app/ryubing/ryujinx.git
synced 2025-09-07 09:24:40 +00:00
f91cd05260
Unmerged PR from OG Ryujinx (#4367). From @gdkchan: > The main goal of this change is porting the loop filtering from libvpx, which should fix the block artifacts on some VP9 videos on games using NVDEC to decode them. In addition to that, there are two other changes: > > - The remaining decoder code required to decode a VP9 video (with headers included) has been added. That was done because it's much better to test the decoder standalone with a video file. I decided to keep that code on the emulator, even if some of it is unused, since it makes standalone testing easier in the future too, and we can include unit tests with video files. > - Large refactoring of both new and existing code to conform with our conding [sic] styles, done by @TSRBerry (thanks!) Some of it has been automated. > > Since we had no loop filtering before, this change will make video decoding slower. That may cause frame drop etc if the decoder is not fast enough in some games. I plan to optimize the decoder more in the future to make up for that, but if possible I'd prefer to not do it as part of this PR, but if the perf loss is too severe I might consider. > > This will need to be tested on games that had the block artifacts, it would be nice to confirm if they match hardware now, and get some before/after screenshots etc. Comment from @Bjorn29512: > Significantly improves the block artifacts in FE: Engage. > > Before: >  > > After: >  --------- Co-authored-by: gdkchan <gab.dark.100@gmail.com> Co-authored-by: TSR Berry <20988865+TSRBerry@users.noreply.github.com>
75 lines
2.3 KiB
C#
75 lines
2.3 KiB
C#
namespace Ryujinx.Graphics.Nvdec.Vp9
|
|
{
|
|
internal enum CodecErr
|
|
{
|
|
/// <summary>
|
|
/// Operation completed without error
|
|
/// </summary>
|
|
Ok,
|
|
|
|
/// <summary>
|
|
/// Unspecified error
|
|
/// </summary>
|
|
Error,
|
|
|
|
/// <summary>
|
|
/// Memory operation failed
|
|
/// </summary>
|
|
MemError,
|
|
|
|
/// <summary>
|
|
/// ABI version mismatch
|
|
/// </summary>
|
|
AbiMismatch,
|
|
|
|
/// <summary>
|
|
/// Algorithm does not have required capability
|
|
/// </summary>
|
|
Incapable,
|
|
|
|
/// <summary>
|
|
/// The given bitstream is not supported.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// The bitstream was unable to be parsed at the highest level.<br/>
|
|
/// The decoder is unable to proceed.<br/>
|
|
/// This error SHOULD be treated as fatal to the stream.
|
|
/// </remarks>
|
|
UnsupBitstream,
|
|
|
|
/// <summary>
|
|
/// Encoded bitstream uses an unsupported feature
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// The decoder does not implement a feature required by the encoder.<br/>
|
|
/// This return code should only be used for features that prevent future
|
|
/// pictures from being properly decoded.<br/>
|
|
/// <br/>
|
|
/// This error MAY be treated as fatal to the stream or MAY be treated as fatal to the current GOP.
|
|
/// </remarks>
|
|
UnsupFeature,
|
|
|
|
/// <summary>
|
|
/// The coded data for this stream is corrupt or incomplete.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// There was a problem decoding the current frame.<br/>
|
|
/// This return code should only be used
|
|
/// for failures that prevent future pictures from being properly decoded.<br/>
|
|
/// <br/>
|
|
/// This error MAY be treated as fatal to the stream or MAY be treated as fatal to the current GOP.<br/>
|
|
/// If decoding is continued for the current GOP, artifacts may be present.
|
|
/// </remarks>
|
|
CorruptFrame,
|
|
|
|
/// <summary>
|
|
/// An application-supplied parameter is not valid.
|
|
/// </summary>
|
|
InvalidParam,
|
|
|
|
/// <summary>
|
|
/// An iterator reached the end of list.
|
|
/// </summary>
|
|
ListEnd
|
|
}
|
|
} |