H3cJP/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-19 13:47:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove disabled commands, clarify rebuild

dreamsyntax 2024-06-19 02:08:15 +00:00
parent 24dd6603c9
commit b65fe1865e
1 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
About-Dolphin's-CI-Bot.md

@ -6,19 +6,7 @@
* Updates PR status based on the CI builds/tests results. * Updates PR status based on the CI builds/tests results.
* Show updates about GitHub activity on Dolphin's IRC channel. * Show updates about GitHub activity on Dolphin's IRC channel.
* Shows updates about outstanding [issues](https://bugs.dolphin-emu.org/projects/emulator) on Dolphin's IRC channel. * Shows updates about outstanding [issues](https://bugs.dolphin-emu.org/projects/emulator) on Dolphin's IRC channel.
* Provides a way for Dolphin maintainers to allow a PR author to merge their PR by themselves.
## Reverse PR Approval Workflow ## Triggering Rebuilds and Building of a PR from an Untrusted Developer
One of the recent additions to @dolphin-emu-bot's features is the ability to make a PR mergeable by its author. The idea behind this feature is to reduce PR review latency by pre-allowing a PR to be merged before it's completely ready. For example, if an otherwise good PR has a typo in documentation, the repo maintainer can comment on this typo asking for a fix, and pre-allow the merge so that the PR author can merge the change themselves after the fix has been applied. A trusted member can comment `@dolphin-emu-bot rebuild` as a comment in the PR to be built/rebuilt. Thoroughly review that the PR does not contain malicious code that might get executed on Dolphin's CI infrastructure before running this command.
Two commands can be used by Dolphin maintainers in PR comments:
* `@dolphin-emu-bot allowmerge` in a comment will show a link that allows the PR author to merge their change.
* `@dolphin-emu-bot disallowmerge` can be used to override that decision in a later comment.
The last of these two commands in PR comments will determine the status of the PR (author mergeable or not). Default status is, obviously, unmergeable.
## Triggering Rebuilds of a PR from an Untrusted Developer
Just use the `@dolphin-emu-bot rebuild` command in a PR comment. Be careful that the PR does not contain anything dodgy that might get executed on Dolphin's CI infrastructure.