mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-11-27 03:45:39 +00:00
2ed61b0ee1
We (the Microsoft C++ team) use the dolphin project as part of our "Real world code" tests. I noticed a few issues in windows specific code when building dolphin with the MSVC compiler in its conformance mode (/permissive-). For more information on /permissive- see our blog https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/. These changes are to address 3 different types of issues: 1) Use of qualified names in member declarations struct A { void A::f() { } // error C4596: illegal qualified name in member declaration // remove redundant 'A::' to fix }; 2) Binding a non-const reference to a temporary struct S{}; // If arg is in 'in' parameter, then it should be made const. void func(S& arg){} int main() { //error C2664: 'void func(S &)': cannot convert argument 1 from 'S' to 'S &' //note: A non-const reference may only be bound to an lvalue func( S() ); //Work around this by creating a local, and using it to call the function S s; func( s ); } 3) Add missing #include <intrin.h> Because of the workaround you are using in the code you will need to include this. This is because of changes in the libraries and not /permissive- |
||
|---|---|---|
| .. | ||
| BoundingBox.cpp | ||
| BoundingBox.h | ||
| CMakeLists.txt | ||
| D3D.vcxproj | ||
| D3D.vcxproj.filters | ||
| D3DBase.cpp | ||
| D3DBase.h | ||
| D3DBlob.cpp | ||
| D3DBlob.h | ||
| D3DShader.cpp | ||
| D3DShader.h | ||
| D3DState.cpp | ||
| D3DState.h | ||
| D3DTexture.cpp | ||
| D3DTexture.h | ||
| D3DUtil.cpp | ||
| D3DUtil.h | ||
| FramebufferManager.cpp | ||
| FramebufferManager.h | ||
| GeometryShaderCache.cpp | ||
| GeometryShaderCache.h | ||
| main.cpp | ||
| NativeVertexFormat.cpp | ||
| PerfQuery.cpp | ||
| PerfQuery.h | ||
| PixelShaderCache.cpp | ||
| PixelShaderCache.h | ||
| PSTextureEncoder.cpp | ||
| PSTextureEncoder.h | ||
| Render.cpp | ||
| Render.h | ||
| Television.cpp | ||
| Television.h | ||
| TextureCache.cpp | ||
| TextureCache.h | ||
| TextureEncoder.h | ||
| VertexManager.cpp | ||
| VertexManager.h | ||
| VertexShaderCache.cpp | ||
| VertexShaderCache.h | ||
| VideoBackend.h | ||
| XFBEncoder.cpp | ||
| XFBEncoder.h | ||