mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2026-03-19 11:53:04 +00:00
If Dolphin crashes, changes that have been made to settings are often lost. This has been a minor annoyance for me when developing, but it has become a much bigger issue recently due to the problem where Dolphin freezes on shutdown for ROG Ally users. Instead of saving the config when certain arbitrary settings are changed, let's save the config when the user closes the settings window.
218 lines
7.3 KiB
C++
218 lines
7.3 KiB
C++
// Copyright 2016 Dolphin Emulator Project
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
#include "DolphinQt/Config/SettingsWindow.h"
|
|
|
|
#include <utility>
|
|
|
|
#include <QApplication>
|
|
#include <QColor>
|
|
#include <QDialogButtonBox>
|
|
#include <QEvent>
|
|
#include <QHBoxLayout>
|
|
#include <QListWidget>
|
|
#include <QPalette>
|
|
#include <QStackedWidget>
|
|
#include <QTabWidget>
|
|
#include <QVBoxLayout>
|
|
|
|
#include "DolphinQt/Config/ControllersPane.h"
|
|
#include "DolphinQt/Config/Graphics/GraphicsPane.h"
|
|
#include "DolphinQt/MainWindow.h"
|
|
#include "DolphinQt/QtUtils/QtUtils.h"
|
|
#include "DolphinQt/QtUtils/WrapInScrollArea.h"
|
|
#include "DolphinQt/Settings.h"
|
|
#include "DolphinQt/Settings/AdvancedPane.h"
|
|
#include "DolphinQt/Settings/AudioPane.h"
|
|
#include "DolphinQt/Settings/GameCubePane.h"
|
|
#include "DolphinQt/Settings/GeneralPane.h"
|
|
#include "DolphinQt/Settings/InterfacePane.h"
|
|
#include "DolphinQt/Settings/OnScreenDisplayPane.h"
|
|
#include "DolphinQt/Settings/PathPane.h"
|
|
#include "DolphinQt/Settings/TriforcePane.h"
|
|
#include "DolphinQt/Settings/WiiPane.h"
|
|
|
|
StackedSettingsWindow::StackedSettingsWindow(QWidget* parent) : QDialog{parent}
|
|
{
|
|
// This eliminates the ugly line between the title bar and window contents with KDE Plasma.
|
|
setStyleSheet(QStringLiteral("QDialog { border: none; }"));
|
|
|
|
auto* const layout = new QHBoxLayout{this};
|
|
|
|
// Calculated value for the padding in our list items.
|
|
const int list_item_padding = layout->contentsMargins().left() / 2;
|
|
|
|
// Eliminate padding around layouts.
|
|
layout->setContentsMargins(QMargins{});
|
|
layout->setSpacing(0);
|
|
|
|
m_navigation_list = new QListWidget;
|
|
|
|
// Ensure list doesn't grow horizontally and is not resized smaller than its contents.
|
|
m_navigation_list->setSizePolicy(QSizePolicy::Fixed, QSizePolicy::Minimum);
|
|
m_navigation_list->setSizeAdjustPolicy(QAbstractScrollArea::AdjustToContents);
|
|
|
|
// FYI: "base" is the window color on Windows and "alternate-base" is very high contrast on macOS.
|
|
const auto* const list_background =
|
|
#if !defined(__APPLE__)
|
|
"palette(alternate-base)";
|
|
#else
|
|
"palette(base)";
|
|
#endif
|
|
|
|
m_navigation_list->setStyleSheet(
|
|
QString::fromUtf8(
|
|
// Remove border around entire widget and adjust background color.
|
|
"QListWidget { border: 0; background: %1; } "
|
|
// Note: padding-left is broken unless border is set, which then breaks colors.
|
|
// see: https://bugreports.qt.io/browse/QTBUG-122698
|
|
"QListWidget::item { padding-top: %2px; padding-bottom: %2px; } "
|
|
// Maintain selected item color when unfocused.
|
|
"QListWidget::item:selected { background: palette(highlight); "
|
|
// Prevent text color change on focus loss.
|
|
"color: palette(highlighted-text); "
|
|
"} "
|
|
// Remove ugly dotted outline on selected row (Windows and GNOME).
|
|
"* { outline: none; } ")
|
|
.arg(QString::fromUtf8(list_background))
|
|
.arg(list_item_padding));
|
|
|
|
UpdateNavigationListStyle();
|
|
|
|
layout->addWidget(m_navigation_list);
|
|
|
|
auto* const right_side = new QVBoxLayout;
|
|
layout->addLayout(right_side);
|
|
|
|
m_stacked_panes = new QStackedWidget;
|
|
|
|
right_side->addWidget(m_stacked_panes);
|
|
|
|
// The QFrame gives us some padding around the button.
|
|
auto* const button_frame = new QFrame;
|
|
auto* const button_layout = new QGridLayout{button_frame};
|
|
auto* const button_box = new QDialogButtonBox(QDialogButtonBox::Close);
|
|
right_side->addWidget(button_frame);
|
|
button_layout->addWidget(button_box);
|
|
|
|
connect(button_box, &QDialogButtonBox::rejected, this, &QDialog::reject);
|
|
|
|
connect(m_navigation_list, &QListWidget::currentRowChanged, m_stacked_panes,
|
|
&QStackedWidget::setCurrentIndex);
|
|
}
|
|
|
|
void StackedSettingsWindow::OnDoneCreatingPanes()
|
|
{
|
|
// Make sure the first item is actually selected by default.
|
|
ActivatePane(0);
|
|
// Take on the preferred size.
|
|
QtUtils::AdjustSizeWithinScreen(this);
|
|
}
|
|
|
|
void StackedSettingsWindow::changeEvent(QEvent* event)
|
|
{
|
|
QDialog::changeEvent(event);
|
|
|
|
const auto type = event->type();
|
|
|
|
const bool palette_changed = type == QEvent::PaletteChange;
|
|
const bool application_palette_changed = type == QEvent::ApplicationPaletteChange;
|
|
const bool style_changed = type == QEvent::StyleChange;
|
|
const bool theme_event = type == QEvent::ThemeChange;
|
|
|
|
const bool theme_changed = application_palette_changed || theme_event;
|
|
|
|
if (theme_changed && !m_handling_theme_change)
|
|
{
|
|
m_handling_theme_change = true;
|
|
Settings::Instance().ApplyStyle();
|
|
// Ensure the dialog and its children adopt the new system palette.
|
|
setPalette(qApp->palette());
|
|
Settings::Instance().TriggerThemeChanged();
|
|
m_handling_theme_change = false;
|
|
}
|
|
|
|
if (palette_changed || application_palette_changed || style_changed || theme_event)
|
|
UpdateNavigationListStyle();
|
|
}
|
|
|
|
void StackedSettingsWindow::UpdateNavigationListStyle()
|
|
{
|
|
if (!m_navigation_list)
|
|
return;
|
|
|
|
QPalette list_palette = m_navigation_list->palette();
|
|
const QPalette app_palette = qApp->palette();
|
|
|
|
QColor highlight_color = app_palette.color(QPalette::Active, QPalette::Highlight);
|
|
QColor highlighted_text = app_palette.color(QPalette::Active, QPalette::HighlightedText);
|
|
|
|
#if defined(__APPLE__)
|
|
const bool is_dark_theme = Settings::Instance().IsThemeDark();
|
|
// The default macOS accent is quite light in our list; darken it for readability in light mode.
|
|
if (!is_dark_theme)
|
|
{
|
|
highlight_color = highlight_color.darker(130);
|
|
highlighted_text = QColor(Qt::white);
|
|
}
|
|
#endif
|
|
|
|
for (const QPalette::ColorGroup group : {QPalette::Active, QPalette::Inactive})
|
|
{
|
|
list_palette.setColor(group, QPalette::Base, app_palette.color(group, QPalette::Base));
|
|
list_palette.setColor(group, QPalette::AlternateBase,
|
|
app_palette.color(group, QPalette::AlternateBase));
|
|
list_palette.setColor(group, QPalette::Highlight, highlight_color);
|
|
list_palette.setColor(group, QPalette::HighlightedText, highlighted_text);
|
|
}
|
|
|
|
m_navigation_list->setPalette(list_palette);
|
|
}
|
|
|
|
void StackedSettingsWindow::AddPane(QWidget* widget, const QString& name)
|
|
{
|
|
m_stacked_panes->addWidget(widget);
|
|
// Pad the left and right of each item.
|
|
m_navigation_list->addItem(QStringLiteral(" %1 ").arg(name));
|
|
}
|
|
|
|
void StackedSettingsWindow::AddWrappedPane(QWidget* widget, const QString& name)
|
|
{
|
|
AddPane(GetWrappedWidget(widget), name);
|
|
}
|
|
|
|
void StackedSettingsWindow::ActivatePane(int index)
|
|
{
|
|
m_navigation_list->setCurrentRow(index);
|
|
}
|
|
|
|
SettingsWindow::SettingsWindow(MainWindow* parent) : StackedSettingsWindow{parent}
|
|
{
|
|
setWindowTitle(tr("Settings"));
|
|
|
|
// If you change the order, don't forget to update the SettingsWindowPaneIndex enum.
|
|
AddWrappedPane(new GeneralPane, tr("General"));
|
|
AddPane(new GraphicsPane{parent, nullptr}, tr("Graphics"));
|
|
AddWrappedPane(new ControllersPane, tr("Controllers"));
|
|
AddWrappedPane(new InterfacePane, tr("Interface"));
|
|
AddWrappedPane(new OnScreenDisplayPane, tr("On-Screen Display"));
|
|
AddWrappedPane(new AudioPane, tr("Audio"));
|
|
AddWrappedPane(new PathPane, tr("Paths"));
|
|
AddWrappedPane(new GameCubePane{parent}, tr("GameCube"));
|
|
AddWrappedPane(new WiiPane, tr("Wii"));
|
|
AddWrappedPane(new TriforcePane, tr("Triforce"));
|
|
AddWrappedPane(new AdvancedPane, tr("Advanced"));
|
|
|
|
OnDoneCreatingPanes();
|
|
}
|
|
|
|
void SettingsWindow::SelectPane(SettingsWindowPaneIndex index)
|
|
{
|
|
ActivatePane(std::to_underlying(index));
|
|
}
|
|
|
|
void SettingsWindow::closeEvent(QCloseEvent*)
|
|
{
|
|
Config::Save();
|
|
}
|