H3cJP/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-17 20:58:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
43,785 Commits 10 Branches 16 Tags 1.6 GiB
release-prep-2506
Commit Graph

5256 Commits

Author SHA1 Message Date
Lioncash
2b2ee61e79 CustomShaderCache: Resolve -Wreorder warnings 
Lays out the initializer lists to be in the same order that
initialization would occur in.
 2023-12-11 16:59:03 -05:00
Lioncash
d90537cc18 AchievementManager: Return by reference from GetLock() 
This makes the API a little nicer to use, since you don't need to do
a mandatory dereference when passing the lock into any kind of scope
guard.
 2023-12-11 13:51:50 -05:00
Lioncash
e55f9ed102 AchievementManager: Make GetInstance() return a reference 
The internal static member will always have a valid lifetime. Makes this
consistent with other instance based objects in our code.
 2023-12-11 13:36:39 -05:00
iwubcode
3658d3bffe VideoCommon: add ability to serialize graphics mod to json object 2023-12-10 18:29:21 -06:00
iwubcode
ac862b04ab VideoBackends / VideoCommon: update max pixel shader samplers from 8 to 16, this allows us to support more samplers than the native Wii/GC 2023-12-10 18:14:02 -06:00
iwubcode
02756be381 VideoCommon: prevent a potential custom texture crash that can occur when a shared_ptr gets released while a pointer to its member data is still being used 2023-12-09 23:43:40 -06:00
Lioncash
0df7908025 VideoCommon/Present: Remove use of g_presenter inside Presenter class 
There's no need to self reference a global of the class itself when we
can just call the function directly.
 2023-12-09 20:15:32 -05:00
Lioncash
5f6c76af51 VideoCommon: Use std::span for BoundingBox::Write() 
Crosses off a lingering TODO.

Also amends a few nearby cases where a u32 cast was being repromoted to
size_t.
 2023-12-09 16:33:21 -05:00
LillyJadeKatrin
e992225b88 Bugfix - small square in bottom right corner 
Fixed a bug in OSUI created by the challenge icons that caused a small rectangle to appear in the bottom right corner of the screen.
 2023-12-08 00:33:29 -05:00
LillyJadeKatrin
caa729f84a Display Active Challenges On Screen 
The active challenges, aka the primed achievements, are displayed on screen as a series of icons in the bottom right corner of the screen via OnScreenUI.
 2023-12-07 16:02:15 -05:00
iwubcode
e204b3c8ee VideoCommon: add additional data types (int, int2, float, bool, etc) as properties of materials and some helper functions to support sending the data to the GPU 2023-12-04 00:12:31 -06:00
Pokechu22
69cf8b3470 VertexLoader: Use Common::SmallVector 2023-12-02 15:54:52 -08:00
Pokechu22
4116344785 VertexLoader: Remove unnecessary calls to VertexLoader_TextCoord::GetDummyFunction 2023-12-02 15:54:52 -08:00
Pokechu22
36796abc08 VertexLoader: Fix wrong array being used if color 1 is present but color 0 isn't 
This worked correctly on the JIT vertex loaders, and for the equivalent case with texture coordinates. I'm not aware of any games this affects (but libogc does mention a semi-related scenario at 6bc0317c7d/gc/ogc/gx.h (L1855-L1857).)
 2023-12-02 15:54:52 -08:00
Pokechu22
1ee6824324 VertexLoaderTest: Add test for skipped texture coordinates 
Jimmie Johnson's Anything with an Engine is known to use texture coordinate 7 (and only texture coordinate 7) in some cases. There are a lot of possible edge-cases, so this test brute-forces all combinations with coordinates 0, 1, and 2.
 2023-12-02 15:54:52 -08:00
Zopolis4
f0d2ce4683
Remove _M_X86 in favour of _M_X86_64 2023-11-28 23:03:20 +11:00
Mai
731013c316
Merge pull request #12263 from Dentomologist/realtime_cheatsearch_update 
CheatSearch: Automatically update Current Values
 2023-11-28 04:17:06 +01:00
Tilka
b8a897fda7
Merge pull request #12328 from iwubcode/xf_state_manager 
VideoCommon: move xf state management to its own class
 2023-11-28 02:04:26 +00:00
iwubcode
fb86c6342e VideoCommon: move texture dump function out of texture cache to its own free function so it can be used elsewhere. Doing this change may also slightly improve performance of this operation 2023-11-26 16:35:03 -06:00
iwubcode
849a0c13b5 VideoCommon: move xf state management to its own class, so changes can be detected in places other than VertexShaderManager 2023-11-26 16:27:26 -06:00
JosJuice
3d5f95b298
Merge pull request #12297 from Filoppi/improve_paper_white 
Change HDR paper white default to 203 to match the ITU recommendations
 2023-11-26 18:03:39 +01:00
Lioncash
04011373f3 CustomAssetLibrary: Remove unnecessary qualifier in LoadInfo 
The type is already in visible scope, so we don't need the rather length
qualifier.
 2023-11-25 18:01:44 -05:00
Lioncash
b85902ccb5 CustomAssetLibrary: Add virtual destructor 
This is used as a base pointer inside CustomPipelineAction, so this
should probably really have a virtual destructor to ensure derived
objects are torn down properly.
 2023-11-25 18:01:17 -05:00
Filoppi
a8fd938a06 Change paper white default to 203 to match the ITU 2023-11-14 20:21:34 +02:00
Pokechu22
3984d1964b Fix accidental fallthrough in BPStructs 
This caused us to update the indirect texture information in shaders more often than we needed to, which probably doesn't matter in practice since it's only used in ubershaders and copyyscale and stride are generally only updated before EFB/XFB copies, which generally will have other changes afterwards.
 2023-11-12 10:39:56 -08:00
Tilka
e7b922ee62
Merge pull request #12286 from Pokechu22/more-bp-register-descriptions 
Add descriptions for more BP registers
 2023-11-12 07:59:32 +00:00
Pokechu22
da8407e01c Add descriptions for more BP registers 2023-11-11 23:32:17 -08:00
Pokechu22
dfdb9a4a07 Clarify per-texture tmem information in the fifo analyzer 2023-11-11 23:32:17 -08:00
Pokechu22
ea41d0e384 Convert BPMEM_LOADTLUT1 to a struct 2023-11-11 23:32:17 -08:00
Pokechu22
2a1d445b30 Enhance description of BPMEM_PRELOAD_MODE in the fifo analyzer 2023-11-11 23:32:17 -08:00
Pokechu22
6bad17b170 Rename bpmem.copyMipMapStrideChannels to bpmem.copyDestStride 
As far as I can tell, it has nothing to do with the mipmap/half_scale functionality, but does change based on the width of the destination texture (and the destination texture is half the width if half_scale is set). The comment that was there (which dates back to the initial megacommit) seems to not have accounted for the width aspect; it was first used as an actual stride in bbbe898839 (the first commit that used it at all).
 2023-11-11 23:32:14 -08:00
Tillmann Karras
ac9079f2ca VideoCommon: copy software renderer logic for blend mode priorities 
I've not tested this on hardware, but it fixes issue 12271 (shadow
people in Deal or No Deal - Special Edition).
 2023-11-12 05:51:28 +00:00
Pokechu22
9543555bfe Fix typo in comment for bpmem.texcoords 2023-11-11 16:13:37 -08:00
Dentomologist
fdb7328c73 CheatSearch: Update Current Values at end of frame 
At the end of each frame automatically update the Current Value for
visible table rows in the selected and visible CheatSearchWidget (if
any). Also update all Current Values in all CheatSearchWidgets when the
State changes to Paused.

Only updating visible table rows serves to minimize the performance cost
of this feature. If the user scrolls to an un-updated cell it will
promptly be updated by either the next VIEndFieldEvent or the State
transitioning to Paused.
 2023-10-31 17:34:31 -07:00
JosJuice
899d61bc7d Jit64: Recompile asm routines on cache clear 
This is needed so that the checks added in the previous commit will be
reevaluated if the value of m_enable_dcache changes.

JitArm64 was already recompiling its asm routines on cache clear by
necessity. It doesn't have the same setup as Jit64 where the asm
routines are in a separate region, so clearing the JitArm64 cache
results in the asm routines being cleared too.
 2023-10-31 19:43:49 +01:00
Tilka
2212a5b225
Merge pull request #12254 from AdmiralCurtiss/savestate-no-xfb-stride 
VideoCommon: Don't swap on state load when there's no XFB.
 2023-10-28 02:14:30 +01:00
Admiral H. Curtiss
4f0c8b1657
VideoCommon: Don't swap on state load when there's no XFB. 
This triggers an assert in TCacheEntry::SetXfbCopy() otherwise if you load a savestate that was made before the first XFB has been rendered.
 2023-10-25 18:24:42 +02:00
TellowKrinkle
323aea60d6 VideoCommon: Fix VS point/line on older GLSL 2023-10-24 23:18:01 -05:00
Admiral H. Curtiss
cb13ad7a5f
VideoCommon: Add support for icons in OSD messages. 2023-10-17 02:47:29 +02:00
iwubcode
b292022bc7 VideoCommon: use ToLower function in assets when parsing json, for proper locale independent behavior 2023-10-16 19:23:00 -05:00
iwubcode
fec2a8af8c VideoCommon: add additional properties to ShaderAsset to support custom shader uniforms 2023-10-16 19:02:27 -05:00
Admiral H. Curtiss
2677fd9a8e
Merge pull request #12185 from iwubcode/custom_shader_uniform_backend_support 
VideoBackends / VideoCommon: add support for custom shader uniforms to D3D, Vulkan, OGL
 2023-10-15 00:21:56 +02:00
iwubcode
b251194a7e VideoCommon: wait for the GPU to be finished doing any work before invalidating pipelines when graphic config changes 2023-10-10 18:17:24 -05:00
iwubcode
0e8f8ea930 VideoCommon: instead of using 'CustomTextureData' directly, use 'TextureData' for texture assets, this allows us to provide additional metadata for textures. Such as a sampler or type information (to distinguish cube maps) 2023-10-10 09:58:14 -05:00
iwubcode
a099f4f41b VideoCommon: given the changes to pipeline interaction, update the global version variable to reflect those changes and force pipelines to be rebuilt 2023-10-06 02:17:43 -05:00
iwubcode
b6d321bfb1 VideoBackends / VideoCommon: add new uniform buffer object for custom shader materials (slot 3, geometry shader buffer moves to slot 4 if available) 2023-10-06 02:17:42 -05:00
iwubcode
92accc3ef7 VideoCommon: add custom pixel shader constants as a buffer of data to be passed to all backends 2023-10-05 21:20:16 -05:00
Patrick Ferry
9e950c6959 Use Vertex Depth Range when zRange Exceeds farZ 
When the inverted depth range is unsupported and zRange is greater than farZ then min_depth becomes a negative value and far_depth will then exceed a depth of 1.0 (which is outside the scope of most backends and greater than GX_MAX_DEPTH of the console).

This happens when the backend supports depth clamping the min_depth is not clamped to zero.
 2023-09-28 04:17:56 +01:00
get
63467559b2
fmt 10.0.0-10.1.1 compile fixes 
Implicit conversion operators and enums was removed for parity with std::format (fce74caa15).
 2023-09-21 01:19:23 +02:00
Admiral H. Curtiss
1a821465f4
Merge pull request #12166 from iwubcode/cubemap_shader_texture_integration 
VideoCommon: add cubemap to ShaderAsset and TextureAsset
 2023-09-12 16:56:26 +02:00
Jordan Woyak
7cc4304918 VideoCommon: Expose the widescreen heuristic's standard and widescreen ratio values in onion config. 2023-09-06 18:45:28 -05:00
iwubcode
589834f562 VideoCommon: add cubemap as a sampler target for shaders, add cubemap as a valid texture asset 2023-09-05 21:11:19 -05:00
JMC47
76a00551d1
Merge pull request #11419 from OatmealDome/widescreen 
VideoCommon: Allow widescreen heuristic's constants to be overridden by onion config
 2023-09-05 13:25:07 -04:00
OatmealDome
4938b99600 VertexManagerBase: Allow widecreen heuristic constants to be overriden by onion config 2023-09-05 11:50:49 -04:00
OatmealDome
de781a6fa7 RenderBase: Allow widescreen heuristic's transition threshold to be overridden by onion config 2023-09-05 11:49:22 -04:00
JMC47
9419d92446
Merge pull request #12139 from iwubcode/more_shader_texture_properties 
VideoCommon: add additional texture sampler types to ShaderAsset
 2023-09-04 22:45:56 -04:00
JMC47
82ea4f4c70
Merge pull request #12137 from iwubcode/custom_pipeline_more_error_checking 
VideoCommon: additional error checking for CustomPipelineAction
 2023-09-04 22:43:41 -04:00
JMC47
627282473b
Merge pull request #12136 from iwubcode/texture_metadata_struct 
VideoCommon: add TextureData structure with metadata
 2023-09-04 22:40:50 -04:00
JMC47
900439ea0d
Merge pull request #12102 from iwubcode/cubemap_custom_texture 
VideoCommon: add ability to load cube maps into custom texture data
 2023-09-03 18:29:00 -04:00
Sketch
fb852a5062 VideoCommon: Deinit Graphics Mod Manager implicitly 2023-09-03 16:06:08 -04:00
Admiral H. Curtiss
46a596c0d3
Merge pull request #12148 from Dentomologist/fifo_convert_memoryupdate_type_to_enum_class 
Fifo: Convert MemoryUpdate::Type to enum class
 2023-09-03 03:34:35 +02:00
iwubcode
62fee2f3b6 VideoCommon: add loading cube maps from DDS files and loading it into our custom texture object. Custom texture object now has the concept of slices in addition to levels. Traditional custom textures have a single slice 2023-09-02 20:20:09 -05:00
Dentomologist
9cabf20aaa Fifo: Convert MemoryUpdate::Type to enum class 2023-09-02 18:19:26 -07:00
Dentomologist
d5d3eb5025 TextureCacheBase: Add m_ prefix to member variables 2023-09-01 22:52:17 -07:00
Admiral H. Curtiss
69db8a615f
Merge pull request #12145 from JosJuice/ubershaderpixel-uint 
VideoCommon: Fix GLSL uint handling in UberShaderPixel
 2023-08-29 12:33:54 +02:00
Admiral H. Curtiss
df120b0630
Merge pull request #12000 from Filoppi/window_res_fix 
Video: Fix issues with the window presentation
 2023-08-28 23:50:50 +02:00
JosJuice
5b112dbf2c VideoCommon: Fix GLSL uint handling in UberShaderPixel 2023-08-28 21:17:01 +02:00
iwubcode
f982c556b5 VideoCommon: add additional texture sampler types to ShaderAsset 2023-08-26 12:12:37 -05:00
Admiral H. Curtiss
2502e412b3
Merge pull request #12117 from JosJuice/config-callback-cpu 
Don't call RunAsCPUThread in config callbacks
 2023-08-26 16:34:46 +02:00
Admiral H. Curtiss
5c4671f573
Merge pull request #12126 from JosJuice/small-vector 
Move SmallVector to Common
 2023-08-26 14:15:18 +02:00
iwubcode
9223540bf4 VideoCommon: additional error checking for CustomPipelineAction and move the pixel shader asset cache time back to being calculated during texture creation 2023-08-24 00:47:48 -05:00
iwubcode
7c52a52440 VideoCommon: add TextureData structure that contains the raw texture data, a sampler, and the type of texture information 2023-08-24 00:35:31 -05:00
JosJuice
ba99d17ac0 VideoCommon: Fix custom shader constants on GLES 2023-08-22 19:38:18 +02:00
JosJuice
6e88c44d5d Move SmallVector to Common 
We had one implementation of this type of data structure in Arm64Emitter
and one in VideoCommon. This moves the Arm64Emitter implementation to
its own file and adds begin and end functions to it, so that VideoCommon
can use it.

You may notice that the license header for the new file is CC0. I wrote
the Arm64Emitter implementation of SmallVector, so this should be no
problem.
 2023-08-22 13:19:49 +02:00
iwubcode
55fba7c0ed
VideoCommon/GraphicsModAsset: Error out if config key is not a string. 2023-08-22 02:40:08 +02:00
iwubcode
5506121685 VideoCommon: add support to graphics mod manager to load in assets and pass it to graphics actions 2023-08-20 18:53:27 -05:00
iwubcode
6ea0d17802 VideoCommon: when graphics settings change, trigger a reload of all custom shaders 2023-08-20 18:53:27 -05:00
iwubcode
931a8aa413 VideoCommon: add milliseconds elapsed time value to pixel shaders as a uniform to be able to support animation effects in custom shaders 2023-08-20 18:53:27 -05:00
iwubcode
c7191382be VideoCommon: add custom pipeline action 2023-08-20 18:53:27 -05:00
iwubcode
d320366954 VideoCommon: add custom shader cache to VertexManagerBase, supporting custom pixel shaders by replacing the existing pipeline with a modified one 2023-08-20 18:53:27 -05:00
iwubcode
bedbf2b8c6 VideoCommon: add custom shader cache 2023-08-20 18:53:27 -05:00
iwubcode
dbaf24ef09 VideoCommon: add data needed to support custom pixel shaders to graphics mod actions 2023-08-20 18:53:27 -05:00
iwubcode
4283d76718 VideoCommon: uber pixel shader gen changes needed to support custom pixel shaders in graphics mods 2023-08-20 18:53:27 -05:00
iwubcode
e704385fce VideoCommon: pixel shader gen changes needed to support custom pixel shaders in graphics mods 2023-08-20 18:53:27 -05:00
iwubcode
c3a370839a VideoCommon: add helper functions to handle generating custom lighting code for a custom pixel shader 2023-08-20 18:53:27 -05:00
iwubcode
0da5cf60a8 VideoCommon: add custom pixel shader definition and custom shader header to shadergen common as it will be used by both the special and uber shader variant of pixel shaders 2023-08-20 18:53:27 -05:00
Filoppi
8bca9a864f Video: The Auto internal resolution scaling wasn't working correctly if the window weird aspect ratios (e.g. 32:9), beacuse it would account for the the portion of the image that will show black bars into the calcuations to find the best matching resolution 2023-08-18 02:14:00 +03:00
Filoppi
6c7f34d5da Video: The Auto-Adjust Window Size setting was calculating the window size based on the resolution of the window in the previous frame if we used the "stretch" aspect ratio setting, so it's result would be self influence in a loop and behave unreliably (e.g. when changing resolution between Auto/Native/2x the automatic window scaling would behave randomly) 2023-08-18 02:14:00 +03:00
Filoppi
cb34d1aafe Video: There was always a black line around one of the 4 edges (top/left/bottom/right) of the window because the final output size wasn't calculated right (unless the aspect ratio was set to stretch) 2023-08-18 02:14:00 +03:00
Filoppi
fae3aee9e0 Video: The % 4 that was done on the rendering resolution was only meant to be done when recording videos (due to encoding limitations) but one case was missed (this had no consequences really, as it was just in the code that automatically resizes the window). The hardcoded 4 has been replaced with VIDEO_ENCODER_LMC for clarity. 2023-08-18 02:14:00 +03:00
Filoppi
80b453082d Video: fix post process shaders with parameters failing to build on OpenGL 
This was because the shader uniforms between the pixel and vertex shaders
were willingly left different, to avoid filling the vertex shader with unnecessary
params. Turns out all backends are fine with this except OGL.
The new behaviour is now much more consistent and well explained,
the "default" shaders are the ones that always run, and the non default
ones are the user selected ones (if any).
 2023-08-18 02:00:56 +03:00
Sam Belliveau
39d96a21a8 Video: Improved Tooltips & Bicubic (#5) 
Edited by Filoppi
 2023-08-18 02:00:56 +03:00
Sam Belliveau
ca93a5191f Video: Added Box Resampling 
Edited by Filoppi
 2023-08-18 02:00:56 +03:00
Filoppi
2edf81cdb0 Video: implement output resampling (upscaling/downscaling) methods 2023-08-18 02:00:55 +03:00
Admiral H. Curtiss
a08792033a
Merge pull request #12103 from iwubcode/asset_load_system_time 
VideoCommon: asset load time is now stored as a chrono system_clock time
 2023-08-18 00:14:29 +02:00
JosJuice
7197e3abd0 Use structs for config callback IDs 
This way you can't mix up regular config callback IDs and CPU thread
config callback IDs. (It would be rather bad if you did!)
 2023-08-17 19:19:26 +02:00
JosJuice
71ce8bb6f0 Don't call RunAsCPUThread in config callbacks 
In theory, our config system supports calling Set from any thread. But
because we have config callbacks that call RunAsCPUThread, it's a lot
more restricted in practice. Calling Set from any thread other than the
host thread or the CPU thread is formally thread unsafe, and calling Set
on the host thread while the CPU thread is showing a panic alert causes
a deadlock. This is especially a problem because 04072f0 made the
"Ignore for this session" button in panic alerts call Set.

Because so many of our config callbacks want their code to run on the
CPU thread, I thought it would make sense to have a centralized way to
move execution to the CPU thread for config callbacks. To solve the
deadlock problem, this new way is non-blocking. This means that threads
other than the CPU thread might continue executing before the CPU thread
is informed of the new config, but I don't think there's any problem
with that.

Intends to fix https://bugs.dolphin-emu.org/issues/13108.
 2023-08-17 19:19:25 +02:00
Admiral H. Curtiss
23ae8c439c
Merge pull request #12112 from JosJuice/hires-texture-encoding 
VideoCommon: Fix std::filesystem::path encoding conversion
 2023-08-16 18:39:18 +02:00
JosJuice
86910f406e VideoCommon: Fix std::filesystem::path encoding conversion 
In std::string, you can store strings using any encoding, but in Dolphin
we have decided to use UTF-8. The problem is that if you convert between
std::string and std::filesystem::path using the built-in methods, the
standard library will make up its own assumption of what encoding you're
using in the std::string. On most OSes this is UTF-8, but on Windows
it's whatever the user's code page is.

What I believe is the C++ standard authors' intended solution to this is
to use std::u8string instead of std::string, but that's a big hassle to
move over to, because there's no convenient way to convert between
std::string and std::u8string. Instead, in Dolphin, we have added helper
functions that convert between std::string and std::filesystem::path in
the manner we want. You *always* have to use these when converting
between std::string and std::filesystem::path, otherwise we get these
kinds of encoding problems that we've been having with custom textures.

Fixes https://bugs.dolphin-emu.org/issues/13328.
 2023-08-16 09:56:56 +02:00
takayhan-AMD
b969282b72 Remove out-dated hack of AMD driver issue WRT dual-source blending output index. 2023-08-15 23:58:29 -04:00
iwubcode
eeb73460ab VideoCommon: asset load time is now stored as a chrono system_clock time, so that times can be fabricated in a future feature (without creating a file to do so) 2023-08-15 22:02:28 -05:00
Dentomologist
720191d1f7 AbstractFramebuffer: Fix Android reorder-ctor warning 
Move declaration of m_additional_color_attachments so its initialization
order matches that of the constructor.
 2023-08-12 20:48:47 -07:00
iwubcode
246b7c5bdb VideoCommon: fix regression with texture load order where the custom texture code was always updating the asset map for each texture with each entry, making it so the last value actually would be loaded instead of the first 2023-08-11 00:36:41 -05:00
JMC47
5512d19d4b
Merge pull request #12061 from iwubcode/cubemap_backends_only 
VideoBackends: add support for cube maps for OGL, Vulkan, and D3D
 2023-08-10 18:36:48 -04:00
iwubcode
dca7c67105 VideoCommon: update NetplayChatUI's chat message input to use a hidden label. This avoids an error thrown by imgui 2023-07-29 00:27:07 -05:00
iwubcode
350e51951b VideoCommon: update imgui to 1.89.7 (and implot to 0.15); fix issues with upgrade; keep the demo code in case someone wants to reference it but don't compile it by enabling 'IMGUI_DISABLE_DEMO_WINDOWS' in config 2023-07-27 11:47:34 -05:00
Admiral H. Curtiss
a76cc146e1
Merge pull request #12055 from iwubcode/skip_dump_async 
VideoCommon: skip the texture dump if a custom texture is available, regardless if it is loaded or not
 2023-07-23 19:53:25 +02:00
iwubcode
fd74244339 VideoCommon: add custom texture message to provide a dirty means of debugging whether custom textures are installed correctly 2023-07-21 20:13:27 -05:00
iwubcode
e892b7f1ac VideoBackends: add support for cube maps for OGL, Vulkan, and D3D 2023-07-21 19:09:40 -05:00
iwubcode
f7e78742cf VideoCommon: skip the texture dump if the texture is using a custom texture, regardless of whether or not it is loaded yet 2023-07-19 23:44:41 -05:00
iwubcode
79f202ea5c VideoCommon: fix some compiler warnings for CustomAsset. FreeBSD compiler complained about a defaulted move constructor due to the mutex being implicitly deleted. Additionally, the const owning library deleted the copy constructor. 2023-07-16 19:45:55 -05:00
iwubcode
5740be15f9 VideoCommon: initialize load info variables 2023-07-16 12:56:03 -05:00
iwubcode
77511e8e7c VideoCommon: add material asset. A material is similar to other graphics engines where it provides data to be used in conjunction with a shader asset to generate a runtime AbstractShader 2023-07-09 12:21:34 -05:00
Admiral H. Curtiss
7bb04ff1dc
Merge pull request #12022 from iwubcode/texture_create_gmod_impl 
VideoCommon: call into graphics mods create texture callback
 2023-07-09 04:20:43 +02:00
Admiral H. Curtiss
0366122306
Merge pull request #12009 from iwubcode/shader_asset 
VideoCommon: add a pixel shader asset
 2023-07-03 03:24:11 +02:00
iwubcode
a2ad3ca6f7 VideoCommon: don't do pointer copies during graphics mod callback iteration 2023-07-02 13:58:07 -05:00
iwubcode
0539bb4a3e VideoCommon: call into graphics mods create texture callback, providing additional asset dependencies that trigger the texture to be reloaded 2023-07-02 13:45:09 -05:00
Admiral H. Curtiss
6d7bf60071
Merge pull request #11991 from iwubcode/tcache_multiple_texture_dependencies 
VideoCommon: allow multiple texture assets to associate with a texture cache entry
 2023-07-02 20:14:32 +02:00
iwubcode
a93e6e7397 VideoCommon: add support for allowing a TextureCache entry to be associated with multiple assets 2023-07-02 12:50:07 -05:00
Admiral H. Curtiss
eedc1144c1
Merge pull request #11923 from iwubcode/multi-texture-compute-support 
VideoBackends: support multiple compute images for some backends
 2023-07-01 17:47:55 +02:00
Admiral H. Curtiss
fa81006b51
Merge pull request #11955 from TellowKrinkle/CMakeDependencies 
CMake: Allow ignoring system packages
 2023-06-30 19:06:04 +02:00
iwubcode
6ea49c6746 VideoCommon: add a pixel shader asset 2023-06-30 01:32:53 -05:00
iwubcode
3627398cf5 VideoBackends: support multiple compute images for some backends (D3D, OGL, Vulkan) 2023-06-28 17:15:31 -05:00
Admiral H. Curtiss
c04536c5d0
Merge pull request #11982 from iwubcode/graphics_mod_create_texture_callback 
VideoCommon: add graphics mod callback interface for when a texture is created
 2023-06-23 18:10:59 +02:00
Admiral H. Curtiss
02909bd1a5
Merge pull request #11850 from Filoppi/post_process_fixes 
Video: implement color correction to match the Wii/GC NTSC/PAL color spaces (and gamma)
 2023-06-23 18:08:23 +02:00
iwubcode
1d767c3a5b VideoCommon: add graphics mod callback interface for when a texture is created 2023-06-20 19:26:53 -05:00
iwubcode
2dc24a9148 VideoCommon: move cached texture asset to 'CustomAsset' common code 2023-06-20 18:59:55 -05:00
Filoppi
a2702c6e27 Video: implement color correction to match the NTSC and PAL color spaces (and gamma) that GC and Wii targeted. 
To further increase the accuracy of the post process phase, I've added (scRGB) HDR support, which is necessary
to fully display the PAL and NTSC-J color spaces, and also to improve the quality of post process texture samplings and
do them in linear space instead of gamma space (which is very important when playing at low resolutions).
For SDR, the quality is also slightly increased, at least if any post process runs, as the buffer is now
R10G10B10A2 (on Vulkan, DX11 and DX12) if supported; previously it was R8G8B8A8 but the alpha bits were wasted.

Gamma correction is arguably the most important thing as Dolphin on Windows outputted in "sRGB" (implicitly)
as that's what Windows expects by default, though sRGB gamma is very different from the gamma commonly used
by video standards dating to the pre HDR era (roughly gamma 2.35).

Additionally, the addition of HDR support (which is pretty straight forward and minimal), added support for
our own custom AutoHDR shaders, which would allow us to achieve decent looking HDR in Dolphin games without
having to use SpecialK or Windows 11 AutoHDR. Both of which don't necessarily play nice with older games
with strongly different and simpler lighting. HDR should also be supported in Linux.
Development of my own AutoHDR shader is almost complete and will come next.

This has been carefully tested and there should be no regression in any of the different features that Dolphin
offers, like multisampling, stereo rendering, other post processes, etc etc.

Fixes: https://bugs.dolphin-emu.org/issues/8941

Co-authored-by: EndlesslyFlowering <EndlesslyFlowering@protonmail.com>
Co-authored-by: Dogway <lin_ares@hotmail.com>
 2023-06-19 01:34:42 +03:00
get
7523a62105 Change unnamed enum in NativeVertexFormat.h to u32 2023-06-17 08:13:57 -05:00
get
07ad75f34f EnumUtils: Add Common::ToUnderlying 
Mirrors the C++23 <utility> function, std::to_underlying
 2023-06-17 07:15:33 -05:00
Admiral H. Curtiss
1aef85a985
Merge pull request #11918 from TellowKrinkle/DPIScale 
Improved DPI change handling
 2023-06-17 04:07:13 +02:00
Admiral H. Curtiss
cbcf5bfac1
Merge pull request #11889 from Filoppi/patch-18 
Fix video output having small black borders all the times
 2023-06-16 17:59:51 +02:00
Admiral H. Curtiss
f5eea4a957
Merge pull request #11834 from Dentomologist/xemitter_use_pseudonamed_parameter_force5bytes 
XEmitter: Add enum class Force5Bytes
 2023-06-16 15:46:36 +02:00
TellowKrinkle
5b10a80401 CMake: Use targets for all optionally-external dependencies 2023-06-15 01:41:41 -05:00
Admiral H. Curtiss
6d16a09707
Merge pull request #11941 from Dentomologist/convert_blockingloop_stopmode_to_enum_class 
Common: Convert BlockingLoop::StopMode to enum class
 2023-06-13 11:47:20 +02:00
iwubcode
3e27fc7c0b VideoCommon: don't treat incorrect aspect ratio or sizes that aren't a multiple of native textures as an error 2023-06-12 21:19:29 -05:00
Dentomologist
3c80f821c0 Common: Convert BlockingLoop::StopMode to enum class 2023-06-12 17:12:25 -07:00
Dentomologist
4c2759f541 XEmitter: Add enum class Jump 
Replace the bool parameter force5bytes in J, JMP, and J_CC with an enum
class Jump::Short/Near. Many callers set that parameter to the literal
'true', which was unclear if you didn't already know what it did.
 2023-06-12 13:04:18 -07:00
OatmealDome
1a0a1e8f12
Merge pull request #10976 from TellowKrinkle/StackFrames 
Improve stack frames for profilers
 2023-06-12 05:00:08 +02:00
TellowKrinkle
d3110b9521 VideoCommon: Update imgui scale when dpi changes 2023-06-11 20:05:27 -05:00
Robin Kertels
23bebc5270
VideoBackends:Vulkan: Allow loading custom drivers on Android 
... using libadrenotools
 2023-06-11 13:52:34 +02:00
Admiral H. Curtiss
8f51a9d2d8
Merge pull request #11699 from Pokechu22/gl-check-maximum-samples 
OpenGL: Check the list of supported AA modes instead of hardcoding
 2023-06-09 15:07:07 +02:00
Admiral H. Curtiss
092773ad0c
Merge pull request #11859 from iwubcode/backend-multi-output 
VideoBackends: add support to allow rendering to multiple output targets
 2023-06-09 13:40:21 +02:00
Pokechu22
c63f0f37cd VideoCommon: Pass WindowSystemInfo to InitBackendInfo 2023-06-08 22:07:39 -07:00
iwubcode
afa498fa2f VideoCommon: update DirectFilesystemAssetLibrary to not throw exceptions when a file no longer exists 2023-06-08 22:20:52 -05:00
iwubcode
429b2eca8a VideoCommon: add logging for loading texture assets 2023-06-08 19:48:45 -05:00
Admiral H. Curtiss
7845fb00ee
Merge pull request #11681 from iwubcode/asset_management 
VideoCommon: migrate texture packs to use the asset loader system
 2023-06-08 22:21:12 +02:00
Admiral H. Curtiss
78f5c5f8d2
Merge pull request #11899 from Filoppi/patch-20 
Video: Fix Post Process shader options issues
 2023-06-08 16:12:49 +02:00
Admiral H. Curtiss
3dbdf0472d
Merge pull request #11901 from Filoppi/add_texture_types 
Video: add R10B10G10A2 and R16G16B16A16F texture types
 2023-06-08 15:28:15 +02:00
Filoppi
cdc53c046b Video: add R10B10G10A2 and R16G16B16A16F texture types (needed by PR 11850) 2023-06-08 03:17:20 +03:00
Filippo Tarpini
c9e61a79b7
Video: Fix Post Process shader options issues 
-An assert would be erroneously thrown when shaders declared an array of 4 int or float options, despite 4 being the max supported (a simple <= / < mistake)
-When changing the type of a shader option (e.g. from bool to float), the serialization would be stuck appending the value from the previous option type, making the shader fail to build permanently until the cache were cleaned
 2023-06-08 02:54:46 +03:00
iwubcode
e831d7b6bb InputCommon / VideoCommon: remove dynamic input reloading the texture cache, this is no longer needed, assets reload automatically! 2023-06-07 18:30:10 -05:00
iwubcode
ca8d6748d6 VideoCommon: introduce linked assets in TCacheEntry, allowing for assets to be reloaded 2023-06-07 18:30:10 -05:00
Minty-Meeo
e92f8fcbb4 Remove old GCC version workarounds 
The minimum GCC version is now GCC 10.
 2023-06-06 22:49:53 -05:00
iwubcode
f1f1ecc9d1 Core / VideoCommon: update HiresTexture to use CustomAssetLoader 2023-06-05 16:33:19 -05:00
iwubcode
9d7ab47738 VideoCommon: add additional locks around asset access and usage to ensure thread safety 2023-06-05 16:19:46 -05:00
Filippo Tarpini
adf4089276
Fix video output having small black borders all the times 
To maintain compatibility with some video encoders, the whole output buffer was scaled to be a multiple of 4.
This change makes it so that that rule only applies while actively recording (or taking screenshots, even if it might not be necessary for that case).
 2023-06-04 18:03:57 +03:00
iwubcode
8c3dc5b0d6 VideoCommon: update pipeline version for RenderState change 2023-06-03 14:52:31 -05:00
iwubcode
834f8f7b5c VideoBackends: add support to allow rendering to multiple output textures 2023-06-03 14:52:31 -05:00
iwubcode
9b9dc6dc5d VideoCommon: fix minor issue in C++ template 2023-06-03 12:47:12 -05:00
Admiral H. Curtiss
80bf175c48
Merge pull request #11879 from iwubcode/texture_data_load_nolevels 
VideoCommon: avoid segfault when loading a PNG with no custom texture data levels
 2023-06-03 19:35:48 +02:00
iwubcode
47c40d51df VideoCommon: when loading a PNG with no custom texture data levels already, create a level, this avoids a potential segfault 2023-06-03 12:19:30 -05:00
Admiral H. Curtiss
0b3d28abaf
Merge pull request #11586 from JosJuice/unknown-opcode-msg 
VideoCommon: Reword the unknown opcode error message
 2023-06-03 12:53:33 +02:00
iwubcode
58d383b30b VideoCommon: prevent potential data issue when reloading Asset data that could happen due to the asset loading thread reloading data while another thread is working with it 2023-06-03 00:13:06 -05:00
iwubcode
c93940c6ee VideoCommon: add multithreaded asset loader and define a texture asset 2023-06-02 17:31:31 -05:00
iwubcode
07307edd49 VideoCommon: add an asset library that loads directly from the filesystem 2023-06-02 14:49:22 -05:00
iwubcode
e028d2ead0 VideoCommon: move custom texture data to assets 2023-06-02 14:07:42 -05:00
iwubcode
b2c5a5485a VideoCommon: add custom asset implementation and asset library that can load an asset 2023-06-01 19:57:57 -05:00
joon
db712772b7 Add compression option for texture dumps. 
Enable through command line options:
-C Graphics.Settings.TexturePNGCompressionLevel=[0-9]

Or from GFX.ini:
[Settings]
TexturePNGCompressionLevel=[0-9]

@see #10792
 2023-06-01 16:01:11 -04:00
iwubcode
0afb8c247f VideoCommon: check whether action was successfully created before adding targets for a graphics mod 2023-05-30 09:32:59 -05:00
iwubcode
bbf3efb17d VideoCommon: fix bug in GraphicsModManager where a separate action was being created for each target 2023-05-29 23:08:35 -05:00
Pokechu22
810eb70f0e DolphinAnalytics: Add READS_BOUNDING_BOX game quirk 2023-05-06 17:18:17 -07:00
Lioncash
4db186f9ff Common/JitRegister: Move interface into Common namespace 
Makes the namespace consistent with other common utilities.
 2023-05-02 12:00:05 -04:00
Lioncash
07ed932a09 Common/LinearDiskCache: Move interface into Common namespace 
Gets the interface out of the global namespace.
 2023-04-19 09:14:39 -04:00
Lioncash
784a216927 Common/MathUtil: Move IntLog2 into MathUtil namespace 
Gets this out of the global namespace.
 2023-04-15 03:35:05 -04:00
Admiral H. Curtiss
e9dbb93cb5
Merge pull request #11756 from lioncash/ini 
Common/IniFile: Move interface into Common namespace
 2023-04-14 20:52:30 +02:00
Léo Lam
ae18aa0639
Merge pull request #11687 from Minty-Meeo/warnings 
Resolve GCC/Clang Warnings
 2023-04-14 01:29:46 +01:00
Lioncash
e4caace6bb Common/IniFile: Move interface into Common namespace 
Gets this out of the global namespace and into the Common namespace
 2023-04-13 10:19:28 -04:00
Minty-Meeo
678c93589a Resolve [-Wclass-memaccess] 2023-04-12 03:59:57 -05:00
iwubcode
e101f7f6ae VideoCommon: refactor GetTexture into a separate function for creation, separating the custom texture data path from the game's texture data path 2023-04-08 02:54:00 -05:00
Minty-Meeo
1312624e05 Resolve [-Wshadow] 2023-04-06 19:25:26 -05:00
Admiral H. Curtiss
192d8b6e40
VideoCommon/CommandProcessor: Pass System to HandleUnknownOpcode(). 2023-04-05 20:09:32 +02:00
Markus Wick
50a45bd614
Merge pull request #11673 from K0bin/vertex-loader-micro-opt 
Vertex Loader Microoptimization
 2023-03-30 11:05:02 +02:00
Lioncash
0888c93d48 Common: Move FPU-related helpers into Common namespace 
Makes these utilities' namespace consistent with the majority of the
Common library.
 2023-03-21 10:58:13 -04:00
Robin Kertels
93fce0e4b6
VideoCommon:VertexManagerBase: Only calculate remaining indices once 
Before, both of those were calculated 3 times due to the ASSERTs.
 2023-03-20 20:59:50 +01:00
Robin Kertels
408b09da31
VideoCommon:VertexShaderManager: Inline SetVertexFormat & UpdateValue/Offset 2023-03-20 20:59:38 +01:00
Robin Kertels
7703fef3a4
VideoCommon:VertexLoaderManager: Only update vertex format in shader manager if necessary. 2023-03-20 00:41:16 +01:00
Admiral H. Curtiss
069280ddc6
HW/VideoInterface: Refactor to class. 2023-03-11 12:50:35 +01:00
Scott Mansell
b7db2510ef Don't discard ConfigChanged callback handle 2023-03-06 00:12:26 +13:00
Minty-Meeo
bf079d6d3a [[unlikely]] ASSERT 
and other ASSERT usage changes
 2023-03-02 19:54:15 -06:00
Mai
6361586a04
Merge pull request #11582 from Pokechu22/software-crash-on-startup 
Software: Fix regressions from "Kill Renderer"
 2023-03-02 15:13:00 -05:00
Pokechu22
9cdc0aca9b Software: Fix "Auto-Adjust Window Size" 
This also needs to be handled on the software renderer path.
 2023-03-02 11:08:49 -08:00
Pokechu22
78428dd8db Software: Fix crash on startup when using "Compile Shaders Before Starting" 
When that setting is enabled, m_xfb_entry is initially not present (during the phase where a shader compilation progress bar would be shown). The main path checks for m_xfb_entry, but the software renderer fallback path didn't.

Fixes another aspect of https://bugs.dolphin-emu.org/issues/13172.
 2023-03-02 11:08:49 -08:00
Pokechu22
4a2d3c83c7 Software: Implement GetSurfaceInfo() 
Before, it used a fallback where it returned a default object, where the width and height were set to 0. Presenter::Initialize() used GetSurfaceInfo to set the backbuffer size, then used that size when initializing the on-screen UI (even for the software renderer, where the on-screen UI isn't currently present), which meant that ImGui got a window size of 0 and thus resulted in a failed assertion.

Although BindBackbuffer checks for size changes, it doesn't help because ImGui has already been initialized, and the size hasn't actually changed since initialization occured.

Fixes one aspect of https://bugs.dolphin-emu.org/issues/13172.
 2023-03-02 11:08:49 -08:00
iwubcode
42cb3f3904 VideoCommon: remove HiResTexture DDS loading, update hirestexture logic to use custom texture data 2023-03-01 12:11:04 -06:00
iwubcode
3e35255983 VideoCommon: add class to load custom texture data 2023-03-01 11:58:37 -06:00
Dentomologist
ad6e95afb4 D3D: Restore workaround for erroneous NaN optimization 
The HLSL compiler incorrectly decides isnan can't be true, so this
workaround was originally added in 52c82733 but lost during the
conversion to SPIR-V.
 2023-02-25 16:27:30 -08:00
JosJuice
f2be35c7cd VideoCommon: Reword the unknown opcode error message 
When faced with this error, users often don't try disabling dual core,
even though the error message suggests it. Perhaps the message is just
too long and lists too many things?

To try to improve the situation, I'm rewording the message and making it
say different things depending on what settings you are using.
 2023-02-19 16:35:28 +01:00
Scott Mansell
6038a6e2db
Merge pull request #11569 from Hibyehello/patch-1 
VideoBackend: Make Metal Default on MacOS
 2023-02-16 21:08:35 +13:00
Pokechu22
67381cdb8b VideoCommon: Remove unused ShutdownImGui function declaration 
This was moved to the ~OnScreenUI() destructor in 0d4537d60f.
 2023-02-15 19:20:59 -08:00
Pokechu22
8802f96b7e Fix uninitialized variable warnings (C26495) 2023-02-15 19:18:39 -08:00
Josh
cd38ed76e2
Keep Vulkan precedence over OpenGL 2023-02-15 12:22:56 -06:00
Josh
546a016dc8
VideoBackend: Make Metal Default on MacOS 2023-02-15 12:05:54 -06:00
TellowKrinkle
f25a0b43b6 VideoCommon: Fix stereoscopic 3D on OpenGL < 4.3 (macOS) 2023-02-14 18:25:33 +01:00
Pokechu22
4f6ce51d69 VideoCommon: Clear blend configuration if color/alpha update disabled 
This works around an Intel driver bug where, on D3D12 only, dual-source blending behaves incorrectly if the second source is unused on. This bug is visible in skyboxes in Super Mario Sunshine, which first draw clouds and sun flare in greyscale and then draw the sky afterwards with a source factor of 1 and a dest factor of 1-src_color (this results in the clouds being tinted blue). This process is done on an RGB888 framebuffer, so alpha update is disabled. (Color update is enabled; note that if you look at this in Dolphin's fifo analyzer, it won't be enabled because they use the BP mask functionality to only change the blending functions and not alpha/color update, for whatever reason.)
 2023-02-13 18:22:41 -08:00
Scott Mansell
1fc5d37fd2
Merge pull request #11558 from Pokechu22/vertex-loader-size-assertion-details 
VertexLoader: Add more info to m_vertex_size == m_src_ofs assertion
 2023-02-13 17:34:04 +13:00
Pokechu22
cc411c4e41 VertexLoader: Add more info to m_vertex_size == m_src_ofs assertion 2023-02-12 20:10:38 -08:00
Scott Mansell
f37113204f
Merge pull request #11550 from iwubcode/set_common_samplers_count 
VideoCommon: add constant value for maximum number of pixel samplers
 2023-02-13 16:05:51 +13:00
iwubcode
20dc4401c5 VideoCommon: pass a graphics mod base path to the graphics mod, so it can lookup other relative files if necessary 2023-02-11 00:21:40 -06:00
Admiral H. Curtiss
3c2933cad2
Merge pull request #11549 from Pokechu22/texturecachebase-bitset-include 
TextureCacheBase: Remove unused bitset include
 2023-02-10 10:55:07 +01:00
JMC47
258151fe5a
Merge pull request #11523 from degasus/OGL_KHR_subgroup 
VideoBackend/OGL: Prefer KHR_shader_subgroup over NV_shader_thread.
 2023-02-10 04:47:20 -05:00
iwubcode
af313f8419 VideoCommon: add constant value to set the allowed maximum number of pixel samplers 2023-02-10 00:46:11 -06:00
Pokechu22
3024ca2146 Suppress memcpy writing to an object with no trivial copy-assignment warnings 
We need to copy padding in most of these cases, and the objects are trivially copyable; however, BitField prevents trivial copy-assignment.
 2023-02-09 16:23:49 -08:00
Pokechu22
470115fd4f TextureDecoder: Fix warning: array subscript has type ‘char’ [-Wchar-subscripts] 2023-02-09 16:23:02 -08:00
Pokechu22
9559c45cae CommandProcessor: Fix shadowing warnings 2023-02-09 16:23:02 -08:00
Pokechu22
39c5d55f03 VertexLoaderBase: Fix shadowing warning 2023-02-09 16:23:02 -08:00
Pokechu22
95bee485c9 GraphicsModManager: Fix shadowing warning 2023-02-09 16:23:02 -08:00
Pokechu22
5283a85205 TextureCacheBase: Remove unused bitset include 
It was used for valid_bind_points, which was removed in 88bd10cd30 (and the declaration was more recently removed in 606c18210d).
 2023-02-09 16:04:48 -08:00
JMC47
a88e5ef390
Merge pull request #11498 from iwubcode/save_pipeline_config 
VideoCommon: store the configuration used to create the AbstractPipeline
 2023-02-09 18:38:49 -05:00
Markus Wick
17d7b75a9b
Merge pull request #11544 from jmallach/spng 
Allow building against system libspng
 2023-02-09 14:47:58 +01:00
degasus
4b2aa948e6 VideoBackend/OGL: Prefer KHR_subgroup over NV_shader_thread. 
While the NV extension is totally fine, the KHR extension should be able to support more hardware.

For NVIDIA, the hardware either supports both or neither, it just needs a driver from the last two years.
For AMD, the drivers from late 2022-12 seems to bring support for the KHR extension.
For Intel, the KHR is also supported for some years.
 2023-02-09 13:27:02 +01:00
iwubcode
d0c6b6c9ed VideoCommon: store the configuration used to create the AbstractPipeline on the pipeline itself, so that it's easy to duplicate pipelines with slightly altered configuration 2023-02-09 02:13:53 -06:00
Scott Mansell
ccf92a3e56
Merge pull request #11522 from phire/KillRendererWithFire 
Kill Renderer (with phire)
 2023-02-09 19:59:16 +13:00
Scott Mansell
5c1b3ac61d Hook up Presenter's ConfigChanged function 
Fixes issue with post-processing not working
 2023-02-09 18:36:20 +13:00
Scott Mansell
9c1fe59cc9 Insert a more solid abstraction between Qt and Imgui 2023-02-09 18:36:20 +13:00
Scott Mansell
b2a31103b4 Presenter: Handle blanked frames correctly 2023-02-09 18:36:20 +13:00
Scott Mansell
83b7b01265 Fix XFB duplicate detection 
Frame duplicate detection was inverted. Huge problem for 60fps games
where it would see all frames as "duplicates" and nothing would ever be
presented.
 2023-02-09 18:36:20 +13:00
Scott Mansell
d3ddd96cee Make sure m_prev_efb_format is initilized 2023-02-09 18:36:20 +13:00
Scott Mansell
8c8bd0e7ac Rename to HookableEvent. Because naming conflict 2023-02-09 18:36:20 +13:00
Scott Mansell
60f2b5af7b Apply suggestions from code review 
Co-authored-by: Mai <mathew1800@gmail.com>
Co-authored-by: BhaaL <bhaalsen@gmail.com>
Co-authored-by: iwubcode <iwubcode@users.noreply.github.com>
 2023-02-09 18:36:20 +13:00
Scott Mansell
e0a1631659 Add comment about "end of frame" 2023-02-09 18:36:20 +13:00
Scott Mansell
e2de281897 Make sure pixel shaders pick up Initial EFB Scale 2023-02-09 18:36:20 +13:00
Scott Mansell
cf9a6f8477 Lint fixes 2023-02-09 18:36:20 +13:00
Scott Mansell
628af9d564 Fix builds with FFMPEG disabled 2023-02-09 18:36:20 +13:00
Scott Mansell
4422af1272 Cleanup headers 2023-02-09 18:36:20 +13:00
Scott Mansell
5803786beb Move UseVertexDepthRange() out of Renderer 
There wasn't really a good place for it, but this will do
 2023-02-09 18:36:20 +13:00
Scott Mansell
2cfc02a116 Move m_prev_efb_format into FramebufferManager 2023-02-09 18:36:20 +13:00
Scott Mansell
9b5397abdb Move WidescreenHeuristic to it's own class 
It's about the only thing left in renderer
 2023-02-09 18:36:20 +13:00
Scott Mansell
31cfe8250d Lint fixes 2023-02-09 18:36:20 +13:00
Scott Mansell
11de923dcb Move xfb tracking and IR scaling out of RenderBase 2023-02-09 18:36:20 +13:00
Scott Mansell
e009002411 Refactor ClearRegion 
And fix bug where opengl was getting the wrong coordinates
 2023-02-09 18:36:20 +13:00
Jordi Mallach
4d164fcb77 Allow building against system libspng 2023-02-06 13:30:46 +01:00
Scott Mansell
e98ab0784d
Merge pull request #11501 from iwubcode/abstract_texture_load_specify_layer 
VideoBackends: add a way to load data into a specific level AND layer
 2023-02-01 00:03:59 +13:00
OatmealDome
0f037a1af8
Merge pull request #10864 from TellowKrinkle/BetterLogicBlend 
VideoCommon: Better logic op invert approximation
 2023-01-31 01:55:55 -05:00
Scott Mansell
b753641dd4 Add some descriptions to new classes 2023-01-31 19:41:24 +13:00
Scott Mansell
abfc75f362 Cleanup headers 2023-01-31 19:41:24 +13:00
Scott Mansell
ec8f46b02c Expose Renderer's Framecount 
We don't want to move it, because we want to complete
this refactor without changing savestate version
 2023-01-31 19:41:24 +13:00
Scott Mansell
3be63221c7 Renderer still needs to track swaps for savestates 2023-01-31 19:41:24 +13:00
Scott Mansell
3ae78b8e76 Also use events for config changed 2023-01-31 19:41:24 +13:00
Scott Mansell
0da69055d9 Split out everying remaining from Swap 2023-01-31 19:41:24 +13:00
Scott Mansell
2a18b34a73 Wire up frame before/after events 2023-01-31 19:41:24 +13:00
Scott Mansell
154cb4f722 Introduce an Event system to VideoCommon 
A lot of the remaining complexity in Renderer is the massive Swap function
which tries to handle a bunch of FrameBegin/FrameEnd events.

Rather than create a new place for it. This event system will try
to distribute it all over the place
 2023-01-31 19:41:24 +13:00
Scott Mansell
d6cd8de1a7 Delete unused EFBHasAlphaChannel function 2023-01-31 19:41:24 +13:00
Scott Mansell
9d125a6e43 Move ConfigChanged out of RenderBase 
There is this nice VideoConfig file that's perfect for it
 2023-01-31 19:41:24 +13:00
Scott Mansell
ca5ec13e13 Move GraphicsMod out of RenderBase 2023-01-31 19:41:24 +13:00
Scott Mansell
55d15bdd6e Move utiltily drawing out of RenderBase 2023-01-31 19:41:24 +13:00
Scott Mansell
99d3e489ea Move BoundingBox out of RenderBase 
They were essentially just pass-though methods
 2023-01-31 19:41:24 +13:00
Scott Mansell
8bc8e43dd6 Add virtual Initialize() to PerfQueryBase 
Both DX12 and Vulkan already had one.
 2023-01-31 19:41:24 +13:00
Scott Mansell
3c73707dfe Fix dead code. 2023-01-31 19:41:24 +13:00
Scott Mansell
b007b8e104 Replace BeginUI/EndUI 2023-01-31 19:41:24 +13:00
Scott Mansell
18c799f0b6 Present: Set surface info before initializing ImGui 
Otherwise you get subtle bugs in vulkan that take hours to track down.
 2023-01-31 19:41:24 +13:00
Scott Mansell
f158ff300b Handle VideoSoftware's present fallback better 
Not a good idea to abuse bSupportsPostProcessing
 2023-01-31 19:41:24 +13:00
Scott Mansell
26e00c3bb4 Fix warning about using & with bools 2023-01-31 19:41:23 +13:00
Scott Mansell
74d3b3443a Fix warning about compare sign mismatch 2023-01-31 19:41:23 +13:00
Scott Mansell
8f5b196019 Minimise include polution from RenderState 2023-01-31 19:41:23 +13:00
Scott Mansell
2a2014af09 Implement AbstractGfx for Vulkan 2023-01-31 19:41:23 +13:00
Scott Mansell
58b70b2fb2 Don't set common globals from Video Backends 2023-01-31 19:41:23 +13:00
Scott Mansell
d37f83ffeb Implement AbstractGfx for Software & Null 2023-01-31 19:41:23 +13:00
Scott Mansell
f0336a3129 Implement AbstractGfx for OpenGL 
Mostly involves moving contents of OGLRender
to OGLGfx and OGLConfig
 2023-01-31 18:46:04 +13:00
Scott Mansell
8a23629345 Split AbstractGfx out of Renderer 
Almost all the virtual functions in Renderer are part of dolphin's
"graphics api abstraction layer", which has slowly formed over the
last decade or two.

Most of the work was done previously with the introduction of the
various "AbstractX" classes, associated with texture cache cleanups
and implementation of newer graphics APIs (Direct3D 12, Vulkan, Metal).
We are simply taking the last step and yeeting these functions out
of Renderer.

This "AbstractGfx" class is now completely agnostic of any details
from the flipper/hollywood GPU we are emulating, though somewhat
specialized.

(Will not build, this commit only contains changes outside VideoBackends)
 2023-01-31 18:46:02 +13:00
Scott Mansell
e57eb04ed3 Rename FrameDump.{cpp,h} to FrameDumpFFMpeg.{cpp,h} 
The name kind of conflicts with a new FrameDumper class
 2023-01-31 18:45:29 +13:00
Scott Mansell
0d4537d60f Move Presenting, Dumping and ImGui out of Renderer 2023-01-31 18:45:21 +13:00
Scott Mansell
c38c76abad Refactor to remove virtual from RenderXFBToScreen 
Slightly simplifies the upcoming refactor
 2023-01-31 18:29:47 +13:00
Scott Mansell
a01d5283ec TextureCache: Add content locking 
Texture cache occasionally mutates textures for efficiency.
Which is awkward if we want to borrow those textures from texture cache
to do something else, such as a graphics debugger, or async presentation
on another thread.

Content locking provides a way to signal that the contents of a texture
cache entry should not change. Texture cache will be forced to use
alternative strategies.
 2023-01-31 18:29:47 +13:00
Scott Mansell
606c18210d TextureCache: Refactor with smart pointers 
The whole ownership model was getting a bit of a mess, with a some
of special cases to deal with. And I'm planning to make it even more
complex in the future.
So here is some upfront work to convert it over to reference counted
pointers.
 2023-01-31 18:29:47 +13:00
Scott Mansell
c1fd4a2013 Move TCacheEntry out of TextureCacheBase 
Allows for fowards declaration
 2023-01-31 18:29:47 +13:00
TellowKrinkle
600ad5f498 VideoCommon: Better logic op invert approximation 2023-01-30 14:04:37 -06:00
Pierre Bourdon
a2f4606d33
Merge pull request #11205 from TellowKrinkle/AutoPresent 
VideoBackends:Metal: Default to presentDrawable when vsync is on
 2023-01-30 09:01:18 +01:00
Scott Mansell
6d7303993c
Merge pull request #11509 from Sam-Belliveau/improved-speed-counter 
Tie Speed to CPU Speed and not VPS
 2023-01-30 20:41:03 +13:00
TellowKrinkle
1119a9ba32 VideoCommon: Don't create pipelines with no render targets 
Some backends don't like it when you do that
 2023-01-29 14:35:23 -06:00
Sam Belliveau
ebf114aef5 Tie Speed to CPU Speed and not VPS 2023-01-29 13:33:48 -05:00
iwubcode
7bea39b39e VideoBackends: add a way to load data into a specific level AND layer, default to layer 0 2023-01-27 18:46:53 -06:00
Admiral H. Curtiss
0a343007cb
PowerPC: Parametrize LR macro. 2023-01-27 15:22:43 +01:00
Admiral H. Curtiss
be8d0b76ca
PowerPC: Remove PC macro. 2023-01-27 15:22:41 +01:00
Pierre Bourdon
9c9310bf44
Merge pull request #11208 from TellowKrinkle/CPUCull 
Cull vertices on the CPU
 2023-01-26 23:15:23 +01:00
TellowKrinkle
a0e6d7c173 VideoCommon: Explicitly disable fp_contract for CPUCull 2023-01-25 02:21:56 -06:00
TellowKrinkle
1be0149146 VideoCommon: Cull vertices on the CPU 2023-01-25 02:21:56 -06:00
TellowKrinkle
b170ef9651 VideoCommon: Add class for quickly transforming and culling vertices on the CPU 2023-01-25 02:21:56 -06:00
Pierre Bourdon
8d5edb13a9
Merge pull request #11367 from Sam-Belliveau/lagbegone 
VideoCommon: VI Skip
 2023-01-19 01:20:01 +01:00
Pierre Bourdon
a7d1683149
Merge pull request #11432 from Pokechu22/generic-vertex-loader-test-error 
VertexLoader: Fix loading tangent/binormal caches with NormalIndex3
 2023-01-17 23:30:29 +01:00
Sam Belliveau
23ad07b368 Add VISkip 2023-01-14 01:56:37 -05:00
Pokechu22
3910bdd68b VertexLoader: Don't write position_cache if vertex is skipped 
This is the behavior in the x64 and ARM64 vertex loaders. I don't know if it makes sense (the whole skipped vertex system seems jank, but several games behave incorrectly without it).
 2023-01-13 15:38:00 -08:00
Pokechu22
16c0593a52 VertexLoader: Fix loading tangent/binormal caches with NormalIndex3 2023-01-13 15:38:00 -08:00
Pokechu22
2d53b73643 VertexLoaderTester: Add assertions for position/binormal/tangent caches 2023-01-13 15:38:00 -08:00
Pokechu22
c681d96d46 VertexLoaderTester: Use asserts instead of logs 
Logs don't show up in unit tests, and since this is debugging functionality (though not enabled for tests by default) it's better to do it this way.
 2023-01-13 15:38:00 -08:00
Sam Belliveau
bc1cc9eeb4 CoreTiming: Throttle Before Every Event Using Chrono 2023-01-06 17:21:17 -05:00
Sam Belliveau
588a72a4fc
PerformanceTracker: Add ownership of m_log_name. 2023-01-06 20:27:25 +01:00
Sam Belliveau
bc46089ab0
PerformanceTracker: Use shared_mutex instead of mutex so multiple threads can read at the same time. 2023-01-06 20:27:25 +01:00
Sam Belliveau
9143eb00fb
PerformanceMetrics: Fix Line Width Issue on Non HiDPI Screens 2023-01-06 20:27:17 +01:00
Mai
cc14d60bbb
Merge pull request #11402 from Pokechu22/too-many-indices 
IndexGenerator: Fix off-by-one in GetRemainingIndices
 2023-01-05 15:15:09 +00:00
Pokechu22
cefcd9c93c IndexGenerator: Fix off-by-one in GetRemainingIndices 
Fixes https://bugs.dolphin-emu.org/issues/13136.
 2023-01-04 10:42:00 -08:00
Pokechu22
6c58ba353c IndexGenerator: Add assertion for overflow in GetRemainingIndices 
This assertion is currently triggered by Pocoyo Racing (https://bugs.dolphin-emu.org/issues/13136).
 2023-01-04 10:41:14 -08:00
Admiral H. Curtiss
2fdaf0a86e
HW/ProcessorInterface: Rename member variables to fit naming convention. 2023-01-04 03:17:26 +01:00
Admiral H. Curtiss
74e1577a2c
HW/ProcessorInterface: Refactor to class, move to Core::System. 2023-01-04 03:00:10 +01:00
Pokechu22
d91f340c86 VertexManagerBase: Move free space check to after the buffer is reset 
Fixes incorrect logspam when the buffer needed to be reset on flushes (which we already were doing, but 52feed04db moved it to after the check was made). This is https://bugs.dolphin-emu.org/issues/10312.

I also converted it to an assert, as if this does happen, things are going to render incorrectly, so we want to make it obvious.
 2023-01-03 17:06:51 -08:00
Admiral H. Curtiss
ed9915308b
Merge pull request #11386 from Pokechu22/manual-texture-sampling-stereoscopic-layer-bounds-check 
PixelShaderGen: Clamp texture layer when using manual texture sampling with stereoscopic 3D
 2023-01-03 18:07:06 +01:00
Admiral H. Curtiss
cb0a603c72
VideoCommon: De-globalize GeometryShaderManager class. 2022-12-29 15:33:19 +01:00
Admiral H. Curtiss
7e55cc9e90
VideoCommon/VertexShaderManager: Rename private variables. 2022-12-28 16:00:15 +01:00
Admiral H. Curtiss
50625728e0
VideoCommon: De-globalize VertexShaderManager class. 2022-12-28 15:52:29 +01:00
Pokechu22
f3df3a7727 PixelShaderGen: Clamp texture layer when using manual texture sampling with stereoscopic 3D 
Otherwise, texelFetch() will use an out-of-bounds layer for game textures (that have 1 layer; EFB copies have 2 layers in stereoscopic 3D mode), which is undefined behavior (often resulting in a black image). The fast texture sampling path uses texture(), which always clamps (see https://www.khronos.org/opengl/wiki/Array_Texture#Access_in_shaders), so it was unaffected by this difference.
 2022-12-27 13:45:13 -08:00
Admiral H. Curtiss
4549fb4acb
VideoCommon/PixelShaderManager: Rename s_ variables. 2022-12-27 20:20:27 +01:00
Admiral H. Curtiss
725bd64ec2
VideoCommon: De-globalize PixelShaderManager class. 2022-12-27 20:13:24 +01:00
Sam Belliveau
6052a5ca9b Fix Speed Counter Sample Size 2022-12-26 16:47:12 -05:00
Sam Belliveau
e1d078ada6 Remove Redundant Access Specifiers 2022-12-23 20:13:01 -05:00
Sam Belliveau
673f81c18a New FrameTime/VBlank Analyzer + Graph 2022-12-23 19:52:53 -05:00
Minty-Meeo
05bebee802 Replace BitUtils with C++20: Counting Zeroes 
With the upgrade to C++20, std::countl_zero and std::countr_zero can replace these home-spun implementations from the BitUtil.h library.
 2022-12-21 04:17:00 -06:00
JosJuice
547d956278 Common: Use C++20 <bit> header in BitSet.h 2022-12-18 16:51:32 +01:00
Admiral H. Curtiss
c486baffe6
VideoCommon/PixelEngine: Pass Core::System to methods. 2022-12-11 21:57:30 +01:00
Admiral H. Curtiss
ec8aaf1f30
VideoCommon/PixelEngine: Refactor to class, move to Core::System. 2022-12-11 21:57:19 +01:00
Admiral H. Curtiss
ceae4242fc
VideoCommon/Fifo: Pass Core::System to methods. 2022-12-10 17:16:26 +01:00
Admiral H. Curtiss
5624dd6d39
VideoCommon/Fifo: Refactor to class, move to Core::System. 2022-12-10 17:16:19 +01:00
Admiral H. Curtiss
8a3b8a925e
Core: Add option to force linear texture filtering. 2022-12-09 02:02:16 +01:00
Admiral H. Curtiss
839db591d9
HW/Memmap: Refactor Memory to class, move to Core::System. 2022-12-03 13:27:02 +01:00
Admiral H. Curtiss
6941d2e7e6
VideoCommon/CommandProcessor: Refactor to class, move to Core::System. 2022-11-29 08:15:01 +01:00
Admiral H. Curtiss
c9558ecb4c
CoreTiming: Refactor to class. 2022-11-27 03:47:12 +01:00
Mai
7be4c90f67
Merge pull request #11166 from AdmiralCurtiss/mmio-system 
HW: Pass System to MMIO handlers.
 2022-11-24 00:58:45 +00:00
Pokechu22
cc5640245c Fix build errors related to formatting non-scoped enums 2022-11-23 13:45:43 -08:00
Admiral H. Curtiss
545fee9c94
Core/CommandProcessor: Reformat single/dual core dependent MMIO handlers. 2022-11-23 21:58:18 +01:00
Admiral H. Curtiss
0a6fdb9c13
HW: Pass System to MMIO handlers. 2022-11-23 05:52:21 +01:00
Mai
a47ed2124f
Merge pull request #11253 from AdmiralCurtiss/core-timing-events-pass-system 
CoreTiming: Pass Core::System to Events.
 2022-11-23 04:46:11 +00:00
Mai
cb232155d9
Merge pull request #11298 from Pokechu22/vertexloader-no-DataReader 
VertexLoader: Eliminate use of DataReader
 2022-11-23 04:40:53 +00:00
Pokechu22
e13094766d Fix VertexLoader.cpp using the wrong size for texture matrix indices without a corresponding texture 
This regressed in 0a906f553f, I think (though I haven't confirmed it). Mario Tennis and Luigi's Mansion both use these for some reason (as far as I can tell, the data isn't actually used; it's just extra data included for no reason)
 2022-11-22 17:49:54 -08:00
Pokechu22
0bcd3c79bb VertexLoader: Eliminate use of DataReader 
DataReader is generally jank - it has a start and end pointer, but the end pointer is generally not used, and all of the vertex loaders mostly bypassed it anyways.

Wrapper code (the vertex loaer test, as well as Fifo.cpp and OpcodeDecoding.cpp) still uses it, as does the software vertex loader (which is not a subclass of VertexLoader). These can probably be eliminated later.
 2022-11-22 17:17:11 -08:00
Sam Belliveau
edb2c90b38
Improve FPS/VPS Counting and Revamp Appearance 2022-11-23 00:11:47 +01:00
Pokechu22
8f5a58f8be
Merge pull request #11285 from K0bin/cp-checks 
VideoCommon:VertexLoaderManager: Reduce CPConfig checks
 2022-11-21 15:35:06 -08:00
Robin Kertels
f179fd9c33
VideoCommon:VertexLoaderManager: Reduce CPConfig checks 
A bit of a micro optimization:
CheckCPConfiguration is called 350 times instead of 35k times.
 2022-11-18 01:42:30 +01:00
Pokechu22
1fdf15a1be VideoCommon/FramebufferManager: Rename m_efb_cache_tiles_wide to m_efb_cache_tile_row_stride 
This also initializes it in the non-tiled case just for consistency, although it's not actually read in that case.
 2022-11-15 16:04:41 -08:00
Pokechu22
55e1c3b51d VideoCommon/FramebufferManager: use !IsUsingTiledEFBCache() in GetEFBCacheTileRect 
This is for readability only, and should behave identically.
 2022-11-15 15:48:56 -08:00
Pokechu22
90d05fe37e VideoCommon/FramebufferManager: Always update frame access mask on depth peeks 
0e02ddcf52 removed separate logic for tiled versus non-tiled EFB peek caches, and as part of that made it so that color peeks updated the frame access mask even when a non-tiled cache is in use. However, the same change was not made for depth peeks. I'm not sure if this affected anything in practice.
 2022-11-15 15:34:03 -08:00
JMC47
8a1c28be63
Merge pull request #11172 from K0bin/efb-refresh 
VideoCommon:FramebufferManager: Mark cache as valid after refresh
 2022-11-15 16:33:46 -05:00
TellowKrinkle
37a51f1d09 VideoCommon: Add an option to disable mipmaps 
Needed by M1 fifoci to work around a minor non-determinism bug
 2022-11-07 22:18:56 -06:00
Admiral H. Curtiss
a98df18947
VideoCommon: Hold ImGui lock while initializing and shutting down ImGui. 2022-11-06 21:48:55 +01:00
Admiral H. Curtiss
c931529e7a
Merge pull request #11225 from iwubcode/graphics-mod-textureload-callable 
VideoCommon: call texture load graphics mod hook when textures are loaded
 2022-11-06 18:58:51 +01:00
Admiral H. Curtiss
1348337277
Merge pull request #11246 from tellowkrinkle/PVDMemset 
VideoCommon: Zero PortableVertexDeclarations on initialization
 2022-11-06 18:54:21 +01:00
Admiral H. Curtiss
a36a5c1308
CoreTiming: Pass Core::System to Events. 2022-11-06 17:54:58 +01:00
TellowKrinkle
d9ed9ae331 VideoCommon: Zero PortableVertexDeclarations on initialization 
Fixes an issue where the default initializer wouldn't initialize padding, making for fun non-determinism
 2022-11-05 02:02:53 -05:00
Robin Kertels
0e02ddcf52
VideoCommon:FramebufferManager: Cleanup 2022-11-04 01:18:23 +01:00
Robin Kertels
371935d61e
VideoCommon:FramebufferManager: Mark cache as valid after refresh 
Otherwise we might never hit the early return
if either depth or color doesnt have any active
tiles.
 2022-11-04 01:18:23 +01:00
Pokechu22
fe559f3ed3 VideoCommon/Statistics: Require semicolons after statistics macros 
This is clearer and reduces IntelliSense problems.
 2022-10-29 15:39:41 -07:00
iwubcode
ea3e133200 VideoCommon: call texture load graphics mod hook when Dolphin loads a texture 2022-10-28 19:24:43 -05:00