H3cJP/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-03-18 19:32:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #14345 from TryTwo/cheat_search_work

Browse Source 
CheatSearch: Add ability to breakpoint the selected lines.
This commit is contained in:
Dentomologist 2026-03-12 12:35:51 -07:00 committed by GitHub
commit e550e1ff7c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 59 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
Source/Core/DolphinQt/CheatSearchWidget.cpp
View File

@ -33,10 +33,13 @@
#include "Core/CheatSearch.h"
#include "Core/ConfigManager.h"
#include "Core/Core.h"
#include "Core/PowerPC/BreakPoints.h"
#include "Core/PowerPC/PowerPC.h"
#include "Core/System.h"
#include "DolphinQt/Config/CheatCodeEditor.h"
#include "DolphinQt/Config/CheatWarningWidget.h"
#include "DolphinQt/Host.h"
#include "DolphinQt/QtUtils/WrapInScrollArea.h"
#include "DolphinQt/Settings.h"
@ -49,6 +52,32 @@ constexpr int ADDRESS_TABLE_COLUMN_INDEX_ADDRESS = 1;
constexpr int ADDRESS_TABLE_COLUMN_INDEX_LAST_VALUE = 2;
constexpr int ADDRESS_TABLE_COLUMN_INDEX_CURRENT_VALUE = 3;
namespace
{
int GetDataTypeByteSize(Cheats::DataType data_type)
{
switch (data_type)
{
case Cheats::DataType::U8:
case Cheats::DataType::S8:
return 1;
case Cheats::DataType::U16:
case Cheats::DataType::S16:
return 2;
case Cheats::DataType::U32:
case Cheats::DataType::S32:
case Cheats::DataType::F32:
return 4;
case Cheats::DataType::U64:
case Cheats::DataType::S64:
case Cheats::DataType::F64:
return 8;
default:
return 1;
}
}
} // namespace
CheatSearchWidget::CheatSearchWidget(Core::System& system,
std::unique_ptr<Cheats::CheatSearchSessionBase> session,
QWidget* parent)
@ -516,9 +545,38 @@ void CheatSearchWidget::OnAddressTableContextMenu()
RecreateGUITable();
});
if (m_last_value_session->GetAddressSpace() == PowerPC::RequestedAddressSpace::Virtual)
{
menu->addAction(tr("Add Read/Write Breakpoint(s)"), this,
[this]() { AddMemoryBreakpoints("rw"); });
menu->addAction(tr("Add Write Breakpoint(s)"), this, [this]() { AddMemoryBreakpoints("w"); });
menu->addAction(tr("Add Read Breakpoint(s)"), this, [this]() { AddMemoryBreakpoints("r"); });
}
menu->exec(QCursor::pos());
}
void CheatSearchWidget::AddMemoryBreakpoints(std::string_view type)
{
if (m_last_value_session->GetAddressSpace() != PowerPC::RequestedAddressSpace::Virtual)
return;
const int last_byte_offset = GetDataTypeByteSize(m_last_value_session->GetDataType()) - 1;
MemChecks::TMemChecksStr bps;
for (auto& item : GetSelectedAddressTableItems())
{
const u32 addr = item->data(ADDRESS_TABLE_ADDRESS_ROLE).toUInt();
std::string bp = fmt::format("{:08x} {:08x} nbl{}", addr, addr + last_byte_offset, type);
bps.push_back(bp);
}
auto& memchecks = m_system.GetPowerPC().GetMemChecks();
memchecks.AddFromStrings(bps);
emit Host::GetInstance()->PPCBreakpointsChanged();
}
void CheatSearchWidget::OnValueSourceChanged()
{
const auto filter_type = m_value_source_dropdown->currentData().value<Cheats::FilterType>();

1
Source/Core/DolphinQt/CheatSearchWidget.h
View File

@ -62,6 +62,7 @@ private:
void OnResetClicked();
void OnAddressTableItemChanged(QTableWidgetItem* item);
void OnAddressTableContextMenu();
void AddMemoryBreakpoints(std::string_view type);
void OnValueSourceChanged();
void OnDisplayHexCheckboxStateChanged();