H3cJP/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-11-17 06:42:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

DolphinAnalytics: Only call ReloadConfig in config changed callback when analytics enabled value changes

Browse Source 
Co-authored-by: Simonx22 <simon@oatmealdome.me>
This commit is contained in:
OatmealDome 2025-11-12 00:09:41 -05:00
parent 8495e01668
commit df5f351add
No known key found for this signature in database
GPG Key ID: A4BFAB0C67513B91
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Source/Core/Core/DolphinAnalytics.cpp
View File

@ -57,10 +57,19 @@ void DolphinAnalytics::AndroidSetGetValFunc(std::function<std::string(std::strin
DolphinAnalytics::DolphinAnalytics() DolphinAnalytics::DolphinAnalytics()
{ {
m_last_analytics_enabled = Config::Get(Config::MAIN_ANALYTICS_ENABLED);
ReloadConfig(); ReloadConfig();
MakeBaseBuilder(); MakeBaseBuilder();
m_config_changed_callback_id = Config::AddConfigChangedCallback([this] { ReloadConfig(); }); m_config_changed_callback_id = Config::AddConfigChangedCallback([this] {
bool current_analytics_enabled = Config::Get(Config::MAIN_ANALYTICS_ENABLED);
if (m_last_analytics_enabled != current_analytics_enabled)
{
m_last_analytics_enabled = current_analytics_enabled;
ReloadConfig();
}
});
} }
DolphinAnalytics::~DolphinAnalytics() DolphinAnalytics::~DolphinAnalytics()
@ -80,7 +89,7 @@ void DolphinAnalytics::ReloadConfig()
// Install the HTTP backend if analytics support is enabled. // Install the HTTP backend if analytics support is enabled.
std::unique_ptr<Common::AnalyticsReportingBackend> new_backend; std::unique_ptr<Common::AnalyticsReportingBackend> new_backend;
if (Config::Get(Config::MAIN_ANALYTICS_ENABLED)) if (m_last_analytics_enabled)
{ {
new_backend = std::make_unique<Common::HttpAnalyticsBackend>(ANALYTICS_ENDPOINT); new_backend = std::make_unique<Common::HttpAnalyticsBackend>(ANALYTICS_ENDPOINT);
} }

1
Source/Core/Core/DolphinAnalytics.h
View File

@ -203,4 +203,5 @@ private:
std::mutex m_reporter_mutex; std::mutex m_reporter_mutex;
Common::AnalyticsReporter m_reporter; Common::AnalyticsReporter m_reporter;
Config::ConfigChangedCallbackID m_config_changed_callback_id{}; Config::ConfigChangedCallbackID m_config_changed_callback_id{};
bool m_last_analytics_enabled = false;
}; };