H3cJP/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-16 04:07:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge d5648cf2cb into 18a78a9bab

Browse Source
This commit is contained in:
Tygyh 2025-05-25 13:22:32 +02:00 committed by GitHub
commit a088ad8426
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Source/Core/DolphinQt/FIFO/FIFOAnalyzer.cpp
View File

@ -324,6 +324,11 @@ public:
};
} // namespace
template<typename T>
bool IsTargetWithinTypeBounds(u8 target) {
return target >= std::numeric_limits<T>::min() && target <= std::numeric_limits<T>::max();
}
void FIFOAnalyzer::UpdateDetails()
{
// Clearing the detail list can update the selection, which causes UpdateDescription to be called
@ -365,6 +370,7 @@ void FIFOAnalyzer::UpdateDetails()
while (object_offset < object_size)
{
const u32 start_offset = object_offset;
ASSERT(IsTargetWithinTypeBounds<int>(start_offset));
m_object_data_offsets.push_back(start_offset);
object_offset += OpcodeDecoder::RunCommand(&fifo_frame.fifoData[object_start + start_offset],
@ -509,6 +515,10 @@ void FIFOAnalyzer::ShowSearchResult(size_t index)
const auto& result = m_search_results[index];
ASSERT(IsTargetWithinTypeBounds<int>(result.m_frame));
ASSERT(IsTargetWithinTypeBounds<int>(result.m_object_idx));
ASSERT(IsTargetWithinTypeBounds<int>(result.m_cmd));
QTreeWidgetItem* object_item =
m_tree_widget->topLevelItem(0)->child(result.m_frame)->child(result.m_object_idx);