H3cJP/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-10-19 08:55:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

RetroAchievements: Avoid uninitialized memory access

Browse Source 
Avoid creating and then destroying a leaderboard list when game is null,
as doing so causes an access to uninitialized memory due to a bug in
rcheevos.

This can be triggered by starting a game with an invalid or expired
login token.
This commit is contained in:
Dentomologist 2025-09-05 17:23:39 -07:00
parent 489952cf89
commit 85a89eb420
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Source/Core/Core/AchievementManager.cpp
View File

@ -1027,6 +1027,9 @@ void AchievementManager::LoadGameCallback(int result, const char* error_message,
OSD::Color::RED); OSD::Color::RED);
} }
if (game == nullptr)
return;
rc_client_set_read_memory_function(instance.m_client, MemoryPeeker); rc_client_set_read_memory_function(instance.m_client, MemoryPeeker);
instance.FetchGameBadges(); instance.FetchGameBadges();
instance.m_system.store(&Core::System::GetInstance(), std::memory_order_release); instance.m_system.store(&Core::System::GetInstance(), std::memory_order_release);