H3cJP/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-09-18 02:40:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #14500 from Sintendo/span2

Browse Source 
Replace `const std::vector&` arguments with `std::span`
This commit is contained in:
Jordan Woyak
2026-04-11 14:55:41 -05:00
committed by GitHub
parent 27e09633de f6a67aa6e7
commit 33f62b0f9f
79 changed files with 164 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/UnitTests/Core/DSP/DSPAssemblyTest.cpp
+3 -3
View File
@@ -13,7 +13,7 @@
#include <gtest/gtest.h>
static bool RoundTrippableDisassemble(const std::vector<u16>& code, std::string& text)
static bool RoundTrippableDisassemble(std::span<const u16> code, std::string& text)
{
DSP::AssemblerSettings settings;
settings.ext_separator = '\'';
@@ -29,7 +29,7 @@ static bool RoundTrippableDisassemble(const std::vector<u16>& code, std::string&
// This test goes from text ASM to binary to text ASM and once again back to binary.
// Then the two binaries are compared.
static bool RoundTrip(const std::vector<u16>& code1)
static bool RoundTrip(std::span<const u16> code1)
{
std::vector<u16> code2;
std::string text;
@@ -90,7 +90,7 @@ static bool SuperTrip(const char* asm_code)
}
// Assembles asm_code, and verifies that it matches code1.
static bool AssembleAndCompare(const char* asm_code, const std::vector<u16>& code1)
static bool AssembleAndCompare(const char* asm_code, std::span<const u16> code1)
{
std::vector<u16> code2;
if (!DSP::Assemble(asm_code, code2))