H3cJP/citra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
12,660 Commits 7 Branches 3 Tags 145 MiB
b89fb6e1be
Commit Graph

851 Commits

Author SHA1 Message Date
Lioncash
e28a5b0d18 configure_hotkey: Make IsUsedKey() a const member function 
This doesn't actually modify instance state of the dialog, so this can
be made const.
 2019-04-09 19:35:54 -04:00
bunnei
61f63bb994
Merge pull request #1957 from DarkLordZach/title-provider 
file_sys: Provide generic interface for accessing game data
 2019-04-09 19:16:37 -04:00
bunnei
1a3098f11a
Merge pull request #2132 from FearlessTobi/port-4437 
Port citra-emu/citra#4437: "citra-qt: Make hotkeys configurable via the GUI (Attempt 2)"
 2019-04-09 18:08:30 -04:00
Lioncash
b73e433dff yuzu/loading_screen: Resolve runtime Qt string formatting warnings 
In our error console, when loading a game, the strings:

QString::arg: Argument missing: "Loading...", 0
QString::arg: Argument missing: "Launching...", 0

would occasionally pop up when the loading screen was running. This was
due to the strings being assumed to have formatting indicators in them,
however only two out of the four strings actually have them.

This only applies the arguments to the strings that have formatting
specifiers provided, which avoids these warnings from occurring.
 2019-04-09 10:49:38 -04:00
zarroboogs
be6466d5c0 added a toggle to force 30fps mode 2019-04-09 02:14:03 +03:00
Lioncash
218ae888f3 yuzu/debugger: Remove graphics surface viewer 
This doesn't actually work anymore, and given how long it's been left in
that state, it's unlikely anyone actually seriously used it.

Generally it's preferable to use RenderDoc or Nsight to view surfaces.
 2019-04-05 23:54:00 -04:00
Lioncash
c0e320ad0d yuzu/debugger/graphics_surface: Display error messages for file I/O errors 2019-04-05 19:54:53 -04:00
Lioncash
845607481c yuzu/debugger/graphics_surface: Tidy up SaveSurface 
- Use QStringLiteral where applicable.

- Use const where applicable

- Remove unnecessary precondition check (we already assert the pixbuf
  being non null)
 2019-04-05 19:33:00 -04:00
Lioncash
bbeb859122 yuzu/debugger/graphics_surface: Clean up connection overload deduction 
We can utilize qOverload with the signal connections to make the
function deducing a little less ugly.
 2019-04-05 19:26:43 -04:00
Lioncash
9d296f8a35 yuzu/debugger/graphics_surface: Fill in missing surface format listings 
Fills in the missing surface types that were marked as unknown. The
order corresponds with the TextureFormat enum within
video_core/texture.h.

We also don't need to all of these strings as translatable (only the
first string, as it's an English word).
 2019-04-05 19:09:56 -04:00
bunnei
9959c95966
Merge pull request #2331 from lioncash/cache 
yuzu/main: Minor adjustments to OnTransferableShaderCacheOpenFile()
 2019-04-04 22:35:53 -04:00
Lioncash
e8f3d85ea5 yuzu/main: Remove unnecessary includes 
While we're at it, don't use <QtGui> and <QtWidgets> and instead include
exactly which headers we actually need.
 2019-04-04 11:29:19 -04:00
Lioncash
e5bb07a973 yuzu/main: Use QStringLiteral where applicable within OnTransferableShaderCacheOpenFile() 
Allows these strings to have no allocation cost when used at runtime.
 2019-04-04 00:12:55 -04:00
Lioncash
5ba5f82082 yuzu/main: Tidy up the error dialog string in OnTransferableShaderCacheOpenFile() 
Rather than scream that the file doesn't exist, we can clearly state
what specifically doesn't exist, to avoid ambiguity, and make it easier
to understand for non-primary English speakers/readers.
 2019-04-04 00:12:04 -04:00
Lioncash
3f8c9b25d8 yuzu/main: Remove unnecessary string concatenation in OnTransferableShaderCacheOpenFile() 
We can just make the trailing portion of the string part of the
formatting, getting rid of the need to make another temporary string.
 2019-04-03 23:58:58 -04:00
Lioncash
872d480c60 yuzu/main: Make open_target a QString 
Simplifies the amount of string conversions necessary. We also don't
need to log out what occurs here.
 2019-04-03 23:55:57 -04:00
Lioncash
ba4e1adda1 yuzu/main: Use static variant of QFile's exists() 
There's no need to construct a QFile instance just to check for its
existence.
 2019-04-03 23:53:31 -04:00
bunnei
a56c4ac91b
Merge pull request #2095 from FreddyFunk/open-transferable-shader-cache 
frontend: Open transferable shader cache for a selected game in the gamelist
 2019-04-03 21:51:50 -04:00
bunnei
908f24eb88
Merge pull request #2323 from lioncash/include 
yuzu/debugger/profiler: Remove unnecessary includes
 2019-04-03 12:08:16 -04:00
Lioncash
65ae1ac4e5 yuzu/applets/software_keyboard: Use QDialogButtonBox standard buttons instead of custom buttons 
Like the previous change, this allows Qt to handle proper translations
of the UI buttons, rather than us needing to handle it.
 2019-04-03 11:17:10 -04:00
Lioncash
a504bad3fb yuzu/applets/profile_select: Use QDialogButtonBox standard buttons instead of custom buttons 
Makes for shorter code, while also not requiring the buttons to be
directly translated, they'll be handled by Qt itself.
 2019-04-03 11:15:54 -04:00
Lioncash
6b629f4816 yuzu/debugger/profiler: Remove unnecessary includes 
Moves includes into the cpp file where necessary. This way,
microprofile-related stuff isn't dumped into other UI-related code when
the dialog header gets included.
 2019-04-03 10:07:12 -04:00
bunnei
62860dc0b0
Merge pull request #2301 from FearlessTobi/remove-amiibo-setting 
core/yuzu: Remove enable_nfc setting
 2019-04-01 15:02:08 -04:00
Lioncash
781ab8407b general: Use deducation guides for std::lock_guard and std::unique_lock 
Since C++17, the introduction of deduction guides for locking facilities
means that we no longer need to hardcode the mutex type into the locks
themselves, making it easier to switch mutex types, should it ever be
necessary in the future.
 2019-04-01 12:53:47 -04:00
fearlessTobi
ff7e6a42c1 core/yuzu: Remove enable_nfc setting 
This was initially added to prevent problems from stubbed/not implemented NFC services, but as we never encountered such and as it's only used in a deprecated function anyway, I guess we can just remove it to prevent more clutter of the settings.
 2019-03-29 15:02:28 +01:00
bunnei
f770c17d01
Merge pull request #2266 from FernandoS27/arbitration 
Kernel: Fixes to Arbitration and SignalProcessWideKey Management
 2019-03-28 21:42:24 -04:00
Zach Hilman
41d2565f29 game_list: Register content with ContentProvider 2019-03-26 22:05:37 -04:00
ReinUsesLisp
9ebc27234d bootmanager: Bypass input focus issues 2019-03-25 17:10:34 -03:00
ReinUsesLisp
bbb396d7f1 bootmanager: Bypass resizing issue 2019-03-25 17:10:34 -03:00
ReinUsesLisp
9ff72ca9f2 bootmanager: Delete container to avoid crash on game restarting 
While we are at it, remove nullptr checks for deletion, since the C++
standard defines that delete does it by its own
 2019-03-25 17:10:34 -03:00
bunnei
241563d15c gpu: Move GPUVAddr definition to common_types. 2019-03-20 22:36:02 -04:00
bunnei
c1409602da
Merge pull request #2239 from FearlessTobi/port-4684 
Port citra-emu/citra#4684: "frontend: qt: fix a freeze where if you click on entry in the game list too fast, citra will hang"
 2019-03-20 21:33:05 -04:00
Fernando Sahmkow
acbdfdae64 Add CondVar Thread State. 2019-03-19 20:32:47 -04:00
bunnei
574e89d924 video_core: Refactor to use MemoryManager interface for all memory access. 
# Conflicts:
#	src/video_core/engines/kepler_memory.cpp
#	src/video_core/engines/maxwell_3d.cpp
#	src/video_core/morton.cpp
#	src/video_core/morton.h
#	src/video_core/renderer_opengl/gl_global_cache.cpp
#	src/video_core/renderer_opengl/gl_global_cache.h
#	src/video_core/renderer_opengl/gl_rasterizer_cache.cpp
 2019-03-16 00:38:48 -04:00
Adityarup Laha
57a4a2ae0f yuzu: Make hotkeys configurable via the GUI 
* Adds a new Hotkeys tab in the Controls group.
* Double-click a Hotkey to rebind it.
 2019-03-16 03:55:57 +01:00
bunnei
06ac6460d3
Merge pull request #2048 from FearlessTobi/port-3924 
Port citra-emu/citra#3924: "citra_qt: Settings (configuration) rework"
 2019-03-15 22:23:38 -04:00
liushuyu
59f16f2e02 frontend: qt: fix a freeze where if you click on entry in the game list too fast, citra will hang 2019-03-15 16:10:21 +01:00
bunnei
0a923b4ab3
Merge pull request #2187 from FearlessTobi/port-sdl-things 
Port various Citra changes to input_common, including deadzone support
 2019-03-13 11:46:57 -04:00
bunnei
3b63a46ca4
Merge pull request #2196 from DarkLordZach/web-applet-esc 
web_browser: Add shortcut to Enter key to exit applet
 2019-03-07 15:32:32 -05:00
bunnei
1a4d733ec7
Merge pull request #2205 from FearlessTobi/docked-undocked-hotkey 
yuzu: add a hotkey to switch between undocked and docked mode
 2019-03-07 11:33:24 -05:00
zhupengfei
39e895c5ff citra_qt: Settings (configuration) rework 2019-03-07 16:55:50 +01:00
bunnei
4f352833a5
Merge pull request #2055 from bunnei/gpu-thread 
Asynchronous GPU command processing
 2019-03-07 10:41:53 -05:00
bunnei
65651078e5 bootmanager: Ensure that we have a context for shader loading. 2019-03-06 21:48:56 -05:00
bunnei
d2ff93c319
Merge pull request #2190 from lioncash/ogl-global 
core: Remove the global telemetry accessor function
 2019-03-06 21:41:53 -05:00
bunnei
d6015ee211 settings: Add new graphics setting for use_asynchronous_gpu_emulation. 2019-03-06 21:09:09 -05:00
fearlessTobi
c8d6f0cb82 yuzu: add a hotkey to switch between undocked and docked mode 2019-03-06 19:31:23 +01:00
Lioncash
196cc82913 yuzu/debugger/wait_tree: Remove use of global CurrentProcess accessor 
We already have the thread instance that was created under the current
process, so we can just pass the handle table of it along to retrieve
the owner of the mutex.
 2019-03-05 21:52:21 -05:00
Zach Hilman
4130b07f88 web_browser: Add shortcut to Enter key to exit applet 
Addresses issues where a user in fullscreen could not exit some web applets without leaving fullscreen.
 2019-03-04 18:26:28 -05:00
Lioncash
319365fdf0 yuzu: Remove usage of the global telemetry accessor 
In these cases the system object is nearby, and in the other, the
long-form of accessing the telemetry instance is already used, so we can
get rid of the use of the global accessor.
 2019-03-04 10:24:13 -05:00
Mat M
169d19f7b9
Merge pull request #2154 from FearlessTobi/port-4647 
Port citra-emu/citra#4647: "citra_qt/main: make SPEED_LIMIT_STEP static constexpr"
 2019-03-02 14:46:04 -05:00
James Rowe
09ac66388c Input: Remove global variables from SDL Input 
Changes the interface as well to remove any unique methods that
frontends needed to call such as StartJoystickEventHandler by
conditionally starting the polling thread only if the frontend hasn't
started it already. Additionally, moves all global state into a single
SDLState class in order to guarantee that the destructors are called in
the proper order
 2019-03-02 19:09:34 +01:00
fearlessTobi
71c30a0a89 citra_qt/main: make SPEED_LIMIT_STEP static constexpr 
MSVC does not seem to like using constexpr values in a lambda that were declared outside of it.
Previously on MSVC build the hotkeys to inc-/decrease the speed limit were not working correctly because in the lambda the SPEED_LIMIT_STEP had garbage values.
After googling around a bit I found: https://github.com/codeplaysoftware/computecpp-sdk/issues/95 which seems to be a similar issue.
Trying the suggested fix to make the variable static constexpr also fixes the bug here.
 2019-03-02 17:43:19 +01:00
Lioncash
456c7043bd yuzu/compatdb: Remove unused lambda capture 
Silences a compiler warning with clang.
 2019-02-27 11:30:36 -05:00
Lioncash
1b855efd5e common/vector_math: Move Vec[x] types into the Common namespace 
These types are within the common library, so they should be using the
Common namespace.
 2019-02-26 22:38:36 -05:00
unknown
f27c65eb91 Use QString instead of std::string where applicable 2019-02-08 14:18:41 +01:00
Mat M
996ddb202b
Use constexpr char array instead of string where applicable 
Co-Authored-By: FreddyFunk <frederic.laing.development@gmail.com>
 2019-02-08 14:03:10 +01:00
unknown
9d411699d8 frontend: Open transferable shader cache for a selected game in the gamelist 2019-02-08 09:05:51 +01:00
ReinUsesLisp
bd928e70ed loading_screen: Unchunk progress bar 2019-02-06 22:23:40 -03:00
ReinUsesLisp
eb73247433 gl_shader_cache: Link loading screen with disk shader cache load 2019-02-06 22:23:40 -03:00
ReinUsesLisp
e78da8dc1f settings: Hide shader cache behind a setting 2019-02-06 22:20:57 -03:00
bunnei
c357d8f6f7
Merge pull request #2057 from FearlessTobi/port-4586 
Port citra-emu/citra#4586: "Use QPixmap/QIcon for background color selection button"
 2019-02-06 12:37:57 -05:00
bunnei
b34ae2235d
Merge pull request #2086 from FearlessTobi/port-4583 
Port citra-emu/citra#4583: "citra_qt: Fix saving screenshot when no file extension is provided"
 2019-02-06 12:33:35 -05:00
bunnei
67c1f31251
Merge pull request #2088 from jroweboy/h 
QT: Fix the loading screen 'H' switch logo to not glitch out
 2019-02-05 21:06:39 -05:00
James Rowe
c82b0afb69 QT: Fix the loading screen 'H' switch logo to not glitch out 2019-02-05 18:24:15 -07:00
xperia64
f598490b57 Fix crash when no files are selected 2019-02-05 22:40:23 +01:00
xperia64
284536a626 Add file extension to screenshot filename if not provided 2019-02-05 22:31:37 +01:00
Lioncash
414cc1eb1f kernel: Remove the Timer class 
A holdover from citra, the Horizon kernel on the switch has no
prominent kernel object that functions as a timer. At least not
to the degree of sophistication that this class provided.

As such, this can be removed entirely. This class also wasn't used at
all in any meaningful way within the core, so this was just code sitting
around doing nothing. This also allows removing a few things from the
main KernelCore class that allows it to use slightly less resources
overall (though very minor and not anything really noticeable).
 2019-01-31 23:05:15 -05:00
xperia64
32eb080e02 Use QPixmap/QIcon for background color selection button 2019-01-26 15:08:54 +01:00
bunnei
f574d324e7
Merge pull request #2054 from bunnei/scope-context-refactor 
frontend: Refactor ScopeAcquireWindowContext out of renderer_opengl.
 2019-01-23 21:20:08 -05:00
bunnei
045b0b70b6 frontend: Refactor ScopeAcquireWindowContext out of renderer_opengl. 2019-01-23 19:19:23 -05:00
zhupengfei
a94a828b6c citra_qt: Log settings on launch 2019-01-22 23:35:38 +01:00
James Rowe
5f2d9f282a QT: Hide GLWidget immediately after showing. 
With the loading screen merged, we don't want to actually show at this
point, but it still needs to be shown to actually create the context.
Turns out you can just show and hide it immediately and it'll work.
 2019-01-21 16:21:44 -07:00
James Rowe
c6a0ab9792 QT Frontend: Migrate to QOpenGLWindow 2019-01-21 16:00:01 -07:00
bunnei
839c4a8a1c
Merge pull request #2035 from lioncash/fwd-decl 
yuzu/configuration: Remove unnecessary inclusions where applicable
 2019-01-21 17:31:07 -05:00
James Rowe
3049ea45d3 Change const char* to const char[] 2019-01-21 10:28:32 -07:00
James Rowe
372245e0b5 Fix mingw compile error and warnings 2019-01-21 09:39:45 -07:00
James Rowe
3ca0af8bb3 Add fade out effect to the loading screen 2019-01-21 09:20:16 -07:00
James Rowe
3740adb6f5 Set Minimum Size to the same as renderwindow 2019-01-21 08:51:37 -07:00
James Rowe
aa427bb2a7 Remove blue box around loading screen 2019-01-21 08:50:23 -07:00
James Rowe
636cc2a496 Change the background color of Stage Complete to yuzu blue 2019-01-20 19:14:14 -07:00
James Rowe
ea73ffe202 Rename step 1 and step 2 to be a little more descriptive 2019-01-20 18:40:25 -07:00
James Rowe
56541b1ae5 Prevent estimated time from flashing after slow shader compilation starts 2019-01-20 18:31:35 -07:00
James Rowe
4bce57b149 Move progress bar style into constexpr strings 2019-01-20 18:20:21 -07:00
James Rowe
63783db1b3 Hide progress bar on Prepare step 2019-01-20 15:09:14 -07:00
James Rowe
e8bd6b1fcc QT: Upgrade the Loading Bar to look much better 2019-01-20 14:47:35 -07:00
bunnei
1c733bf175
Merge pull request #2034 from jroweboy/loading-widget 
QT Frontend: Add a Loading screen with progressbar
 2019-01-20 15:45:07 -05:00
bunnei
eff61c5c42
Merge pull request #2032 from lioncash/web 
yuzu/configuration/configure_web: Amend verification string
 2019-01-20 13:26:47 -05:00
James Rowe
69da267540 Add a workaround if QMovie isn't available 2019-01-19 23:34:03 -07:00
James Rowe
08fcf41b0a QT Frontend: Add a Loading screen with progressbar 
With shader caches on the horizon, one requirement is to provide visible
feedback for the progress. The shader cache reportedly takes several
minutes to load for large caches that were invalidated, and as such we
should provide a loading screen with progress.

Adds a loading screen widget that will be shown until the first frame of
the game is swapped. This was chosen in case shader caches are not being
used, several games still take more than a few seconds to launch and
could benefit from a loading screen.
 2019-01-19 23:34:03 -07:00
Lioncash
faf69a22d4 yuzu/configuration/configure_input_player: Forward declare types where applicable 
Allows removing the inclusion of the main input common header from the
UI config header.
 2019-01-17 12:08:15 -05:00
Lioncash
609e98bc63 yuzu/configuration/configure_touchscreen_advanced: Remove unnecessary header inclusions 2019-01-17 12:02:01 -05:00
Lioncash
a0f615f232 yuzu/configuration/configure_per_general: Remove unused header inclusions 2019-01-17 11:58:43 -05:00
Lioncash
ac754a57d2 yuzu/configuration/configure_debug: Remove unused header inclusions 2019-01-17 11:51:47 -05:00
Lioncash
3629fcf3e6 yuzu/configuration/configure_system: Remove unused header inclusions 2019-01-17 11:50:57 -05:00
Lioncash
549164d425 yuzu/configuration/configure_web: Remove an unused lambda capture 
'this' isn't actually used within the lambda, since what we need
from the class is already assigned within the capture section of
the lambda.
 2019-01-17 11:39:49 -05:00
Lioncash
b8b87ec01f yuzu/configuration/configure_web: Use an ellipsis with 'Verifying' text 
It's a common UI pattern to use an ellipsis to indicate an ongoing
action, rather than just specifying the word by itself.
 2019-01-17 11:35:59 -05:00
Lioncash
a661025637 core/frontend/applets/web_browser: Make OpenPage() non-const 
This is a function that definitely doesn't always have a non-modifying
behavior across all implementations, so this should be made non-const.

This gets rid of the need to mark data members as mutable to work around
the fact mutating data members needs to occur.
 2019-01-17 11:19:52 -05:00
Lioncash
66978a772d yuzu/web_browser: std::move std::function instances in OpenPage() 
Avoids the need to potentially reallocate the contained callbacks.
 2019-01-17 11:10:35 -05:00
Lioncash
e4fa77ef6a yuzu/web_browser: Make slot functions private 
These currently aren't used by anything other than the QtWebBrowser
class itself, and can be made private.
 2019-01-17 11:08:05 -05:00
bunnei
bc879ae880
Merge pull request #1848 from FreddyFunk/QJsonArray 
game_list: Remove a reference of a reference
 2019-01-12 02:01:13 -05:00
bunnei
c9ef8b0af1
Merge pull request #1959 from DarkLordZach/custom-rtc 
settings: Add support for setting the RTC manually
 2019-01-10 17:05:21 -05:00
bunnei
83e8ad2331
Merge pull request #1939 from DarkLordZach/web-applet 
applets: Implement HLE web browser applet (LibAppletOff)
 2019-01-10 17:04:38 -05:00
Zach Hilman
ac7d8983eb settings: Fix comment structure 2019-01-07 19:40:28 -05:00
Zach Hilman
05dbb47af5 settings: Use std::chrono::seconds instead of s64 for RTC 2019-01-07 19:19:40 -05:00
Zach Hilman
26c9f12271 qt: Provide UI to edit custom RTC settings 2019-01-07 19:19:40 -05:00
Zach Hilman
c6016856d8 settings: Add custom RTC settings 
Stored as signed seconds since epoch.
 2019-01-07 19:18:45 -05:00
Zach Hilman
54d7b664da qt: Move profile manager to own UI tab 2019-01-04 17:32:13 -05:00
David Marcec
4f41fd84ff Removed pulse event type 
Pulse is considered a hack and nothing should be using it. We should completely remove it
 2019-01-04 20:47:20 +11:00
bunnei
a6aa710b84
Merge pull request #1942 from DarkLordZach/profile-select-game-boot 
qt: Add setting to prompt for user on game boot
 2019-01-02 21:05:27 -05:00
bunnei
11f990975c
Merge pull request #1941 from DarkLordZach/profile-select-save-data 
qt: Use ProfileSelectionDialog when selecting user for save data
 2019-01-02 21:05:02 -05:00
bunnei
6a0e258dde
Merge pull request #1944 from FearlessTobi/port-4187 
Port citra-emu/citra#4187: "Qt/Configure: Use sidebar to divide tabs into smaller groups"
 2019-01-02 17:24:38 -05:00
Lioncash
cd8924520c yuzu/configure_general: Silence truncation warnings in loadConfiguration() 
The QPixmap API expects an unsigned int.
 2018-12-31 19:14:48 -05:00
Lioncash
f5f35caf20 yuzu/config: Silence truncation warnings 2018-12-31 19:11:29 -05:00
Zach Hilman
0c5ede492f travis: Use correct package for linux Qt5WebEngine 2018-12-28 19:29:49 -05:00
Zach Hilman
cb930c4b5a web_browser: Add bounds checking to applet interface 2018-12-28 18:20:29 -05:00
Zach Hilman
45da3be40e main: Add main window integrations for QtWebBrowserApplet 2018-12-28 15:32:39 -05:00
Zach Hilman
e00e1fc755 qt: Implement Qt frontend to web browser 
Using a custom reimplementation of QWebEngineView and an injector script.
 2018-12-28 15:32:39 -05:00
Lioncash
f80bc712ea kernel: Rename 'default' CPU core to 'ideal' core 
This makes the naming more closely match its meaning. It's just a
preferred core, not a required default core. This also makes the usages
of this term consistent across the thread and process implementations.
 2018-12-27 21:48:49 -05:00
spycrab
c6da772b24 Qt/Configure: Use sidebar to divide tabs into smaller groups 2018-12-28 01:14:57 +01:00
Zach Hilman
c643f364b4 am: Implement GetSaveDataSize and ExtendSaveData 
These functions come in a pair and are needed by Smash Ultimate, Minecraft, and Skyrim, amongst others.
 2018-12-27 00:18:00 -05:00
bunnei
17fa0ffff9
Merge pull request #1948 from lioncash/translatable 
configure_per_general: Mark UI strings as translatable in the constructor
 2018-12-26 20:39:30 -05:00
Lioncash
0c18d47348 configure_per_general: Mark UI strings as translatable in the constructor 
These are user-facing strings, so they should be translatable.
 2018-12-26 17:45:15 -05:00
Lioncash
faa9110541 configure_input_simple: Make input profile array constexpr 
Calling tr() from a file-scope array isn't advisable, since it can be
executed before the Qt libraries are even fully initialized, which can
lead to crashes.

Instead, the translatable strings should be annotated, and the tr()
function should be called at the string's usage site.
 2018-12-26 17:36:36 -05:00
bunnei
ae582b6669
Merge pull request #1849 from encounter/svcSetThreadActivity 
svc: Implement SetThreadActivity (thread suspension)
 2018-12-26 15:54:14 -05:00
Zach Hilman
9c2d83cb9c qt: Use ProfileSelectionDialog when selecting user for save data 
This allows us to present a much nicer UI to the user over a simple combo box and is made easy with the modular nature of the profile-selection applet frontend.
 2018-12-25 10:52:50 -05:00
Zach Hilman
4d61ac08aa qt: Add setting to prompt for user on game boot 
Using the QtProfileSelectorDialog, this implementation is trivial. This mimics the real switch behavior of asking which user on every game boot, but it is default disabled as that might get inconvenient.
 2018-12-25 10:42:14 -05:00
bunnei
9a22a94a51
Merge pull request #1886 from FearlessTobi/port-4164 
Port citra-emu/citra#4164: "citra_qt, video_core: Screenshot functionality"
 2018-12-23 14:36:51 -05:00
bunnei
f95f6c7d86
Merge pull request #1781 from DarkLordZach/applet-profile-select 
am: Implement HLE profile selector applet
 2018-12-23 14:35:13 -05:00
bunnei
d08bdc861f
Merge pull request #1780 from DarkLordZach/controller-profiles 
configure_input: Add Controller Setup Profiles and simplify input UI
 2018-12-23 14:34:29 -05:00
David Marcec
fdd649e2ef Fixed uninitialized memory due to missing returns in canary 
Functions which are suppose to crash on non canary builds usually don't return anything which lead to uninitialized memory being used.
 2018-12-19 12:52:32 +11:00
zhupengfei
a2be49305d yuzu, video_core: Screenshot functionality 
Allows capturing screenshot at the current internal resolution (native for software renderer), but a setting is available to capture it in other resolutions. The screenshot is saved to a single PNG in the current layout.
 2018-12-18 22:54:41 +01:00
bunnei
b88430c299
Merge pull request #1902 from lioncash/audio 
audio_core: Make g_sink_details internally linked
 2018-12-14 21:48:17 -05:00
bunnei
7d39b19edc
Merge pull request #1871 from lioncash/move 
yuzu/wait_tree: Pass QString by value and std::move in the initializer list for WaitTreeText
 2018-12-14 13:13:32 -05:00
Lioncash
6beb823f15 audio_core: Make g_sink_details internally linked 
We can hide the direct array from external view and instead provide
functions to retrieve the necessary info. This has the benefit of
completely hiding the makeup of the SinkDetails structure from the rest
of the code.

Given that this makes the array hidden, we can also make the array
constexpr by altering the members slightly. This gets rid of several
static constructor calls related to std::vector and std::function.

Now we don't have heap allocations here that need to occur before the
program can even enter main(). It also has the benefit of saving a
little bit of heap space, but this doesn't matter too much, since the
savings in that regard are pretty tiny.
 2018-12-13 16:44:32 -05:00
bunnei
2c45c6d234
Merge pull request #1819 from DarkLordZach/disable-addons 
patch_manager: Add support for disabling patches
 2018-12-10 21:52:19 -05:00
bunnei
f85134021f
Merge pull request #1873 from lioncash/const 
loaders: Make GetFileType() a const qualified member function
 2018-12-07 18:15:30 -05:00
Lioncash
17b4355391 yuzu/wait_tree: Pass QString by value and std::move in the initializer list for WaitTreeText 
Just a trivial modernization that potentially avoids copying strings in certain scenarios.
 2018-12-05 18:34:03 -05:00
Lioncash
01bf329f63 yuzu/game_list_worker: Don't retrieve the file type twice in AddFstEntriesToGameList() 
Similarly, here we can avoid doing unnecessary work twice by retrieving
the file type only once and comparing it against relevant operands,
avoiding potential unnecessary object construction/destruction.
 2018-12-05 17:58:15 -05:00
Lioncash
de095ded5c yuzu/game_list_worker: Don't retrieve file type and file type strings twice in MakeGameListEntry() 
While GetFileType() is indeed a getter function, that doesn't mean it's
a trivial function, given some case require reading from the data or
constructing other objects in the background. Instead, only do necessary
work once.
 2018-12-05 17:49:37 -05:00
Zach Hilman
c07059e7fd configure_input_simple: Properly signal docked mode change 2018-12-05 14:05:57 -05:00
Zach Hilman
233a804196 configure_input: Add ConfigureInputSimple as default input UI config 
Greatly simplifies the current input UI, while still allowing power users to tweak advanced settings. Adds 'input profiles', which are easy autoconfigurations to make getting started easy and fast. Also has a custom option which brings up the current, full UI.
 2018-12-05 14:02:02 -05:00
Zach Hilman
59ca8d458d configure_input: Convert into QDialog 2018-12-05 14:02:02 -05:00
Zach Hilman
20dffc22a2 configure: Use ConfigureInputSimple for Input tab 2018-12-05 14:02:02 -05:00
Zach Hilman
281b64daf4 ui_settings: Add UI setting for input profile index 2018-12-05 14:02:02 -05:00
Lioncash
e90fa1ac54 configuration/config: Use an intermediary variable for accessing players 
Avoids typing the same long accessor just to retrieve player attributes.
 2018-12-05 03:41:33 -05:00
bunnei
af286294f9
Merge pull request #1837 from lioncash/map 
yuzu/game_list_worker: Minor cleanup and code deduplication
 2018-12-04 19:57:41 -05:00
Lioncash
a49fd7fd57 yuzu/game_list_worker: Move std::string construction after the termination check in callbacks 
Avoids potentially allocating a std::string instance when it isn't
needed.
 2018-12-04 18:39:35 -05:00
Zach Hilman
f6f6503578 qt: Add Properties menu to game list right-click 2018-12-04 13:34:50 -05:00
Luke Street
a3d78b77f8 debugger: Set paused thread color 2018-12-04 02:25:34 -05:00
Lioncash
5eb057f422 kernel/object: Amend handle types to distinguish between readable and writable events 
Two kernel object should absolutely never have the same handle ID type.
This can cause incorrect behavior when it comes to retrieving object
types from the handle table. In this case it allows converting a
WritableEvent into a ReadableEvent and vice-versa, which is undefined
behavior, since the object types are not the same.

This also corrects ClearEvent() to check both kernel types like the
kernel itself does.
 2018-12-04 02:20:47 -05:00
Luke Street
3e75175d02 svc: Implement SetThreadActivity (thread suspension) 2018-12-04 01:23:50 -05:00
Zach Hilman
e11e65b3d6 applets: Correct event ResetTypes from OneShot to Sticky 
Fixes bugs relating to signalling in software keyboard.
 2018-12-03 17:27:40 -05:00
Zach Hilman
bf90f2402d qt: Implement GUI dialog frontend for ProfileSelector 
Presents profiles in a list, similar to switch.
 2018-12-03 17:26:27 -05:00
Zach Hilman
6deccc7e6b qt: Register to use Qt ProfileSelector instead of default 2018-12-03 17:26:27 -05:00
Zach Hilman
60e27252a5 qt: Add UI to display game properties and disable add-ons 2018-12-03 17:21:25 -05:00
Zach Hilman
c381f46428 config: Store and load disabled add-ons list 2018-12-03 17:20:34 -05:00
bunnei
76525013c0
Merge pull request #1842 from lioncash/slot 
yuzu/configuration: Minor clean-up related changes
 2018-12-03 17:12:01 -05:00
bunnei
f6b22d9251
Merge pull request #1835 from lioncash/cache-global 
filesystem: De-globalize registered_cache_union
 2018-12-03 17:11:26 -05:00
bunnei
ef69b4b830
Merge pull request #1803 from DarkLordZach/k-able-event 
kernel: Divide Event into ReadableEvent and WritableEvent
 2018-12-03 17:05:57 -05:00
Frederic Laing
6d7514ccec game_list: Remove a reference of a reference 2018-12-03 19:26:36 +01:00
Lioncash
195cad9635 yuzu/configuration: Make slots private where applicable 
These slots are only ever attached to event handling mechanisms within
the class itself, they're never used externally. Because of this, we can
make the functions private.

This also removes redundant usages of the private access specifier.
 2018-12-02 14:18:36 -05:00
Lioncash
eabfb7730d yuzu/configuration: Add missing override specifiers to configuration-related classes 
Resolves trivial compiler warnings.
 2018-12-02 14:18:36 -05:00
Lioncash
f3253d0f14 yuzu/configuration/configure_input: Default destructor in the cpp file 
The previous code could potentially be a compilation issue waiting to
occur, given we forward declare the type for a std::unique_ptr. If the
complete definition of the forward declared type isn't visible in a
translation unit that the class is used in, then it would fail to
compile.

Defaulting the destructor in a cpp file ensures the std::unique_ptr's
destructor is only invoked where its complete type is known.
 2018-12-02 14:18:26 -05:00
bunnei
a6805e58ce
Merge pull request #1795 from ReinUsesLisp/vc-cleanup 
video_core: Minor style changes
 2018-12-01 23:46:18 -05:00
Lioncash
db4523f1ec filesystem: De-globalize registered_cache_union 
We can just return a new instance of this when it's requested. This only
ever holds pointers to the existing registed caches, so it's not a large
object. Plus, this also gets rid of the need to keep around a separate
member function just to properly clear out the union.

Gets rid of one of five globals in the filesystem code.
 2018-12-01 23:43:23 -05:00
Lioncash
8c108eaca7 yuzu/game_list_worker: Deduplicate game list entry creation 
Avoids duplicating the same code twice verbatim.
 2018-12-01 23:23:39 -05:00
Lioncash
f1ecfcb8bc yuzu/game_list_worker: Tidy up string handling in FillControlMap() 
We don't need to call out to our own file handling functions when we're
going to construct a QFileInfo instance right after it. We also don't
need to convert to a std::string again just to compare the file
extension.
 2018-12-01 22:49:00 -05:00
Bartosz Kaszubowski
5f07ca3dce remove border from GameList 2018-11-30 23:35:08 +01:00
Lioncash
4b950728fd configure_input: Amend clang-format discrepancies 2018-11-30 03:31:56 -05:00
Zach Hilman
a342bcc9b1 kernel/event: Reference ReadableEvent from WritableEvent 2018-11-29 08:48:40 -05:00
Zach Hilman
ff610103b5 core: Port all current usages of Event to Readable/WritableEvent 2018-11-29 08:45:41 -05:00
bunnei
7befe0134d
Merge pull request #1768 from greggameplayer/patch-2 
Uncheck automatically joycons docked when docked mode is enable
 2018-11-29 01:00:09 -05:00
ReinUsesLisp
22c7c710b4 gl_rasterizer: Remove extension booleans 2018-11-28 21:18:13 -03:00
bunnei
adb882bf90
Merge pull request #1814 from lioncash/ptr 
file_sys/registered_cache: Use regular const references instead of std::shared_ptr for InstallEntry()
 2018-11-27 19:20:12 -05:00
Lioncash
2a22c1b27e yuzu/configure_input_player: Use std::size_t to represent the player index instead of u8 
Prevents compiler warnings related to truncation when invoking the
dialog. It's also extremely suspect to use a u8 value here instead of a
more general type to begin with.
 2018-11-27 16:37:21 -05:00
Lioncash
0782d3971b yuzu/configure_input: Make CallConfigureDialog a non-member template function 
This doesn't depend on any part of the private interface, so it can be
made a non-member internal function.
 2018-11-27 16:37:18 -05:00
Lioncash
d72c809030 file_sys/registered_cache: Use regular const references instead of std::shared_ptr for InstallEntry() 
These parameters don't need to utilize a shared lifecycle directly in
the interface. Instead, the caller should provide a regular reference
for the function to use. This also allows the type system to flag
attempts to pass nullptr and makes it more generic, since it can now be
used in contexts where a shared_ptr isn't being used (in other words, we
don't constrain the usage of the interface to a particular mode of
memory management).
 2018-11-27 16:33:14 -05:00
Lioncash
11cf13a6e1 yuzu/configure_input_player: Use a lambda expression instead of std::bind 
std::bind is the pre-C++11 way of doing this.
 2018-11-27 05:08:13 -05:00
Lioncash
73a48d6523 yuzu/configure_input_player: Amend constructor initializer list order 
Orders the elements the way they would actually be initialized in.
Resolves compiler warnings with gcc and clang
 2018-11-27 05:04:51 -05:00
Lioncash
53bff53791 yuzu/configure_input: Remove unused function MoveGridElement 2018-11-27 05:03:26 -05:00
Lioncash
d67e88e59c yuzu/configure_input*: Move data members after function declarations 
The common pattern is to put the data members after the function
interface where applicable.
 2018-11-27 05:02:15 -05:00
Lioncash
ec7ea4ae96 yuzu/configure_input: Remove unnecessary includes 2018-11-27 05:00:56 -05:00
bunnei
d01bf170c4
Merge pull request #1725 from FernandoS27/gl43 
Update OpenGL's backend version from 3.3 to 4.3
 2018-11-23 23:56:57 -05:00
bunnei
e65966bcfc
Merge pull request #1708 from ogniK5377/res-scale 
Report resolution scaling support for vi and am
 2018-11-23 23:32:19 -05:00
bunnei
67ff974387
Merge pull request #1747 from DarkLordZach/exefs-lfs 
patch_manager: Add support for applying LayeredFS patches to ExeFS
 2018-11-23 23:31:48 -05:00
greggameplayer
c14af2f71d
correct clang-format 2018-11-22 18:26:43 +01:00
greggameplayer
6d2adb0bc0
Automatically disable joycons docked 
when docked mode is enable
 2018-11-22 01:24:39 +01:00
FernandoS27
0368260c99 Removed pre 4.3 ARB extensions 2018-11-21 11:43:17 -04:00
FernandoS27
377c60645c Update OpenGL's backend version from 3.3 to 4.3 2018-11-21 11:43:17 -04:00
Zach Hilman
54e74b3572 patch_manager: Show LayeredExeFS patch in add-ons column 
The decision was made to name them LayeredExeFS instead of just LayeredFS to differentiate from normal RomFS-based mods. The name may be long/unweildy, but conveys the meaning well.
 2018-11-20 19:22:34 -05:00
Zach Hilman
17d8e25cbf settings: Add option to dump ExeFS of games upon launch 
When enabled, all exefs(es) will be copied to yuzu/dump/<title_id>/exefs.
 2018-11-20 17:49:09 -05:00
Lioncash
4dcdd3a837 yuzu/applets/software_keyboard: Override accept() and reject() instead of providing own differently named member functions 
Uses Qt's built-in interface instead of rolling our own separate one on
top of it. This also fixes a bug in reject() where we were calling
accept() instead of reject().
 2018-11-20 11:36:50 -05:00
Lioncash
3fa2b218ac yuzu/applets/software_keyboard: std::move std::function instances where applicable 
std::function instances can potentially allocate. std::moveing them
prevents an avoidable allocation in that case.
 2018-11-20 11:34:19 -05:00
Lioncash
fe2609cb77 yuzu/applets/software_keyboard: Make slots private functions 
These aren't required to be public.
 2018-11-20 11:29:22 -05:00
bunnei
b6d2c64f4d
Merge pull request #1667 from DarkLordZach/swkbd 
am: Implement HLE software keyboard applet
 2018-11-20 08:24:11 -08:00
Zach Hilman
aef0d88165 configure_input: Use Joycons Docked instead of Connected as label 2018-11-18 23:22:36 -05:00
Zach Hilman
312ef596a5 configure_input_player: Set minimum width on controls 2018-11-18 23:22:36 -05:00
Zach Hilman
dd92db3fb0 configure_input: Properly update UI components on removal of player 2018-11-18 23:22:36 -05:00
Zach Hilman
e58c951a59 configure_input: Make None a controller option instead of checkbox 2018-11-18 23:22:36 -05:00
Zach Hilman
3a6cd5b3c8 hid: Use player-defined controller type as PREFERRED_CONTROLLER 2018-11-18 23:22:36 -05:00
Zach Hilman
3d1a221893 qt: Move controller button config to separate dialog 
Handles button configuration for all controller layouts and debug pads. Configurable at construction.
 2018-11-18 23:22:36 -05:00
Zach Hilman
afe8df5020 qt: Add UI to configure touchscreen parameters 
This allows adjusting the finger, diameter, and angle of the emulated touchscreen. It also provides a warning to the user about what changing these parameters can do.
 2018-11-18 23:22:36 -05:00
Zach Hilman
2e1dd9c649 qt: Add UI to configure mouse buttons 
Supports setting the five mouse buttons to any valid controller button/keyboard key (Left, Right, Middle, Foward, Back)
 2018-11-18 23:22:36 -05:00
Zach Hilman
f1aec256d7 configure_input: Add support for multiplayer and controller types 
This moves the actual button configuration to a separate dialog and only has the enabled and type controls in the tab.
 2018-11-18 23:22:36 -05:00
Zach Hilman
d1b7c65b9e yuzu/config: Add (de-)serialization for multiplayer 
Defaults to full keyboard for keyboard -- It did not seem to be necessary to make the keyboard configurable (besides enabled/disabled).
 2018-11-18 23:22:36 -05:00
bunnei
3e93c30630
Merge pull request #1640 from DarkLordZach/game-list-reload 
game_list: Only reload game list after relevant settings changed
 2018-11-18 19:24:53 -08:00
Zach Hilman
56cf5b7b17 software_keyboard: Add max and current length display to dialog 2018-11-18 10:53:47 -05:00
Zach Hilman
19b2571aec applet: Add operation completed callback 2018-11-18 10:53:47 -05:00
Zach Hilman
8b433beff3 software_keyboard: Make GetText asynchronous 
a
 2018-11-18 10:53:47 -05:00
Zach Hilman
7cfb29de23 am: Allow applets to push multiple and different channels of data 2018-11-18 10:53:47 -05:00
Zach Hilman
fed6ab14c3 am: Implement text check software keyboard mode 
Allows the game to verify and send a message to the frontend.
 2018-11-18 10:53:47 -05:00
Zach Hilman
e696ed1f4d am: Deglobalize software keyboard applet 2018-11-18 10:53:47 -05:00
Zach Hilman
a81645400f qt/main: Register Qt Software Keyboard frontend with AM 
Allows using Qt provider over default.
 2018-11-18 10:53:47 -05:00
Zach Hilman
5454494adb qt/applets: Provide Qt frontend implementation of software keyboard 
Implements all of the features of the keyboard, including length, default text, character validation, and UTF-16 character support.
 2018-11-18 10:53:47 -05:00
bunnei
0072275d25
Merge pull request #1678 from FearlessTobi/amiibo-hotkeys 
Port citra-emu/citra#4387: "yuzu: Add hotkey for Amiibo loading"
 2018-11-16 20:20:41 -08:00
bunnei
5b8f70ea2e
Merge pull request #1632 from DarkLordZach/keys-manager-optimizations 
game_list: Optimize game list refresh
 2018-11-16 07:02:37 -08:00
David Marcec
4476fd29d6 Fixed switching operation modes when not running a game 
The service manager seems to be a nullptr before a game boots
 2018-11-16 20:08:02 +11:00
David Marcec
9359655712 Report resolution scaling support for vi and am 
Specifying an internal resolution in yuzu now will report the scaled changes to vi and am.
 2018-11-16 18:07:42 +11:00
bunnei
97605e36f7
Merge pull request #1618 from DarkLordZach/dump-nso 
patch_manager: Add support for dumping uncompressed NSOs
 2018-11-15 14:46:10 -08:00
Lioncash
e6676afa18 yuzu/configure_system: Mark the entropy mask string as nontranslatable 
There's no need for translators to concern themselves with the
validation mask used by the entry field.
 2018-11-14 14:53:43 -05:00
bunnei
e1ea8cc721
Merge pull request #1679 from DarkLordZach/deterministic-rng-2 
svc: Use proper random entropy generation algorithm
 2018-11-14 11:52:27 -08:00
Zach Hilman
6001af2b89 qt: Move Open yuzu Folder action from Help to File 2018-11-13 17:17:47 -05:00
Zach Hilman
ab552e4a25 svc: Use proper random entropy generation algorithm 2018-11-13 12:26:03 -05:00
fearlessTobi
9ea8eb6b2e yuzu: Add hotkey for Amiibo loading 2018-11-13 15:10:39 +01:00
bunnei
7f3c2525e6
Merge pull request #1670 from DarkLordZach/deterministic-rng 
csrng: Add config option to set RNG seed
 2018-11-12 21:10:08 -08:00
Zach Hilman
cb1e63ef09 svc: Return random seed for svcGetInfo RandomEntropy 2018-11-12 21:46:21 -05:00
bunnei
d08b876c9d
Merge pull request #1650 from FreddyFunk/cast 
yuzu/main: Fix compiler warning
 2018-11-12 18:32:54 -08:00
James Rowe
b4a6ce02ce
Merge pull request #1674 from FearlessTobi/fullscreen-fix 
yuzu: Add a missing "!" to fix the stuck-in-fullscreen bug
 2018-11-12 13:00:25 -07:00
Tobias
9333ee29ca
yuzu: Add a missing "!" to fix the stuck-in-fullscreen bug 2018-11-12 20:57:15 +01:00
Zach Hilman
2a16fd7ffc settings: Add config option to set RNG seed 2018-11-11 23:09:46 -05:00
bunnei
7474382266
Merge pull request #1652 from FreddyFunk/static-cast 
configure_system: Fix compiler warning
 2018-11-11 12:19:03 -08:00
David Marcec
40db288a2a Renamed CheckIfOperationChanged to OnDockedModeChanged 2018-11-08 12:12:00 +11:00
David Marcec
fd1ef25257 Fixups 2018-11-07 20:12:27 +11:00
David Marcec
41e99d8880 Ability to switch between docked and undocked mode in-game 
Started implementation of the AM message queue mainly used in state getters. Added the ability to switch docked mode whilst in game without stopping emulation. Also removed some things which shouldn't be labelled as stubs as they're implemented correctly
 2018-11-07 18:01:33 +11:00
Frederic Laing
d34d0bfc87 configure_system: Fix compiler warning 2018-11-06 16:38:10 +01:00
Frederic Laing
6c8b788d32 yuzu/main: Fix compiler warning 2018-11-06 15:22:24 +01:00
bunnei
e10483a878
Merge pull request #1441 from CarlKenner/DebuggerLog 
logging: Add DebuggerBackend for logging to Visual Studio
 2018-11-05 00:19:59 -05:00
bunnei
acdc770cfb
Merge pull request #1639 from DarkLordZach/open-yuzu-folder 
qt: Add help option to open yuzu folder
 2018-11-05 00:19:15 -05:00
bunnei
38c1c500ab
Merge pull request #1625 from FernandoS27/astc 
Implement ASTC Textures 5x5 and fix a bunch of ASTC texture problems
 2018-11-04 18:47:26 -05:00
Dharmin K Shah
b2647dba33
Fix quickstart link 2018-11-05 00:36:49 +05:30
Zach Hilman
52e7e8eed3 game_list: Only reload game list after relevant settings changed 
Prevents unnecessary reloads on every configuration operation.
 2018-11-03 20:38:39 -04:00
Zach Hilman
97187b7ef6 qt: Add help option to open yuzu folder 
Opens a new file manager window at the UserDir.
 2018-11-03 12:48:34 -04:00
Zach Hilman
2d2ef05d8c game_list: Make add-ons column optional 
As the add-ons column takes the most processing time out of any (as it needs to search registration for updates/dlc, patch control NCAs, search for mods, etc.), an option was added to disable it. This does not affect the application of add-ons. In large game collections, this decreases game list refresh time by as much as 70%.
 2018-11-01 20:27:12 -04:00
FernandoS27
60a184455c Fix ASTC Decompressor to support depth parameter 2018-11-01 19:22:12 -04:00
bunnei
1069eced84
Merge pull request #1615 from lioncash/input 
configure_system: Contrain profile usernames to 32 characters
 2018-11-01 19:10:26 -04:00
FernandoS27
aee93f98f9 Fix ASTC formats 2018-11-01 13:08:19 -04:00
bunnei
d08457f879
Merge pull request #1604 from FearlessTobi/port-4369 
Port citra-emu/citra#4369: "compatdb: Use a seperate endpoint for testcase submission"
 2018-10-31 22:37:07 -04:00
Lioncash
a6830e61b8 configure_system: Contrain profile usernames to 32 characters 
Previously, we would let a user enter an unbounded name and then
silently truncate away characters that went over the 32-character limit.
This is kind of bad from the UX point of view, because we're essentially
not doing what the user intended in certain scenarios.

Instead, we clamp it to 32 characters and make that visually apparent in
the dialog box to provide a name for a user.
 2018-10-31 02:05:00 -04:00
bunnei
da5fcbf501
Merge pull request #1624 from lioncash/boost 
general: Remove unused boost inclusions where applicable
 2018-10-30 13:13:39 -04:00
bunnei
c31412c433
Merge pull request #1595 from FreddyFunk/cast 
configure_system: Fix compiler warning
 2018-10-30 00:27:41 -04:00