Address more review comments
* Make Validation a singleton instead * Wording changes for error messages * Smart pointers for Ui members * Other minor nitpicks
This commit is contained in:
@@ -22,7 +22,7 @@
|
||||
Lobby::Lobby(QWidget* parent, QStandardItemModel* list,
|
||||
std::shared_ptr<Core::AnnounceMultiplayerSession> session)
|
||||
: QDialog(parent, Qt::WindowTitleHint | Qt::WindowCloseButtonHint | Qt::WindowSystemMenuHint),
|
||||
ui(new Ui::Lobby), announce_multiplayer_session(session), game_list(list) {
|
||||
ui(std::make_unique<Ui::Lobby>()), announce_multiplayer_session(session), game_list(list) {
|
||||
ui->setupUi(this);
|
||||
|
||||
// setup the watcher for background connections
|
||||
@@ -48,7 +48,7 @@ Lobby::Lobby(QWidget* parent, QStandardItemModel* list,
|
||||
ui->room_list->setExpandsOnDoubleClick(false);
|
||||
ui->room_list->setContextMenuPolicy(Qt::CustomContextMenu);
|
||||
|
||||
ui->nickname->setValidator(Validation::nickname);
|
||||
ui->nickname->setValidator(Validation::get().nickname);
|
||||
ui->nickname->setText(UISettings::values.nickname);
|
||||
|
||||
// UI Buttons
|
||||
@@ -74,7 +74,7 @@ Lobby::Lobby(QWidget* parent, QStandardItemModel* list,
|
||||
RefreshLobby();
|
||||
}
|
||||
|
||||
const QString Lobby::PasswordPrompt() {
|
||||
QString Lobby::PasswordPrompt() {
|
||||
bool ok;
|
||||
const QString text =
|
||||
QInputDialog::getText(this, tr("Password Required to Join"), tr("Password:"),
|
||||
|
||||
Reference in New Issue
Block a user