H3cJP/citra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

configure_graphics: Simplify UpdateAPILayout

Browse Source 
Reduces branching/swictch cases for simplicity/code size
This commit is contained in:
lat9nq 2023-06-15 17:45:33 -04:00
parent 57a00e01d6
commit 916c6cd1a0
1 changed files with 16 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
src/yuzu/configuration/configure_graphics.cpp
View File

@ -33,6 +33,7 @@
#include "common/dynamic_library.h" #include "common/dynamic_library.h"
#include "common/logging/log.h" #include "common/logging/log.h"
#include "common/settings.h" #include "common/settings.h"
#include "common/settings_enums.h"
#include "core/core.h" #include "core/core.h"
#include "ui_configure_graphics.h" #include "ui_configure_graphics.h"
#include "yuzu/configuration/configuration_shared.h" #include "yuzu/configuration/configuration_shared.h"
@ -442,36 +443,24 @@ void ConfigureGraphics::UpdateBackgroundColorButton(QColor color) {
void ConfigureGraphics::UpdateAPILayout() { void ConfigureGraphics::UpdateAPILayout() {
bool runtime_lock = !system.IsPoweredOn(); bool runtime_lock = !system.IsPoweredOn();
if (!Settings::IsConfiguringGlobal() && !api_restore_global_button->isEnabled()) { bool need_global = !(Settings::IsConfiguringGlobal() || api_restore_global_button->isEnabled());
vulkan_device = Settings::values.vulkan_device.GetValue(true); vulkan_device = Settings::values.vulkan_device.GetValue(need_global);
shader_backend = Settings::values.shader_backend.GetValue(true); shader_backend = Settings::values.shader_backend.GetValue(need_global);
vulkan_device_widget->setEnabled(false); vulkan_device_widget->setEnabled(!need_global && runtime_lock);
shader_backend_widget->setEnabled(false); shader_backend_widget->setEnabled(!need_global && runtime_lock);
} else {
vulkan_device = Settings::values.vulkan_device.GetValue();
shader_backend = Settings::values.shader_backend.GetValue();
vulkan_device_widget->setEnabled(runtime_lock);
shader_backend_widget->setEnabled(runtime_lock);
}
switch (GetCurrentGraphicsBackend()) { const auto current_backend = GetCurrentGraphicsBackend();
case Settings::RendererBackend::OpenGL: const bool is_opengl = current_backend == Settings::RendererBackend::OpenGL;
const bool is_vulkan = current_backend == Settings::RendererBackend::Vulkan;
vulkan_device_widget->setVisible(is_vulkan);
shader_backend_widget->setVisible(is_opengl);
if (is_opengl) {
shader_backend_combobox->setCurrentIndex( shader_backend_combobox->setCurrentIndex(
FindIndex(typeid(Settings::ShaderBackend), static_cast<int>(shader_backend))); FindIndex(typeid(Settings::ShaderBackend), static_cast<int>(shader_backend)));
vulkan_device_widget->setVisible(false); } else if (is_vulkan && static_cast<int>(vulkan_device) < vulkan_device_combobox->count()) {
shader_backend_widget->setVisible(true); vulkan_device_combobox->setCurrentIndex(vulkan_device);
break;
case Settings::RendererBackend::Vulkan:
if (static_cast<int>(vulkan_device) < vulkan_device_combobox->count()) {
vulkan_device_combobox->setCurrentIndex(vulkan_device);
}
vulkan_device_widget->setVisible(true);
shader_backend_widget->setVisible(false);
break;
case Settings::RendererBackend::Null:
vulkan_device_widget->setVisible(false);
shader_backend_widget->setVisible(false);
break;
} }
} }