From fb941c56d85dab83466be9d690fb0d36a0135322 Mon Sep 17 00:00:00 2001 From: Ben Russell Date: Thu, 9 Apr 2020 18:48:28 +0100 Subject: [PATCH] common/file_util: Allow access to files on network shares On Windows, network shares use paths like \\server\share\file which were being broken by FileUtil::SanitizePath() removing double slashes. Changed the code in SanitizePath to permit a double-backslash if it occurs at the start of a filepath (on Windows only). --- src/common/file_util.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/common/file_util.cpp b/src/common/file_util.cpp index fd1a3fd309..55d75c0e0a 100644 --- a/src/common/file_util.cpp +++ b/src/common/file_util.cpp @@ -902,7 +902,14 @@ std::string SanitizePath(std::string_view path_, DirectorySeparator directory_se } std::replace(path.begin(), path.end(), type1, type2); - path.erase(std::unique(path.begin(), path.end(), + + auto start = path.begin(); +#ifdef _WIN32 + // allow network paths which start with a double backslash (e.g. \\server\share) + if (start != path.end()) + ++start; +#endif + path.erase(std::unique(start, path.end(), [type2](char c1, char c2) { return c1 == type2 && c2 == type2; }), path.end()); return std::string(RemoveTrailingSlash(path));