citra/src/yuzu/ui_settings.cpp

// Copyright 2016 Citra Emulator Project
// Licensed under GPLv2 or any later version
// Refer to the license.txt file included.

#include "ui_settings.h"

namespace UISettings {

const Themes themes{{
    {"Default", "default"},
    {"Dark", "qdarkstyle"},
}};

Values values = {};
} // namespace UISettings
Add Configure widget 2016-01-24 17:34:05 +00:00			`// Copyright 2016 Citra Emulator Project`
			`// Licensed under GPLv2 or any later version`
			`// Refer to the license.txt file included.`

			`#include "ui_settings.h"`

			`namespace UISettings {`

ui_settings: Place definition of the theme array within the cpp file Placing the array wholesale into the header places a copy of the whole array into every translation unit that uses the data, which is wasteful. Particularly given that this array is referenced from three different translation units. This also changes the array to contain pairs of const char*, rather than QString instances. This way, the string data is able to be fixed into the read-only segment of the program, as well as eliminate static constructors/heap allocation immediately on program start. 2018-10-04 10:33:17 +00:00			`const Themes themes{{`
			`{"Default", "default"},`
			`{"Dark", "qdarkstyle"},`
			`}};`

Add Configure widget 2016-01-24 17:34:05 +00:00			`Values values = {};`
ui_settings: Place definition of the theme array within the cpp file Placing the array wholesale into the header places a copy of the whole array into every translation unit that uses the data, which is wasteful. Particularly given that this array is referenced from three different translation units. This also changes the array to contain pairs of const char*, rather than QString instances. This way, the string data is able to be fixed into the read-only segment of the program, as well as eliminate static constructors/heap allocation immediately on program start. 2018-10-04 10:33:17 +00:00			`} // namespace UISettings`